mirror of
https://github.com/bitwarden/server.git
synced 2025-02-18 02:11:22 +01:00
* [AC-1423] Add AddonProduct and BitwardenProduct properties to BillingSubscriptionItem (#3037)
* [AC-1423] Add AddonProduct and BitwardenProduct properties to BillingSubscriptionItem
- Add a helper method to determine the appropriate addon type based on the subscription items StripeId
* [AC-1423] Add helper to StaticStore.cs to find a Plan by StripePlanId
* [AC-1423] Use the helper method to set SubscriptionInfo.BitwardenProduct
* Add SecretsManagerBilling feature flag to Constants
* [AC 1409] Secrets Manager Subscription Stripe Integration (#3019)
* Adding the Secret manager to the Plan List
* Adding the unit test for the StaticStoreTests class
* Fix whitespace formatting
* Fix whitespace formatting
* Price update
* Resolving the PR comments
* Resolving PR comments
* Fixing the whitespace
* only password manager plans are return for now
* format whitespace
* Resolve the test issue
* Fixing the failing test
* Refactoring the Plan separation
* add a unit test for SingleOrDefault
* Fix the whitespace format
* Separate the PM and SM plans
* Fixing the whitespace
* Remove unnecessary directive
* Fix imports ordering
* Fix imports ordering
* Resolve imports ordering
* Fixing imports ordering
* Fix response model, add MaxProjects
* Fix filename
* Fix format
* Fix: seat price should match annual/monthly
* Fix service account annual pricing
* Changes for secret manager signup and upgradeplan
* Changes for secrets manager signup and upgrade
* refactoring the code
* Format whitespace
* remove unnecessary using directive
* Resolve the PR comment on Subscription creation
* Resolve PR comment
* Add password manager to the error message
* Add UseSecretsManager to the event log
* Resolve PR comment on plan validation
* Resolving pr comments for service account count
* Resolving pr comments for service account count
* Resolve the pr comments
* Remove the store procedure that is no-longer needed
* Rename a property properly
* Resolving the PR comment
* Resolve PR comments
* Resolving PR comments
* Resolving the Pr comments
* Resolving some PR comments
* Resolving the PR comments
* Resolving the build identity build
* Add additional Validation
* Resolve the Lint issues
* remove unnecessary using directive
* Remove the white spaces
* Adding unit test for the stripe payment
* Remove the incomplete test
* Fixing the failing test
* Fix the failing test
* Fix the fail test on organization service
* Fix the failing unit test
* Fix the whitespace format
* Fix the failing test
* Fix the whitespace format
* resolve pr comments
* Fix the lint message
* Resolve the PR comments
* resolve pr comments
* Resolve pr comments
* Resolve the pr comments
* remove unused code
* Added for sm validation test
* Fix the whitespace format issues
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
* SM-802: Add SecretsManagerBetaColumn SQL migration and Org table update
* SM-802: Run EF Migrations for SecretsManagerBeta
* SM-802: Update the two Org procs and View, and move data migration to a separate file
* SM-802: Add missing comma to Organization_Create
* [AC-1418] Add missing SecretsManagerPlan property to OrganizationResponseModel (#3055)
* SM-802: Remove extra GO statement from data migration script
* [AC 1460] Update Stripe Configuration (#3070)
* change the stripeseat id
* change service accountId to align with new product
* make all the Id name for consistent
* SM-802: Add SecretsManagerBeta to OrganizationResponseModel
* SM-802: Move SecretsManagerBeta from OrganizationResponseModel to OrganizationSubscriptionResponseModel. Use sp_refreshview instead of sp_refreshsqlmodule in the migration script.
* SM-802: Remove OrganizationUserOrganizationDetailsView.sql changes
* [AC 1410] Secrets Manager subscription adjustment back-end changes (#3036)
* Create UpgradeSecretsManagerSubscription command
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
* SM-802: Remove SecretsManagerBetaColumn migration
* SM-802: Add SecretsManagerBetaColumn migration
* SM-802: Remove OrganizationUserOrganizationDetailsView update
* [AC-1495] Extract UpgradePlanAsync into a command (#3081)
* This is a pure lift & shift with no refactors
* Only register subscription commands in Api
---------
Co-authored-by: cyprain-okeke <cokeke@bitwarden.com>
* [AC-1503] Fix Stripe integration on organization upgrade (#3084)
* Fix SM parameters not being passed to Stripe
* Fix flaky test
* Fix error message
* [AC-1504] Allow SM max autoscale limits to be disabled (#3085)
* [AC-1488] Changed SM Signup and Upgrade paths to set SmServiceAccounts to include the plan BaseServiceAccount (#3086)
* [AC-1510] Enable access to Secrets Manager to Organization owner for new Subscription (#3089)
* Revert changes to ReferenceEvent code (#3091)
* Revert changes to ReferenceEvent code
This will be done in AC-1481
* Revert ReferenceEventType change
* Move NoopServiceAccountRepository to SM and update namespace
* [AC-1462] Add secrets manager service accounts autoscaling commands (#3059)
* Adding the Secret manager to the Plan List
* Adding the unit test for the StaticStoreTests class
* Fix whitespace formatting
* Fix whitespace formatting
* Price update
* Resolving the PR comments
* Resolving PR comments
* Fixing the whitespace
* only password manager plans are return for now
* format whitespace
* Resolve the test issue
* Fixing the failing test
* Refactoring the Plan separation
* add a unit test for SingleOrDefault
* Fix the whitespace format
* Separate the PM and SM plans
* Fixing the whitespace
* Remove unnecessary directive
* Fix imports ordering
* Fix imports ordering
* Resolve imports ordering
* Fixing imports ordering
* Fix response model, add MaxProjects
* Fix filename
* Fix format
* Fix: seat price should match annual/monthly
* Fix service account annual pricing
* Changes for secret manager signup and upgradeplan
* Changes for secrets manager signup and upgrade
* refactoring the code
* Format whitespace
* remove unnecessary using directive
* Changes for subscription Update
* Update the seatAdjustment and update
* Resolve the PR comment on Subscription creation
* Resolve PR comment
* Add password manager to the error message
* Add UseSecretsManager to the event log
* Resolve PR comment on plan validation
* Resolving pr comments for service account count
* Resolving pr comments for service account count
* Resolve the pr comments
* Remove the store procedure that is no-longer needed
* Add a new class for update subscription
* Modify the Update subscription for sm
* Add the missing property
* Rename a property properly
* Resolving the PR comment
* Resolve PR comments
* Resolving PR comments
* Resolving the Pr comments
* Resolving some PR comments
* Resolving the PR comments
* Resolving the build identity build
* Add additional Validation
* Resolve the Lint issues
* remove unnecessary using directive
* Remove the white spaces
* Adding unit test for the stripe payment
* Remove the incomplete test
* Fixing the failing test
* Fix the failing test
* Fix the fail test on organization service
* Fix the failing unit test
* Fix the whitespace format
* Fix the failing test
* Fix the whitespace format
* resolve pr comments
* Fix the lint message
* refactor the code
* Fix the failing Test
* adding a new endpoint
* Remove the unwanted code
* Changes for Command and Queries
* changes for command and queries
* Fix the Lint issues
* Fix imports ordering
* Resolve the PR comments
* resolve pr comments
* Resolve pr comments
* Fix the failing test on adjustSeatscommandtests
* Fix the failing test
* Fix the whitespaces
* resolve failing test
* rename a property
* Resolve the pr comments
* refactoring the existing implementation
* Resolve the whitespaces format issue
* Resolve the pr comments
* [AC-1462] Created IAvailableServiceAccountsQuery along its implementation and with unit tests
* [AC-1462] Renamed ICountNewServiceAccountSlotsRequiredQuery
* [AC-1462] Added IAutoscaleServiceAccountsCommand and implementation
* Add more unit testing
* fix the whitespaces issues
* [AC-1462] Added unit tests for AutoscaleServiceAccountsCommand
* Add more unit test
* Remove unnecessary directive
* Resolve some pr comments
* Adding more unit test
* adding more test
* add more test
* Resolving some pr comments
* Resolving some pr comments
* Resolving some pr comments
* resolve some pr comments
* Resolving pr comments
* remove whitespaces
* remove white spaces
* Resolving pr comments
* resolving pr comments and fixing white spaces
* resolving the lint error
* Run dotnet format
* resolving the pr comments
* Add a missing properties to plan response model
* Add the email sender for sm seat and service acct
* Add the email sender for sm seat and service acct
* Fix the failing test after email sender changes
* Add staticstorewrapper to properly test the plans
* Add more test and validate the existing test
* Fix the white spaces issues
* Remove staticstorewrapper and fix the test
* fix a null issue on autoscaling
* Suggestion: do all seat calculations in update model
* Resolve some pr comments
* resolving some pr comments
* Return value is unnecessary
* Resolve the failing test
* resolve pr comments
* Resolve the pr comments
* Resolving admin api failure and adding more test
* Resolve the issue failing admin project
* Fixing the failed test
* Clarify naming and add comments
* Clarify naming conventions
* Dotnet format
* Fix the failing dependency
* remove similar test
* [AC-1462] Rewrote AutoscaleServiceAccountsCommand to use UpdateSecretsManagerSubscriptionCommand which has the same logic
* [AC-1462] Deleted IAutoscaleServiceAccountsCommand as the logic will be moved to UpdateSecretsManagerSubscriptionCommand
* [AC-1462] Created method AdjustSecretsManagerServiceAccountsAsync
* [AC-1462] Changed SecretsManagerSubscriptionUpdate to only be set by its constructor
* [AC-1462] Added check to CountNewServiceAccountSlotsRequiredQuery and revised unit tests
* [AC-1462] Revised logic for CountNewServiceAccountSlotsRequiredQuery and fixed unit tests
* [AC-1462] Changed SecretsManagerSubscriptionUpdate to receive Organization as a parameter and fixed the unit tests
* [AC-1462] Renamed IUpdateSecretsManagerSubscriptionCommand methods UpdateSubscriptionAsync and AdjustServiceAccountsAsync
* [AC-1462] Rewrote unit test UpdateSubscriptionAsync_ValidInput_Passes
* [AC-1462] Registered CountNewServiceAccountSlotsRequiredQuery for dependency injection
* [AC-1462] Added parameter names to SecretsManagerSubscriptionUpdateRequestModel
* [AC-1462] Updated SecretsManagerSubscriptionUpdate logic to handle null parameters. Revised the unit tests to test null values
---------
Co-authored-by: cyprain-okeke <cokeke@bitwarden.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
* Add UsePasswordManager to sync data (#3114)
* [AC-1522] Fix service account check on upgrading (#3111)
* Resolved the checkmarx issues
* [AC-1521] Address checkmarx security feedback (#3124)
* Reinstate target attribute but add noopener noreferrer
* Update date on migration script
* Remove unused constant
* Revert "Remove unused constant"
This reverts commit 4fcb9da4d6
.
This is required to make feature flags work on the client
* [AC-1458] Add Endpoint And Service Logic for secrets manager to existing subscription (#3087)
---------
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
* Remove duplicate migrations from incorrectly resolved merge
* [AC-1468] Modified CountNewServiceAccountSlotsRequiredQuery to return zero if organization has SecretsManagerBeta == true (#3112)
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
* [Ac 1563] Unable to load billing and subscription related pages for non-enterprise organizations (#3138)
* Resolve the failing family plan
* resolve issues
* Resolve code related pr comments
* Resolve test related comments
* Resolving or comments
* [SM-809] Add service account slot limit check (#3093)
* Add service account slot limit check
* Add query to DI
* [AC-1462] Registered CountNewServiceAccountSlotsRequiredQuery for dependency injection
* remove duplicate DI entry
* Update unit tests
* Remove comment
* Code review updates
---------
Co-authored-by: cyprain-okeke <cokeke@bitwarden.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Rui Tome <rtome@bitwarden.com>
* [AC-1461] Secrets manager seat autoscaling (#3121)
* Add autoscaling code to invite user, save user, and bulk enable SM
flows
* Add tests
* Delete command for BulkEnableSecretsManager
* circular dependency between OrganizationService and
UpdateSecretsManagerSubscriptionCommand - fixed by temporarily
duplicating ReplaceAndUpdateCache
* Unresolvable dependencies in other services - fixed by temporarily
registering noop services and moving around some DI code
All should be resolved in PM-1880
* Refactor: improve the update object and use it to adjust values,
remove excess interfaces on the command
* Handle autoscaling-specific errors
---------
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
* Move bitwarden_license include reference into conditional block
* [AC 1526]Show current SM seat and service account usage in Bitwarden Portal (#3142)
* changes base on the tickets request
* Code refactoring
* Removed the unwanted method
* Add implementation to the new method
* Resolve some pr comments
* resolve lint issue
* resolve pr comments
* add the new noop files
* Add new noop file and resolve some pr comments
* resolve pr comments
* removed unused method
---------
Co-authored-by: Shane Melton <smelton@bitwarden.com>
Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com>
Co-authored-by: Colton Hurst <colton@coltonhurst.com>
Co-authored-by: cyprain-okeke <cokeke@bitwarden.com>
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
Co-authored-by: Conner Turnbull <cturnbull@bitwarden.com>
Co-authored-by: Rui Tome <rtome@bitwarden.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
746 lines
34 KiB
C#
746 lines
34 KiB
C#
using Bit.Core.Entities;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Models.Business;
|
|
using Bit.Core.Models.StaticStore;
|
|
using Bit.Core.OrganizationFeatures.OrganizationSubscriptions;
|
|
using Bit.Core.Repositories;
|
|
using Bit.Core.SecretsManager.Repositories;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Settings;
|
|
using Bit.Core.Utilities;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.OrganizationFeatures.OrganizationSubscriptionUpdate;
|
|
|
|
[SutProviderCustomize]
|
|
public class UpdateSecretsManagerSubscriptionCommandTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_NoOrganization_Throws(
|
|
SecretsManagerSubscriptionUpdate secretsManagerSubscriptionUpdate,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
secretsManagerSubscriptionUpdate.Organization = null;
|
|
|
|
var exception = await Assert.ThrowsAsync<NotFoundException>(
|
|
() => sutProvider.Sut.UpdateSubscriptionAsync(secretsManagerSubscriptionUpdate));
|
|
|
|
Assert.Contains("Organization is not found", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_NoSecretsManagerAccess_ThrowsException(
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
SmSeats = 10,
|
|
SmServiceAccounts = 5,
|
|
UseSecretsManager = false,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 10
|
|
};
|
|
|
|
var secretsManagerSubscriptionUpdate = new SecretsManagerSubscriptionUpdate(organization, seatAdjustment: 0, maxAutoscaleSeats: null, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: null);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.UpdateSubscriptionAsync(secretsManagerSubscriptionUpdate));
|
|
|
|
Assert.Contains("Organization has no access to Secrets Manager.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_SeatsAdjustmentGreaterThanMaxAutoscaleSeats_ThrowsException(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 5,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 10,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 15, maxAutoscaleSeats: 10, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: null);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Cannot set max seat autoscaling below seat count.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_ServiceAccountsGreaterThanMaxAutoscaleSeats_ThrowsException(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 5,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 10,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "9"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 15, serviceAccountAdjustment: 11, maxAutoscaleServiceAccounts: 10);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Cannot set max service accounts autoscaling below service account amount", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_NullGatewayCustomerId_ThrowsException(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
SmServiceAccounts = 5,
|
|
UseSecretsManager = true,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 15,
|
|
PlanType = PlanType.EnterpriseAnnually
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 15, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: 15);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("No payment method found.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_NullGatewaySubscriptionId_ThrowsException(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 5,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 15,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 15, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: 15);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("No subscription found.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_OrgWithNullSmSeatOnSeatsAdjustment_ThrowsException(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = null,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 5,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 15,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 15, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: 15);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
|
|
Assert.Contains("Organization has no Secrets Manager seat limit, no need to adjust seats", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.Custom)]
|
|
[BitAutoData(PlanType.FamiliesAnnually)]
|
|
[BitAutoData(PlanType.FamiliesAnnually2019)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly2019)]
|
|
[BitAutoData(PlanType.EnterpriseAnnually2019)]
|
|
[BitAutoData(PlanType.TeamsMonthly2019)]
|
|
[BitAutoData(PlanType.TeamsAnnually2019)]
|
|
public async Task UpdateSubscriptionAsync_WithNonSecretsManagerPlanType_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 200,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 300,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 15, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: 300);
|
|
organization.PlanType = planType;
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Existing plan not found", exception.Message, StringComparison.InvariantCultureIgnoreCase);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.Free)]
|
|
public async Task UpdateSubscriptionAsync_WithHasAdditionalSeatsOptionFalse_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 2,
|
|
SmServiceAccounts = 3,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: null, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: null);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("You have reached the maximum number of Secrets Manager seats (2) for this plan",
|
|
exception.Message, StringComparison.InvariantCultureIgnoreCase);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.Free)]
|
|
public async Task UpdateSubscriptionAsync_WithHasAdditionalServiceAccountOptionFalse_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 2,
|
|
SmServiceAccounts = 3,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 0, maxAutoscaleSeats: null, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: null);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("You have reached the maximum number of service accounts (3) for this plan",
|
|
exception.Message, StringComparison.InvariantCultureIgnoreCase);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly)]
|
|
[BitAutoData(PlanType.TeamsMonthly)]
|
|
[BitAutoData(PlanType.TeamsAnnually)]
|
|
public async Task UpdateSubscriptionAsync_ValidInput_Passes(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
const int organizationServiceAccounts = 200;
|
|
const int seatAdjustment = 5;
|
|
const int maxAutoscaleSeats = 15;
|
|
const int serviceAccountAdjustment = 100;
|
|
const int maxAutoScaleServiceAccounts = 300;
|
|
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 10,
|
|
MaxAutoscaleSmSeats = 20,
|
|
SmServiceAccounts = organizationServiceAccounts,
|
|
MaxAutoscaleSmServiceAccounts = 350,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
|
|
var plan = StaticStore.SecretManagerPlans.FirstOrDefault(x => x.Type == organization.PlanType);
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization,
|
|
seatAdjustment: seatAdjustment, maxAutoscaleSeats: maxAutoscaleSeats,
|
|
serviceAccountAdjustment: serviceAccountAdjustment, maxAutoscaleServiceAccounts: maxAutoScaleServiceAccounts);
|
|
|
|
await sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate);
|
|
|
|
await sutProvider.GetDependency<IPaymentService>().Received(1)
|
|
.AdjustSeatsAsync(organization, plan, organizationUpdate.SmSeatsExcludingBase);
|
|
await sutProvider.GetDependency<IPaymentService>().Received(1)
|
|
.AdjustServiceAccountsAsync(organization, plan, organizationUpdate.SmServiceAccountsExcludingBase);
|
|
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
|
|
AssertUpdatedOrganization(() => Arg.Is<Organization>(org =>
|
|
org.Id == organizationId
|
|
&& org.SmSeats == organizationUpdate.SmSeats
|
|
&& org.MaxAutoscaleSmSeats == organizationUpdate.MaxAutoscaleSmSeats
|
|
&& org.SmServiceAccounts == (organizationServiceAccounts + serviceAccountAdjustment)
|
|
&& org.MaxAutoscaleSmServiceAccounts == organizationUpdate.MaxAutoscaleSmServiceAccounts), sutProvider);
|
|
|
|
await sutProvider.GetDependency<IMailService>().Received(1).SendSecretsManagerMaxSeatLimitReachedEmailAsync(organization, organization.MaxAutoscaleSmSeats.Value, Arg.Any<IEnumerable<string>>());
|
|
await sutProvider.GetDependency<IMailService>().Received(1).SendSecretsManagerMaxServiceAccountLimitReachedEmailAsync(organization, organization.MaxAutoscaleSmServiceAccounts.Value, Arg.Any<IEnumerable<string>>());
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly)]
|
|
[BitAutoData(PlanType.TeamsMonthly)]
|
|
[BitAutoData(PlanType.TeamsAnnually)]
|
|
public async Task UpdateSubscriptionAsync_ValidInput_WithNullMaxAutoscale_Passes(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
int organizationServiceAccounts = 200;
|
|
int seatAdjustment = 5;
|
|
int? maxAutoscaleSeats = null;
|
|
int serviceAccountAdjustment = 100;
|
|
int? maxAutoScaleServiceAccounts = null;
|
|
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 10,
|
|
MaxAutoscaleSmSeats = 20,
|
|
SmServiceAccounts = organizationServiceAccounts,
|
|
MaxAutoscaleSmServiceAccounts = 350,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
|
|
var plan = StaticStore.SecretManagerPlans.FirstOrDefault(x => x.Type == organization.PlanType);
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization,
|
|
seatAdjustment: seatAdjustment, maxAutoscaleSeats: maxAutoscaleSeats,
|
|
serviceAccountAdjustment: serviceAccountAdjustment, maxAutoscaleServiceAccounts: maxAutoScaleServiceAccounts);
|
|
|
|
await sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate);
|
|
|
|
await sutProvider.GetDependency<IPaymentService>().Received(1)
|
|
.AdjustSeatsAsync(organization, plan, organizationUpdate.SmSeatsExcludingBase);
|
|
await sutProvider.GetDependency<IPaymentService>().Received(1)
|
|
.AdjustServiceAccountsAsync(organization, plan, organizationUpdate.SmServiceAccountsExcludingBase);
|
|
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
|
|
AssertUpdatedOrganization(() => Arg.Is<Organization>(org =>
|
|
org.Id == organizationId
|
|
&& org.SmSeats == organizationUpdate.SmSeats
|
|
&& org.MaxAutoscaleSmSeats == organizationUpdate.MaxAutoscaleSmSeats
|
|
&& org.SmServiceAccounts == (organizationServiceAccounts + serviceAccountAdjustment)
|
|
&& org.MaxAutoscaleSmServiceAccounts == organizationUpdate.MaxAutoscaleSmServiceAccounts), sutProvider);
|
|
|
|
await sutProvider.GetDependency<IMailService>().DidNotReceiveWithAnyArgs().SendSecretsManagerMaxSeatLimitReachedEmailAsync(default, default, default);
|
|
await sutProvider.GetDependency<IMailService>().DidNotReceiveWithAnyArgs().SendSecretsManagerMaxServiceAccountLimitReachedEmailAsync(default, default, default);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_ThrowsBadRequestException_WhenMaxAutoscaleSeatsBelowSeatCount(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 5,
|
|
SmServiceAccounts = 200,
|
|
MaxAutoscaleSmSeats = 4,
|
|
MaxAutoscaleSmServiceAccounts = 300,
|
|
PlanType = PlanType.EnterpriseAnnually,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
var update = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 1, maxAutoscaleSeats: 4, serviceAccountAdjustment: 5, maxAutoscaleServiceAccounts: 300);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Cannot set max seat autoscaling below seat count.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task UpdateSubscriptionAsync_ThrowsBadRequestException_WhenOccupiedSeatsExceedNewSeatTotal(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 10,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2",
|
|
PlanType = PlanType.EnterpriseAnnually
|
|
};
|
|
var update = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: -3, maxAutoscaleSeats: 7, serviceAccountAdjustment: 5, maxAutoscaleServiceAccounts: 300);
|
|
|
|
sutProvider.GetDependency<IOrganizationUserRepository>().GetOccupiedSmSeatCountByOrganizationIdAsync(organizationId).Returns(8);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Your organization currently has 8 Secrets Manager seats. Your plan only allows 7 Secrets Manager seats. Remove some Secrets Manager users", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task AdjustServiceAccountsAsync_ThrowsBadRequestException_WhenSmServiceAccountsIsNull(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 10,
|
|
UseSecretsManager = true,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2",
|
|
SmServiceAccounts = null,
|
|
PlanType = PlanType.EnterpriseAnnually
|
|
};
|
|
var update = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 10, maxAutoscaleSeats: 21, serviceAccountAdjustment: 1, maxAutoscaleServiceAccounts: 250);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Organization has no Service Accounts limit, no need to adjust Service Accounts", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task AutoscaleSeatsAsync_ThrowsBadRequestException_WhenMaxAutoscaleSeatsExceedPlanMaxUsers(
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
SmSeats = 3,
|
|
UseSecretsManager = true,
|
|
SmServiceAccounts = 100,
|
|
PlanType = PlanType.Free,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2",
|
|
};
|
|
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 0, maxAutoscaleSeats: 15, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: 200);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Your plan has a Secrets Manager seat limit of 2, but you have specified a max autoscale count of 15.Reduce your max autoscale count.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.Free)]
|
|
public async Task AutoscaleSeatsAsync_ThrowsBadRequestException_WhenPlanDoesNotAllowSeatAutoscale(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 1,
|
|
SmServiceAccounts = 200,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 350,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 0, maxAutoscaleSeats: 1, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: 300);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Your plan does not allow Secrets Manager seat autoscaling", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.Free)]
|
|
public async Task UpdateServiceAccountAutoscaling_ThrowsBadRequestException_WhenPlanDoesNotAllowServiceAccountAutoscale(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 10,
|
|
SmServiceAccounts = 200,
|
|
MaxAutoscaleSmSeats = 20,
|
|
MaxAutoscaleSmServiceAccounts = 350,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 0, maxAutoscaleSeats: null, serviceAccountAdjustment: 0, maxAutoscaleServiceAccounts: 300);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Your plan does not allow Service Accounts autoscaling.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly)]
|
|
[BitAutoData(PlanType.TeamsMonthly)]
|
|
[BitAutoData(PlanType.TeamsAnnually)]
|
|
public async Task UpdateServiceAccountAutoscaling_WhenCurrentServiceAccountsIsGreaterThanNew_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
UseSecretsManager = true,
|
|
SmSeats = 10,
|
|
MaxAutoscaleSmSeats = 20,
|
|
SmServiceAccounts = 301,
|
|
MaxAutoscaleSmServiceAccounts = 350,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2"
|
|
};
|
|
|
|
var organizationUpdate = new SecretsManagerSubscriptionUpdate(
|
|
organization, seatAdjustment: 5, maxAutoscaleSeats: 15, serviceAccountAdjustment: -100, maxAutoscaleServiceAccounts: 300);
|
|
var currentServiceAccounts = 301;
|
|
|
|
sutProvider.GetDependency<IServiceAccountRepository>()
|
|
.GetServiceAccountCountByOrganizationIdAsync(organization.Id)
|
|
.Returns(currentServiceAccounts);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(organizationUpdate));
|
|
Assert.Contains("Your organization currently has 301 Service Accounts. Your plan only allows 201 Service Accounts. Remove some Service Accounts", exception.Message);
|
|
await sutProvider.GetDependency<IServiceAccountRepository>().Received(1).GetServiceAccountCountByOrganizationIdAsync(organization.Id);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly)]
|
|
[BitAutoData(PlanType.TeamsMonthly)]
|
|
[BitAutoData(PlanType.TeamsAnnually)]
|
|
public async Task AdjustServiceAccountsAsync_WithEnterpriseOrTeamsPlans_Success(PlanType planType, Guid organizationId,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
var plan = StaticStore.SecretManagerPlans.FirstOrDefault(p => p.Type == planType);
|
|
|
|
var organizationSeats = plan.BaseSeats + 10;
|
|
var organizationMaxAutoscaleSeats = 20;
|
|
var organizationServiceAccounts = plan.BaseServiceAccount.GetValueOrDefault() + 10;
|
|
var organizationMaxAutoscaleServiceAccounts = 300;
|
|
|
|
var organization = new Organization
|
|
{
|
|
Id = organizationId,
|
|
PlanType = planType,
|
|
GatewayCustomerId = "1",
|
|
GatewaySubscriptionId = "2",
|
|
UseSecretsManager = true,
|
|
SmSeats = organizationSeats,
|
|
MaxAutoscaleSmSeats = organizationMaxAutoscaleSeats,
|
|
SmServiceAccounts = organizationServiceAccounts,
|
|
MaxAutoscaleSmServiceAccounts = organizationMaxAutoscaleServiceAccounts
|
|
};
|
|
|
|
var smServiceAccountsAdjustment = 10;
|
|
var expectedSmServiceAccounts = organizationServiceAccounts + smServiceAccountsAdjustment;
|
|
var expectedSmServiceAccountsExcludingBase = expectedSmServiceAccounts - plan.BaseServiceAccount.GetValueOrDefault();
|
|
|
|
await sutProvider.Sut.AdjustServiceAccountsAsync(organization, smServiceAccountsAdjustment);
|
|
|
|
await sutProvider.GetDependency<IPaymentService>().Received(1).AdjustServiceAccountsAsync(
|
|
Arg.Is<Organization>(o => o.Id == organizationId),
|
|
plan,
|
|
expectedSmServiceAccountsExcludingBase);
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
AssertUpdatedOrganization(() => Arg.Is<Organization>(o =>
|
|
o.Id == organizationId
|
|
&& o.SmSeats == organizationSeats
|
|
&& o.MaxAutoscaleSmSeats == organizationMaxAutoscaleSeats
|
|
&& o.SmServiceAccounts == expectedSmServiceAccounts
|
|
&& o.MaxAutoscaleSmServiceAccounts == organizationMaxAutoscaleServiceAccounts), sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
public async Task ServiceAccountAutoscaling_MaxLimitReached_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Organization organization,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
organization.PlanType = planType;
|
|
organization.UseSecretsManager = true;
|
|
organization.SmServiceAccounts = 9;
|
|
organization.MaxAutoscaleSmServiceAccounts = 10;
|
|
|
|
var update = new SecretsManagerSubscriptionUpdate(organization, true);
|
|
update.AdjustServiceAccounts(2);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Secrets Manager service account limit has been reached.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
public async Task ServiceAccountAutoscaling_Subtracting_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Organization organization,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
organization.PlanType = planType;
|
|
organization.UseSecretsManager = true;
|
|
|
|
var update = new SecretsManagerSubscriptionUpdate(organization, true);
|
|
update.AdjustServiceAccounts(-2);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Cannot use autoscaling to subtract service accounts.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
public async Task SmSeatAutoscaling_MaxLimitReached_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Organization organization,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
organization.PlanType = planType;
|
|
organization.UseSecretsManager = true;
|
|
organization.SmSeats = 9;
|
|
organization.MaxAutoscaleSmSeats = 10;
|
|
|
|
var update = new SecretsManagerSubscriptionUpdate(organization, true);
|
|
update.AdjustSeats(2);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Secrets Manager seat limit has been reached.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
public async Task SmSeatAutoscaling_Subtracting_ThrowsBadRequestException(
|
|
PlanType planType,
|
|
Organization organization,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
organization.PlanType = planType;
|
|
organization.UseSecretsManager = true;
|
|
|
|
var update = new SecretsManagerSubscriptionUpdate(organization, true);
|
|
update.AdjustSeats(-2);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains("Cannot use autoscaling to subtract seats.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData(false, "Cannot update subscription on a self-hosted instance.")]
|
|
[BitAutoData(true, "Cannot autoscale on a self-hosted instance.")]
|
|
public async Task UpdatingSubscription_WhenSelfHosted_ThrowsBadRequestException(
|
|
bool autoscaling,
|
|
string expectedError,
|
|
Organization organization,
|
|
SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
organization.PlanType = PlanType.EnterpriseAnnually;
|
|
organization.UseSecretsManager = true;
|
|
|
|
var update = new SecretsManagerSubscriptionUpdate(organization, autoscaling);
|
|
update.AdjustSeats(2);
|
|
|
|
sutProvider.GetDependency<IGlobalSettings>().SelfHosted.Returns(true);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() => sutProvider.Sut.UpdateSubscriptionAsync(update));
|
|
Assert.Contains(expectedError, exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
private static async Task VerifyDependencyNotCalledAsync(SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
await sutProvider.GetDependency<IPaymentService>().DidNotReceive()
|
|
.AdjustSeatsAsync(Arg.Any<Organization>(), Arg.Any<Plan>(), Arg.Any<int>());
|
|
await sutProvider.GetDependency<IPaymentService>().DidNotReceive()
|
|
.AdjustServiceAccountsAsync(Arg.Any<Organization>(), Arg.Any<Plan>(), Arg.Any<int>());
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
await sutProvider.GetDependency<IMailService>().DidNotReceive()
|
|
.SendOrganizationMaxSeatLimitReachedEmailAsync(Arg.Any<Organization>(), Arg.Any<int>(),
|
|
Arg.Any<IEnumerable<string>>());
|
|
|
|
sutProvider.GetDependency<IOrganizationRepository>().DidNotReceiveWithAnyArgs().ReplaceAsync(default);
|
|
sutProvider.GetDependency<IApplicationCacheService>().DidNotReceiveWithAnyArgs().UpsertOrganizationAbilityAsync(default);
|
|
}
|
|
|
|
private void AssertUpdatedOrganization(Func<Organization> organizationMatcher, SutProvider<UpdateSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
sutProvider.GetDependency<IOrganizationRepository>().Received(1).ReplaceAsync(organizationMatcher());
|
|
sutProvider.GetDependency<IApplicationCacheService>().Received(1).UpsertOrganizationAbilityAsync(organizationMatcher());
|
|
}
|
|
}
|