mirror of
https://github.com/bitwarden/server.git
synced 2024-12-04 14:13:28 +01:00
0189952e1f
* Add check to verify the vault state for rotation is not obviously desynced (empty) * Add unit test for key rotation guardrail * Move de-synced vault detection to validators * Add tests
53 lines
2.2 KiB
C#
53 lines
2.2 KiB
C#
using Bit.Api.Vault.Models.Request;
|
|
using Bit.Api.Vault.Validators;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Vault.Entities;
|
|
using Bit.Core.Vault.Repositories;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.Vault.Validators;
|
|
|
|
[SutProviderCustomize]
|
|
public class FolderRotationValidatorTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task ValidateAsync_MissingFolder_Throws(SutProvider<FolderRotationValidator> sutProvider, User user,
|
|
IEnumerable<FolderWithIdRequestModel> folders)
|
|
{
|
|
var userFolders = folders.Select(f => f.ToFolder(new Folder())).ToList();
|
|
userFolders.Add(new Folder { Id = Guid.NewGuid(), Name = "Missing Folder" });
|
|
sutProvider.GetDependency<IFolderRepository>().GetManyByUserIdAsync(user.Id).Returns(userFolders);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.ValidateAsync(user, folders));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task ValidateAsync_FolderDoesNotBelongToUser_NotReturned(
|
|
SutProvider<FolderRotationValidator> sutProvider, User user, IEnumerable<FolderWithIdRequestModel> folders)
|
|
{
|
|
var userFolders = folders.Select(f => f.ToFolder(new Folder())).ToList();
|
|
userFolders.RemoveAt(0);
|
|
sutProvider.GetDependency<IFolderRepository>().GetManyByUserIdAsync(user.Id).Returns(userFolders);
|
|
|
|
var result = await sutProvider.Sut.ValidateAsync(user, folders);
|
|
|
|
Assert.DoesNotContain(result, c => c.Id == folders.First().Id);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task ValidateAsync_SentFoldersAreEmptyButDatabaseFoldersAreNot_Throws(
|
|
SutProvider<FolderRotationValidator> sutProvider, User user, IEnumerable<FolderWithIdRequestModel> folders)
|
|
{
|
|
var userFolders = folders.Select(f => f.ToFolder(new Folder())).ToList();
|
|
sutProvider.GetDependency<IFolderRepository>().GetManyByUserIdAsync(user.Id).Returns(userFolders);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.ValidateAsync(user, Enumerable.Empty<FolderWithIdRequestModel>()));
|
|
}
|
|
}
|