mirror of
https://github.com/bitwarden/server.git
synced 2024-12-05 14:23:30 +01:00
ca2915494d
* [AC-2068] Allow any member of an org to read all users for that organization with flexible collections * [AC-2068] Allow any member of an org to read all groups for that organization with flexible collections * [AC-2068] Formatting
126 lines
4.2 KiB
C#
126 lines
4.2 KiB
C#
using System.Security.Claims;
|
|
using Bit.Api.Vault.AuthorizationHandlers.Groups;
|
|
using Bit.Core.Context;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Models.Data;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.Vault.AuthorizationHandlers;
|
|
|
|
[SutProviderCustomize]
|
|
public class GroupAuthorizationHandlerTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData(OrganizationUserType.Admin)]
|
|
[BitAutoData(OrganizationUserType.Owner)]
|
|
[BitAutoData(OrganizationUserType.User)]
|
|
[BitAutoData(OrganizationUserType.Custom)]
|
|
public async Task CanReadAllAsync_WhenMemberOfOrg_Success(
|
|
OrganizationUserType userType,
|
|
Guid userId, SutProvider<GroupAuthorizationHandler> sutProvider,
|
|
CurrentContextOrganization organization)
|
|
{
|
|
organization.Type = userType;
|
|
organization.Permissions = new Permissions();
|
|
|
|
var context = new AuthorizationHandlerContext(
|
|
new[] { GroupOperations.ReadAll(organization.Id) },
|
|
new ClaimsPrincipal(),
|
|
null);
|
|
|
|
sutProvider.GetDependency<ICurrentContext>().UserId.Returns(userId);
|
|
sutProvider.GetDependency<ICurrentContext>().GetOrganization(organization.Id).Returns(organization);
|
|
|
|
await sutProvider.Sut.HandleAsync(context);
|
|
|
|
Assert.True(context.HasSucceeded);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task CanReadAllAsync_WithProviderUser_Success(
|
|
Guid userId,
|
|
SutProvider<GroupAuthorizationHandler> sutProvider, CurrentContextOrganization organization)
|
|
{
|
|
organization.Type = OrganizationUserType.User;
|
|
organization.Permissions = new Permissions();
|
|
|
|
var context = new AuthorizationHandlerContext(
|
|
new[] { GroupOperations.ReadAll(organization.Id) },
|
|
new ClaimsPrincipal(),
|
|
null);
|
|
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.UserId
|
|
.Returns(userId);
|
|
sutProvider.GetDependency<ICurrentContext>()
|
|
.ProviderUserForOrgAsync(organization.Id)
|
|
.Returns(true);
|
|
|
|
await sutProvider.Sut.HandleAsync(context);
|
|
|
|
Assert.True(context.HasSucceeded);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task CanReadAllAsync_WhenMissingOrgAccess_NoSuccess(
|
|
Guid userId,
|
|
CurrentContextOrganization organization,
|
|
SutProvider<GroupAuthorizationHandler> sutProvider)
|
|
{
|
|
|
|
var context = new AuthorizationHandlerContext(
|
|
new[] { GroupOperations.ReadAll(organization.Id) },
|
|
new ClaimsPrincipal(),
|
|
null
|
|
);
|
|
|
|
sutProvider.GetDependency<ICurrentContext>().UserId.Returns(userId);
|
|
sutProvider.GetDependency<ICurrentContext>().GetOrganization(Arg.Any<Guid>()).Returns((CurrentContextOrganization)null);
|
|
sutProvider.GetDependency<ICurrentContext>().ProviderUserForOrgAsync(Arg.Any<Guid>()).Returns(false);
|
|
|
|
await sutProvider.Sut.HandleAsync(context);
|
|
Assert.False(context.HasSucceeded);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task HandleRequirementAsync_MissingUserId_Failure(
|
|
Guid organizationId,
|
|
SutProvider<GroupAuthorizationHandler> sutProvider)
|
|
{
|
|
var context = new AuthorizationHandlerContext(
|
|
new[] { GroupOperations.ReadAll(organizationId) },
|
|
new ClaimsPrincipal(),
|
|
null
|
|
);
|
|
|
|
// Simulate missing user id
|
|
sutProvider.GetDependency<ICurrentContext>().UserId.Returns((Guid?)null);
|
|
|
|
await sutProvider.Sut.HandleAsync(context);
|
|
Assert.False(context.HasSucceeded);
|
|
Assert.True(context.HasFailed);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task HandleRequirementAsync_NoSpecifiedOrgId_Failure(
|
|
SutProvider<GroupAuthorizationHandler> sutProvider)
|
|
{
|
|
var context = new AuthorizationHandlerContext(
|
|
new[] { GroupOperations.ReadAll(default) },
|
|
new ClaimsPrincipal(),
|
|
null
|
|
);
|
|
|
|
sutProvider.GetDependency<ICurrentContext>().UserId.Returns(new Guid());
|
|
|
|
await sutProvider.Sut.HandleAsync(context);
|
|
|
|
Assert.False(context.HasSucceeded);
|
|
Assert.True(context.HasFailed);
|
|
}
|
|
}
|