mirror of
https://github.com/bitwarden/server.git
synced 2024-12-11 15:17:44 +01:00
f04c3b8e54
* Remove Group.AccessAll from code * Add shadow property config and migration
127 lines
4.6 KiB
C#
127 lines
4.6 KiB
C#
using Bit.Core.AdminConsole.Entities;
|
|
using Bit.Core.AdminConsole.Enums;
|
|
using Bit.Core.AdminConsole.OrganizationFeatures.Groups.Interfaces;
|
|
using Bit.Core.AdminConsole.Repositories;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Scim.Context;
|
|
using Bit.Scim.Groups;
|
|
using Bit.Scim.Models;
|
|
using Bit.Scim.Utilities;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Bit.Test.Common.Helpers;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Scim.Test.Groups;
|
|
|
|
[SutProviderCustomize]
|
|
public class PutGroupCommandTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PutGroup_Success(SutProvider<PutGroupCommand> sutProvider, Organization organization, Group group, string displayName)
|
|
{
|
|
group.OrganizationId = organization.Id;
|
|
|
|
sutProvider.GetDependency<IGroupRepository>()
|
|
.GetByIdAsync(group.Id)
|
|
.Returns(group);
|
|
|
|
var inputModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaUser }
|
|
};
|
|
|
|
var expectedResult = new Group
|
|
{
|
|
Id = group.Id,
|
|
ExternalId = group.ExternalId,
|
|
Name = displayName,
|
|
OrganizationId = group.OrganizationId
|
|
};
|
|
|
|
var result = await sutProvider.Sut.PutGroupAsync(organization, group.Id, inputModel);
|
|
|
|
AssertHelper.AssertPropertyEqual(expectedResult, result, "CreationDate", "RevisionDate");
|
|
Assert.Equal(displayName, group.Name);
|
|
|
|
await sutProvider.GetDependency<IUpdateGroupCommand>().Received(1).UpdateGroupAsync(group, organization, EventSystemUser.SCIM);
|
|
await sutProvider.GetDependency<IGroupRepository>().DidNotReceiveWithAnyArgs().UpdateUsersAsync(default, default);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PutGroup_ChangeMembers_Success(SutProvider<PutGroupCommand> sutProvider, Organization organization, Group group, string displayName, IEnumerable<Guid> membersUserIds)
|
|
{
|
|
group.OrganizationId = organization.Id;
|
|
|
|
sutProvider.GetDependency<IGroupRepository>()
|
|
.GetByIdAsync(group.Id)
|
|
.Returns(group);
|
|
|
|
sutProvider.GetDependency<IScimContext>()
|
|
.RequestScimProvider
|
|
.Returns(ScimProviderType.Okta);
|
|
|
|
var inputModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
Members = membersUserIds.Select(uid => new ScimGroupRequestModel.GroupMembersModel { Value = uid.ToString() }).ToList(),
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaUser }
|
|
};
|
|
|
|
var expectedResult = new Group
|
|
{
|
|
Id = group.Id,
|
|
ExternalId = group.ExternalId,
|
|
Name = displayName,
|
|
OrganizationId = group.OrganizationId
|
|
};
|
|
|
|
var result = await sutProvider.Sut.PutGroupAsync(organization, group.Id, inputModel);
|
|
|
|
AssertHelper.AssertPropertyEqual(expectedResult, result, "CreationDate", "RevisionDate");
|
|
Assert.Equal(displayName, group.Name);
|
|
|
|
await sutProvider.GetDependency<IUpdateGroupCommand>().Received(1).UpdateGroupAsync(group, organization, EventSystemUser.SCIM);
|
|
await sutProvider.GetDependency<IGroupRepository>().Received(1).UpdateUsersAsync(group.Id, Arg.Is<IEnumerable<Guid>>(arg => arg.All(id => membersUserIds.Contains(id))));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PutGroup_NotFound_Throws(SutProvider<PutGroupCommand> sutProvider, Organization organization, Guid groupId, string displayName)
|
|
{
|
|
var scimGroupRequestModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaUser }
|
|
};
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.PutGroupAsync(organization, groupId, scimGroupRequestModel));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task PutGroup_MismatchingOrganizationId_Throws(SutProvider<PutGroupCommand> sutProvider, Organization organization, Guid groupId, string displayName)
|
|
{
|
|
var scimGroupRequestModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaUser }
|
|
};
|
|
|
|
sutProvider.GetDependency<IGroupRepository>()
|
|
.GetByIdAsync(groupId)
|
|
.Returns(new Group
|
|
{
|
|
Id = groupId,
|
|
OrganizationId = Guid.NewGuid()
|
|
});
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.PutGroupAsync(organization, groupId, scimGroupRequestModel));
|
|
}
|
|
}
|