mirror of
https://github.com/bitwarden/server.git
synced 2024-12-03 14:03:33 +01:00
989603ddd3
## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> See #3425 for part 1 and background. This PR adds emergency access to the rotation. All new code is hidden behind a feature flag. The Accounts controller has also been moved to Auth ownership. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why * **AccountsController.cs:** Moved to Auth ownership. Emergency access validation was added (as well as initializing empty lists to avoid errors). * **EmergencyAccessRotationValidator.cs:** Performs validation on the provided list of new emergency access keys. * **EmergencyAccessRepository.cs:** Adds a method to rotate encryption keys. This is added to a list in the `RotateUserKeyCommand` that the `UserRepository` calls so it doesn't have to know about all the domains. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - If making database changes - make sure you also update Entity Framework queries and/or migrations - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
53 lines
1.8 KiB
C#
53 lines
1.8 KiB
C#
using Bit.Core.Auth.Models.Data;
|
|
using Bit.Core.Auth.UserFeatures.UserKey.Implementations;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Services;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Microsoft.AspNetCore.Identity;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.Auth.UserFeatures.UserKey;
|
|
|
|
[SutProviderCustomize]
|
|
public class RotateUserKeyCommandTests
|
|
{
|
|
[Theory, BitAutoData]
|
|
public async Task RotateUserKeyAsync_Success(SutProvider<RotateUserKeyCommand> sutProvider, User user,
|
|
RotateUserKeyData model)
|
|
{
|
|
sutProvider.GetDependency<IUserService>().CheckPasswordAsync(user, model.MasterPasswordHash)
|
|
.Returns(true);
|
|
|
|
var result = await sutProvider.Sut.RotateUserKeyAsync(user, model);
|
|
|
|
Assert.Equal(IdentityResult.Success, result);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task RotateUserKeyAsync_InvalidMasterPasswordHash_ReturnsFailedIdentityResult(
|
|
SutProvider<RotateUserKeyCommand> sutProvider, User user, RotateUserKeyData model)
|
|
{
|
|
sutProvider.GetDependency<IUserService>().CheckPasswordAsync(user, model.MasterPasswordHash)
|
|
.Returns(false);
|
|
|
|
var result = await sutProvider.Sut.RotateUserKeyAsync(user, model);
|
|
|
|
Assert.False(result.Succeeded);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task RotateUserKeyAsync_LogsOutUser(
|
|
SutProvider<RotateUserKeyCommand> sutProvider, User user, RotateUserKeyData model)
|
|
{
|
|
sutProvider.GetDependency<IUserService>().CheckPasswordAsync(user, model.MasterPasswordHash)
|
|
.Returns(true);
|
|
|
|
await sutProvider.Sut.RotateUserKeyAsync(user, model);
|
|
|
|
await sutProvider.GetDependency<IPushNotificationService>().ReceivedWithAnyArgs()
|
|
.PushLogOutAsync(default, default);
|
|
}
|
|
}
|