mirror of
https://github.com/bitwarden/server.git
synced 2024-11-28 13:15:12 +01:00
0189952e1f
* Add check to verify the vault state for rotation is not obviously desynced (empty) * Add unit test for key rotation guardrail * Move de-synced vault detection to validators * Add tests
58 lines
2.4 KiB
C#
58 lines
2.4 KiB
C#
using Bit.Api.Vault.Models.Request;
|
|
using Bit.Api.Vault.Validators;
|
|
using Bit.Core.Entities;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Vault.Models.Data;
|
|
using Bit.Core.Vault.Repositories;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Api.Test.Vault.Validators;
|
|
|
|
[SutProviderCustomize]
|
|
public class CipherRotationValidatorTests
|
|
{
|
|
[Theory, BitAutoData]
|
|
public async Task ValidateAsync_MissingCipher_Throws(SutProvider<CipherRotationValidator> sutProvider, User user,
|
|
IEnumerable<CipherWithIdRequestModel> ciphers)
|
|
{
|
|
var userCiphers = ciphers.Select(c => new CipherDetails { Id = c.Id.GetValueOrDefault(), Type = c.Type })
|
|
.ToList();
|
|
userCiphers.Add(new CipherDetails { Id = Guid.NewGuid(), Type = Core.Vault.Enums.CipherType.Login });
|
|
sutProvider.GetDependency<ICipherRepository>().GetManyByUserIdAsync(user.Id, Arg.Any<bool>())
|
|
.Returns(userCiphers);
|
|
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.ValidateAsync(user, ciphers));
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task ValidateAsync_CipherDoesNotBelongToUser_NotIncluded(
|
|
SutProvider<CipherRotationValidator> sutProvider, User user, IEnumerable<CipherWithIdRequestModel> ciphers)
|
|
{
|
|
var userCiphers = ciphers.Select(c => new CipherDetails { Id = c.Id.GetValueOrDefault(), Type = c.Type })
|
|
.ToList();
|
|
userCiphers.RemoveAt(0);
|
|
sutProvider.GetDependency<ICipherRepository>().GetManyByUserIdAsync(user.Id, Arg.Any<bool>())
|
|
.Returns(userCiphers);
|
|
|
|
var result = await sutProvider.Sut.ValidateAsync(user, ciphers);
|
|
|
|
Assert.DoesNotContain(result, c => c.Id == ciphers.First().Id);
|
|
}
|
|
|
|
[Theory, BitAutoData]
|
|
public async Task ValidateAsync_SentCiphersAreEmptyButDatabaseCiphersAreNot_Throws(
|
|
SutProvider<CipherRotationValidator> sutProvider, User user, IEnumerable<CipherWithIdRequestModel> ciphers)
|
|
{
|
|
var userCiphers = ciphers.Select(c => new CipherDetails { Id = c.Id.GetValueOrDefault(), Type = c.Type })
|
|
.ToList();
|
|
sutProvider.GetDependency<ICipherRepository>().GetManyByUserIdAsync(user.Id, Arg.Any<bool>())
|
|
.Returns(userCiphers);
|
|
|
|
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.ValidateAsync(user, Enumerable.Empty<CipherWithIdRequestModel>()));
|
|
}
|
|
}
|