mirror of
https://github.com/bitwarden/server.git
synced 2024-12-04 14:13:28 +01:00
f3f81deb98
* PM-11123: Service layer * PM-11123: Service layer for Notification Center * PM-11123: Throw error on unsupported requirement * PM-11123: Missing await * PM-11123: Cleanup * PM-11123: Unit Test coverage * PM-11123: Flipping the authorization logic to be exact match of fail, formatting * PM-11123: Async warning * PM-11123: Using AuthorizeOrThrowAsync, removal of redundant set new id * PM-11123: UT typo * PM-11123: UT fix
152 lines
7.3 KiB
C#
152 lines
7.3 KiB
C#
#nullable enable
|
|
using System.Security.Claims;
|
|
using Bit.Core.Context;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.NotificationCenter.Authorization;
|
|
using Bit.Core.NotificationCenter.Commands;
|
|
using Bit.Core.NotificationCenter.Entities;
|
|
using Bit.Core.NotificationCenter.Repositories;
|
|
using Bit.Core.Test.NotificationCenter.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.NotificationCenter.Commands;
|
|
|
|
[SutProviderCustomize]
|
|
[NotificationCustomize]
|
|
[NotificationStatusCustomize]
|
|
public class MarkNotificationDeletedCommandTest
|
|
{
|
|
private static void Setup(SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid? userId, Notification? notification, NotificationStatus? notificationStatus,
|
|
bool authorizedNotification = false, bool authorizedCreate = false, bool authorizedUpdate = false)
|
|
{
|
|
sutProvider.GetDependency<ICurrentContext>().UserId.Returns(userId);
|
|
sutProvider.GetDependency<INotificationRepository>()
|
|
.GetByIdAsync(notificationId)
|
|
.Returns(notification);
|
|
sutProvider.GetDependency<INotificationStatusRepository>()
|
|
.GetByNotificationIdAndUserIdAsync(notificationId, userId ?? Arg.Any<Guid>())
|
|
.Returns(notificationStatus);
|
|
sutProvider.GetDependency<INotificationStatusRepository>()
|
|
.CreateAsync(Arg.Any<NotificationStatus>());
|
|
sutProvider.GetDependency<INotificationStatusRepository>()
|
|
.UpdateAsync(notificationStatus ?? Arg.Any<NotificationStatus>());
|
|
sutProvider.GetDependency<IAuthorizationService>()
|
|
.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), notification ?? Arg.Any<Notification>(),
|
|
Arg.Is<IEnumerable<IAuthorizationRequirement>>(reqs =>
|
|
reqs.Contains(NotificationOperations.Read)))
|
|
.Returns(authorizedNotification ? AuthorizationResult.Success() : AuthorizationResult.Failed());
|
|
sutProvider.GetDependency<IAuthorizationService>()
|
|
.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), notificationStatus ?? Arg.Any<NotificationStatus>(),
|
|
Arg.Is<IEnumerable<IAuthorizationRequirement>>(reqs =>
|
|
reqs.Contains(NotificationStatusOperations.Create)))
|
|
.Returns(authorizedCreate ? AuthorizationResult.Success() : AuthorizationResult.Failed());
|
|
sutProvider.GetDependency<IAuthorizationService>()
|
|
.AuthorizeAsync(Arg.Any<ClaimsPrincipal>(), notificationStatus ?? Arg.Any<NotificationStatus>(),
|
|
Arg.Is<IEnumerable<IAuthorizationRequirement>>(reqs =>
|
|
reqs.Contains(NotificationStatusOperations.Update)))
|
|
.Returns(authorizedUpdate ? AuthorizationResult.Success() : AuthorizationResult.Failed());
|
|
|
|
sutProvider.GetDependency<INotificationStatusRepository>().ClearReceivedCalls();
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_NotLoggedIn_NotFoundException(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Notification notification, NotificationStatus notificationStatus)
|
|
{
|
|
Setup(sutProvider, notificationId, userId: null, notification, notificationStatus, true, true, true);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => sutProvider.Sut.MarkDeletedAsync(notificationId));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_NotificationNotFound_NotFoundException(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, NotificationStatus notificationStatus)
|
|
{
|
|
Setup(sutProvider, notificationId, userId, notification: null, notificationStatus, true, true, true);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => sutProvider.Sut.MarkDeletedAsync(notificationId));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_ReadRequirementNotificationNotAuthorized_NotFoundException(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, Notification notification, NotificationStatus notificationStatus)
|
|
{
|
|
Setup(sutProvider, notificationId, userId, notification, notificationStatus, authorizedNotification: false,
|
|
true, true);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => sutProvider.Sut.MarkDeletedAsync(notificationId));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_CreateRequirementNotAuthorized_NotFoundException(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, Notification notification)
|
|
{
|
|
Setup(sutProvider, notificationId, userId, notification, notificationStatus: null, true,
|
|
authorizedCreate: false, true);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => sutProvider.Sut.MarkDeletedAsync(notificationId));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_UpdateRequirementNotAuthorized_NotFoundException(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, Notification notification, NotificationStatus notificationStatus)
|
|
{
|
|
Setup(sutProvider, notificationId, userId, notification, notificationStatus, true, true,
|
|
authorizedUpdate: false);
|
|
|
|
await Assert.ThrowsAsync<NotFoundException>(() => sutProvider.Sut.MarkDeletedAsync(notificationId));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_NotificationStatusNotFoundCreateAuthorized_NotificationStatusCreated(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, Notification notification)
|
|
{
|
|
Setup(sutProvider, notificationId, userId, notification, notificationStatus: null, true, true, true);
|
|
|
|
await sutProvider.Sut.MarkDeletedAsync(notificationId);
|
|
|
|
await sutProvider.GetDependency<INotificationStatusRepository>().Received(1)
|
|
.CreateAsync(Arg.Is<NotificationStatus>(ns =>
|
|
ns.NotificationId == notificationId && ns.UserId == userId && !ns.ReadDate.HasValue &&
|
|
ns.DeletedDate.HasValue && DateTime.UtcNow - ns.DeletedDate.Value < TimeSpan.FromMinutes(1)));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task MarkDeletedAsync_NotificationStatusFoundCreateAuthorized_NotificationStatusUpdated(
|
|
SutProvider<MarkNotificationDeletedCommand> sutProvider,
|
|
Guid notificationId, Guid userId, Notification notification, NotificationStatus notificationStatus)
|
|
{
|
|
var deletedDate = notificationStatus.DeletedDate;
|
|
|
|
Setup(sutProvider, notificationId, userId, notification, notificationStatus, true, true, true);
|
|
|
|
await sutProvider.Sut.MarkDeletedAsync(notificationId);
|
|
|
|
await sutProvider.GetDependency<INotificationStatusRepository>().Received(1)
|
|
.UpdateAsync(Arg.Is<NotificationStatus>(ns =>
|
|
ns.Equals(notificationStatus) &&
|
|
ns.NotificationId == notificationStatus.NotificationId && ns.UserId == notificationStatus.UserId &&
|
|
ns.ReadDate == notificationStatus.ReadDate && ns.DeletedDate != deletedDate &&
|
|
ns.DeletedDate.HasValue &&
|
|
DateTime.UtcNow - ns.DeletedDate.Value < TimeSpan.FromMinutes(1)));
|
|
}
|
|
}
|