mirror of
https://github.com/bitwarden/server.git
synced 2024-11-25 12:45:18 +01:00
5ecf7b9440
* [EC-394] Added ScimApplicationFactory to handle tests for Scim controllers * [EC-394] Added Scim.IntegrationTest project with GroupsControllerTests * [EC-394] Fixed getting Guid Id from Operation Path * [EC-394] Added tests for GroupsController Patch action * [EC-394] Moved tests mock data setup to ScimApplicationFactory * [EC-394] Updated IntegrationTestCommon packages.lock.json * [EC-394] Updated ScimApplicationFactory and GroupsControllerTests; Added UsersController Tests * [EC-394] dotnet format * [EC-394] Updated Identity.IntegrationTest packages.lock.json * [EC-394] Updated Scim.IntegrationTest packages.lock.json * [EC-394] dotnet format * [EC-394] Reverted change on getting GUID from GetOperationPathId * [EC-394] Fixed sending userId on Patch_AddSingleMember_Success and Patch_RemoveSingleMember_Success * [EC-394] Updated test to send request with two operations * [EC-394] Removed Scim dependency from IntegrationTestCommon * [EC-394] Reverted changes to packages.lock.json. Ran dotnet format * [EC-394] Updated Scim.IntegrationTest packages.lock.json * [EC-394] Updated GroupsControllerTests and UsersControllerTests to implement IAsyncLifetime to cleanup database before each test * [EC-394] Declared variables for GetList parameters * [EC-394] Updated AssertHelper.AssertPropertyEqual to compare each item in an IEnumerable property * [EC-394] Updated AssertHelper.AssertPropertyEqual to check if type is comparable * [EC-394] Removed unused variable from ScimApplicationFactory * Apply suggestions from code review Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> * [EC-394] Changed test users emails to domain example.com * [EC-394] Restore solution file * [EC-394] Added Scim.IntegrationTest to sln * [EC-394] Updated integration tests to be clearer and check responses in detail * [EC-394] Using NoopMailService to mock sending email invitations in tests * [EC-394] Removed multiple references to the same variable ScimApplicationFactory.TestOrganizationId1 * [EC-394] Updated const variable names * [EC-394] Using AssertPropertyEqualPredicate for IEnumerable properties Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
602 lines
26 KiB
C#
602 lines
26 KiB
C#
using System.Text.Json;
|
|
using Bit.Scim.IntegrationTest.Factories;
|
|
using Bit.Scim.Models;
|
|
using Bit.Scim.Utilities;
|
|
using Bit.Test.Common.Helpers;
|
|
using Xunit;
|
|
|
|
namespace Bit.Scim.IntegrationTest.Controllers.v2;
|
|
|
|
public class GroupsControllerTests : IClassFixture<ScimApplicationFactory>, IAsyncLifetime
|
|
{
|
|
private const int _initialGroupCount = 3;
|
|
private const int _initialGroupUsersCount = 2;
|
|
|
|
private readonly ScimApplicationFactory _factory;
|
|
|
|
public GroupsControllerTests(ScimApplicationFactory factory)
|
|
{
|
|
_factory = factory;
|
|
_factory.DatabaseName = "test_database_groups";
|
|
}
|
|
|
|
public Task InitializeAsync()
|
|
{
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
_factory.ReinitializeDbForTests(databaseContext);
|
|
return Task.CompletedTask;
|
|
}
|
|
|
|
Task IAsyncLifetime.DisposeAsync() => Task.CompletedTask;
|
|
|
|
[Fact]
|
|
public async Task Get_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var expectedResponse = new ScimGroupResponseModel
|
|
{
|
|
Id = groupId,
|
|
DisplayName = "Test Group 1",
|
|
ExternalId = "A",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsGetAsync(organizationId, groupId);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimGroupResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Get_NotFound()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = Guid.NewGuid().ToString();
|
|
var expectedResponse = new ScimErrorResponseModel
|
|
{
|
|
Status = StatusCodes.Status404NotFound,
|
|
Detail = "Group not found.",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaError }
|
|
};
|
|
|
|
var context = await _factory.GroupsGetAsync(organizationId, groupId);
|
|
|
|
Assert.Equal(StatusCodes.Status404NotFound, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimErrorResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetList_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
string filter = null;
|
|
int? itemsPerPage = 2;
|
|
int? startIndex = 1;
|
|
var expectedResponse = new ScimListResponseModel<ScimGroupResponseModel>
|
|
{
|
|
ItemsPerPage = itemsPerPage.Value,
|
|
TotalResults = 3,
|
|
StartIndex = startIndex.Value,
|
|
Resources = new List<ScimGroupResponseModel>
|
|
{
|
|
new ScimGroupResponseModel
|
|
{
|
|
Id = ScimApplicationFactory.TestGroupId1,
|
|
DisplayName = "Test Group 1",
|
|
ExternalId = "A",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
},
|
|
new ScimGroupResponseModel
|
|
{
|
|
Id = ScimApplicationFactory.TestGroupId2,
|
|
DisplayName = "Test Group 2",
|
|
ExternalId = "B",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
}
|
|
},
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaListResponse }
|
|
};
|
|
|
|
var context = await _factory.GroupsGetListAsync(organizationId, filter, itemsPerPage, startIndex);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimListResponseModel<ScimGroupResponseModel>>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetList_SearchDisplayName_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
string filter = "displayName eq Test Group 2";
|
|
int? itemsPerPage = 10;
|
|
int? startIndex = 1;
|
|
var expectedResponse = new ScimListResponseModel<ScimGroupResponseModel>
|
|
{
|
|
ItemsPerPage = itemsPerPage.Value,
|
|
TotalResults = 1,
|
|
StartIndex = startIndex.Value,
|
|
Resources = new List<ScimGroupResponseModel>
|
|
{
|
|
new ScimGroupResponseModel
|
|
{
|
|
Id = ScimApplicationFactory.TestGroupId2,
|
|
DisplayName = "Test Group 2",
|
|
ExternalId = "B",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
}
|
|
},
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaListResponse }
|
|
};
|
|
|
|
var context = await _factory.GroupsGetListAsync(organizationId, filter, itemsPerPage, startIndex);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimListResponseModel<ScimGroupResponseModel>>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetList_SearchExternalId_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
string filter = "externalId eq C";
|
|
int? itemsPerPage = 10;
|
|
int? startIndex = 1;
|
|
var expectedResponse = new ScimListResponseModel<ScimGroupResponseModel>
|
|
{
|
|
ItemsPerPage = itemsPerPage.Value,
|
|
TotalResults = 1,
|
|
StartIndex = startIndex.Value,
|
|
Resources = new List<ScimGroupResponseModel>
|
|
{
|
|
new ScimGroupResponseModel
|
|
{
|
|
Id = ScimApplicationFactory.TestGroupId3,
|
|
DisplayName = "Test Group 3",
|
|
ExternalId = "C",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
}
|
|
},
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaListResponse }
|
|
};
|
|
|
|
|
|
var context = await _factory.GroupsGetListAsync(organizationId, filter, itemsPerPage, startIndex);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimListResponseModel<ScimGroupResponseModel>>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task GetList_EmptyResult_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
string filter = "externalId eq Z";
|
|
int? itemsPerPage = 10;
|
|
int? startIndex = 1;
|
|
var expectedResponse = new ScimListResponseModel<ScimGroupResponseModel>
|
|
{
|
|
ItemsPerPage = itemsPerPage.Value,
|
|
TotalResults = 0,
|
|
StartIndex = startIndex.Value,
|
|
Resources = new List<ScimGroupResponseModel>(),
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaListResponse }
|
|
};
|
|
|
|
|
|
var context = await _factory.GroupsGetListAsync(organizationId, filter, itemsPerPage, startIndex);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimListResponseModel<ScimGroupResponseModel>>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Post_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var displayName = "New Group";
|
|
var externalId = Guid.NewGuid().ToString();
|
|
var inputModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
ExternalId = externalId.ToString(),
|
|
Members = new List<ScimGroupRequestModel.GroupMembersModel>
|
|
{
|
|
new ScimGroupRequestModel.GroupMembersModel { Display = "user1@example.com", Value = ScimApplicationFactory.TestOrganizationUserId1 }
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
var expectedResponse = new ScimGroupResponseModel
|
|
{
|
|
DisplayName = displayName,
|
|
ExternalId = externalId,
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPostAsync(organizationId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status201Created, context.Response.StatusCode);
|
|
|
|
// Verifying that the response includes a header with the URL of the created Group
|
|
Assert.Contains(context.Response.Headers, h => h.Key == "Location");
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimGroupResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel, "Id");
|
|
Assert.NotNull(responseModel.Id);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Equal(_initialGroupCount + 1, databaseContext.Groups.Count());
|
|
Assert.True(databaseContext.Groups.Any(g => g.Name == displayName && g.ExternalId == externalId));
|
|
|
|
Assert.Equal(_initialGroupUsersCount + 1, databaseContext.GroupUsers.Count());
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == responseModel.Id && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId1));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
[InlineData(" ")]
|
|
public async Task Post_InvalidDisplayName_BadRequest(string displayName)
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var model = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = displayName,
|
|
ExternalId = null,
|
|
Members = null,
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPostAsync(organizationId, model);
|
|
|
|
Assert.Equal(StatusCodes.Status400BadRequest, context.Response.StatusCode);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Post_ExistingExternalId_Conflict()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var model = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = "New Group",
|
|
ExternalId = "A",
|
|
Members = null,
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPostAsync(organizationId, model);
|
|
|
|
Assert.Equal(StatusCodes.Status409Conflict, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Equal(_initialGroupCount, databaseContext.Groups.Count());
|
|
Assert.False(databaseContext.Groups.Any(g => g.Name == "New Group"));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Put_ChangeNameAndMembers_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var newGroupName = Guid.NewGuid().ToString();
|
|
var inputModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = newGroupName,
|
|
ExternalId = "A",
|
|
Members = new List<ScimGroupRequestModel.GroupMembersModel>
|
|
{
|
|
new ScimGroupRequestModel.GroupMembersModel { Display = "user2@example.com", Value = ScimApplicationFactory.TestOrganizationUserId2 },
|
|
new ScimGroupRequestModel.GroupMembersModel { Display = "user3@example.com", Value = ScimApplicationFactory.TestOrganizationUserId3 }
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
var expectedResponse = new ScimGroupResponseModel
|
|
{
|
|
Id = groupId,
|
|
DisplayName = newGroupName,
|
|
ExternalId = "A",
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPutAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status200OK, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimGroupResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
var firstGroup = databaseContext.Groups.FirstOrDefault(g => g.Id.ToString() == groupId);
|
|
Assert.Equal(newGroupName, firstGroup.Name);
|
|
|
|
Assert.Equal(2, databaseContext.GroupUsers.Count(gu => gu.GroupId.ToString() == groupId));
|
|
Assert.NotNull(databaseContext.GroupUsers.FirstOrDefault(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId2));
|
|
Assert.NotNull(databaseContext.GroupUsers.FirstOrDefault(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId3));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Put_NotFound()
|
|
{
|
|
var newGroupName = "Test Group 1 New Name";
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = Guid.NewGuid().ToString();
|
|
var inputModel = new ScimGroupRequestModel
|
|
{
|
|
DisplayName = newGroupName,
|
|
ExternalId = "A",
|
|
Members = new List<ScimGroupRequestModel.GroupMembersModel>(),
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
var expectedResponse = new ScimErrorResponseModel
|
|
{
|
|
Status = StatusCodes.Status404NotFound,
|
|
Detail = "Group not found.",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaError }
|
|
};
|
|
|
|
var context = await _factory.GroupsPutAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status404NotFound, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimErrorResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_ReplaceDisplayName_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var newDisplayName = "Patch Display Name";
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "replace",
|
|
Value = JsonDocument.Parse($"{{\"displayName\":\"{newDisplayName}\"}}").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
var group = databaseContext.Groups.FirstOrDefault(g => g.Id.ToString() == groupId);
|
|
Assert.Equal(newDisplayName, group.Name);
|
|
|
|
Assert.Equal(_initialGroupUsersCount, databaseContext.GroupUsers.Count());
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId1));
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId4));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_ReplaceMembers_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "replace",
|
|
Path = "members",
|
|
Value = JsonDocument.Parse($"[{{\"value\":\"{ScimApplicationFactory.TestOrganizationUserId2}\"}}]").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Single(databaseContext.GroupUsers);
|
|
|
|
Assert.Equal(_initialGroupUsersCount - 1, databaseContext.GroupUsers.Count());
|
|
var groupUser = databaseContext.GroupUsers.FirstOrDefault();
|
|
Assert.Equal(ScimApplicationFactory.TestOrganizationUserId2, groupUser.OrganizationUserId.ToString());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_AddSingleMember_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "add",
|
|
Path = $"members[value eq \"{ScimApplicationFactory.TestOrganizationUserId2}\"]",
|
|
Value = JsonDocument.Parse("{}").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Equal(_initialGroupUsersCount + 1, databaseContext.GroupUsers.Count());
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId1));
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId2));
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId4));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_AddListMembers_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId2;
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "add",
|
|
Path = "members",
|
|
Value = JsonDocument.Parse($"[{{\"value\":\"{ScimApplicationFactory.TestOrganizationUserId2}\"}},{{\"value\":\"{ScimApplicationFactory.TestOrganizationUserId3}\"}}]").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId2));
|
|
Assert.True(databaseContext.GroupUsers.Any(gu => gu.GroupId.ToString() == groupId && gu.OrganizationUserId.ToString() == ScimApplicationFactory.TestOrganizationUserId3));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_RemoveSingleMember_ReplaceDisplayName_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var newDisplayName = "Patch Display Name";
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "remove",
|
|
Path = $"members[value eq \"{ScimApplicationFactory.TestOrganizationUserId1}\"]",
|
|
Value = JsonDocument.Parse("{}").RootElement
|
|
},
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "replace",
|
|
Value = JsonDocument.Parse($"{{\"displayName\":\"{newDisplayName}\"}}").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Equal(_initialGroupUsersCount - 1, databaseContext.GroupUsers.Count());
|
|
Assert.Equal(_initialGroupCount, databaseContext.Groups.Count());
|
|
|
|
var group = databaseContext.Groups.FirstOrDefault(g => g.Id.ToString() == groupId);
|
|
Assert.Equal(newDisplayName, group.Name);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_RemoveListMembers_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId1;
|
|
var inputModel = new ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>()
|
|
{
|
|
new ScimPatchModel.OperationModel
|
|
{
|
|
Op = "remove",
|
|
Path = "members",
|
|
Value = JsonDocument.Parse($"[{{\"value\":\"{ScimApplicationFactory.TestOrganizationUserId1}\"}}, {{\"value\":\"{ScimApplicationFactory.TestOrganizationUserId4}\"}}]").RootElement
|
|
}
|
|
},
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Empty(databaseContext.GroupUsers);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Patch_NotFound()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = Guid.NewGuid().ToString();
|
|
var inputModel = new Models.ScimPatchModel
|
|
{
|
|
Operations = new List<ScimPatchModel.OperationModel>(),
|
|
Schemas = new List<string>() { ScimConstants.Scim2SchemaGroup }
|
|
};
|
|
var expectedResponse = new ScimErrorResponseModel
|
|
{
|
|
Status = StatusCodes.Status404NotFound,
|
|
Detail = "Group not found.",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaError }
|
|
};
|
|
|
|
var context = await _factory.GroupsPatchAsync(organizationId, groupId, inputModel);
|
|
|
|
Assert.Equal(StatusCodes.Status404NotFound, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimErrorResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Delete_Success()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = ScimApplicationFactory.TestGroupId3;
|
|
|
|
var context = await _factory.GroupsDeleteAsync(organizationId, groupId);
|
|
|
|
Assert.Equal(StatusCodes.Status204NoContent, context.Response.StatusCode);
|
|
|
|
var databaseContext = _factory.GetDatabaseContext();
|
|
Assert.Equal(_initialGroupCount - 1, databaseContext.Groups.Count());
|
|
Assert.True(databaseContext.Groups.FirstOrDefault(g => g.Id.ToString() == groupId) == null);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Delete_NotFound()
|
|
{
|
|
var organizationId = ScimApplicationFactory.TestOrganizationId1;
|
|
var groupId = Guid.NewGuid().ToString();
|
|
var expectedResponse = new ScimErrorResponseModel
|
|
{
|
|
Status = StatusCodes.Status404NotFound,
|
|
Detail = "Group not found.",
|
|
Schemas = new List<string> { ScimConstants.Scim2SchemaError }
|
|
};
|
|
|
|
var context = await _factory.GroupsDeleteAsync(organizationId, groupId);
|
|
|
|
Assert.Equal(StatusCodes.Status404NotFound, context.Response.StatusCode);
|
|
|
|
var responseModel = JsonSerializer.Deserialize<ScimErrorResponseModel>(context.Response.Body, new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
|
|
AssertHelper.AssertPropertyEqual(expectedResponse, responseModel);
|
|
}
|
|
}
|