mirror of
https://github.com/bitwarden/server.git
synced 2024-12-12 15:26:48 +01:00
5537470703
* Get limited life attachment download URL This change limits url download to a 1min lifetime. This requires moving to a new container to allow for non-public blob access. Clients will have to call GetAttachmentData api function to receive the download URL. For backwards compatibility, attachment URLs are still present, but will not work for attachments stored in non-public access blobs. * Make GlobalSettings interface for testing * Test LocalAttachmentStorageService equivalence * Remove comment * Add missing globalSettings using * Simplify default attachment container * Default to attachments containe for existing methods A new upload method will be made for uploading to attachments-v2. For compatibility for clients which don't use these new methods, we need to still use the old container. The new container will be used only for new uploads * Remove Default MetaData fixture. * Keep attachments container blob-level security for all instances * Close unclosed FileStream * Favor default value for noop services
93 lines
2.8 KiB
C#
93 lines
2.8 KiB
C#
using System.Collections.Generic;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Settings;
|
|
using Bit.Core.Utilities;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.AspNetCore.Mvc.Abstractions;
|
|
using Microsoft.AspNetCore.Mvc.Filters;
|
|
using Microsoft.AspNetCore.Routing;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.Utilities
|
|
{
|
|
public class SelfHostedAttributeTests
|
|
{
|
|
[Fact]
|
|
public void NotSelfHosted_Throws_When_SelfHosted()
|
|
{
|
|
// Arrange
|
|
var sha = new SelfHostedAttribute { NotSelfHostedOnly = true };
|
|
|
|
// Act & Assert
|
|
Assert.Throws<BadRequestException>(() => sha.OnActionExecuting(GetContext(selfHosted: true)));
|
|
}
|
|
|
|
[Fact]
|
|
public void NotSelfHosted_Success_When_NotSelfHosted()
|
|
{
|
|
// Arrange
|
|
var sha = new SelfHostedAttribute { NotSelfHostedOnly = true };
|
|
|
|
// Act
|
|
sha.OnActionExecuting(GetContext(selfHosted: false));
|
|
|
|
// Assert
|
|
// The Assert here is just NOT throwing an exception
|
|
}
|
|
|
|
|
|
[Fact]
|
|
public void SelfHosted_Success_When_SelfHosted()
|
|
{
|
|
// Arrange
|
|
var sha = new SelfHostedAttribute { SelfHostedOnly = true };
|
|
|
|
// Act
|
|
sha.OnActionExecuting(GetContext(selfHosted: true));
|
|
|
|
// Assert
|
|
// The Assert here is just NOT throwing an exception
|
|
}
|
|
|
|
[Fact]
|
|
public void SelfHosted_Throws_When_NotSelfHosted()
|
|
{
|
|
// Arrange
|
|
var sha = new SelfHostedAttribute { SelfHostedOnly = true };
|
|
|
|
// Act & Assert
|
|
Assert.Throws<BadRequestException>(() => sha.OnActionExecuting(GetContext(selfHosted: false)));
|
|
}
|
|
|
|
|
|
// This generates a ActionExecutingContext with the needed injected
|
|
// service with the given value.
|
|
private ActionExecutingContext GetContext(bool selfHosted)
|
|
{
|
|
IServiceCollection services = new ServiceCollection();
|
|
|
|
var globalSettings = new GlobalSettings
|
|
{
|
|
SelfHosted = selfHosted
|
|
};
|
|
|
|
services.AddSingleton(globalSettings);
|
|
|
|
var httpContext = new DefaultHttpContext();
|
|
httpContext.RequestServices = services.BuildServiceProvider();
|
|
|
|
var context = Substitute.For<ActionExecutingContext>(
|
|
Substitute.For<ActionContext>(httpContext,
|
|
new RouteData(),
|
|
Substitute.For<ActionDescriptor>()),
|
|
new List<IFilterMetadata>(),
|
|
new Dictionary<string, object>(),
|
|
Substitute.For<Controller>());
|
|
|
|
return context;
|
|
}
|
|
}
|
|
} |