mirror of
https://github.com/bitwarden/server.git
synced 2024-12-01 13:43:23 +01:00
8177821e8b
* refactor the plan and create new objects * initial commit * Add new plan types * continue the refactoring by adding new plantypes * changes for plans * Refactoring continues * making changes for plan * Fixing the failing test * Fixing whitespace * Fix some in correct values * Resolve the plan data * rearranging the plan * Make the plan more immutable * Resolve the lint errors * Fix the failing test * Add custom plan * Fix the failing test * Fix the failing test * resolve the failing addons after refactoring * Refactoring * Merge branch 'master' into ac-1451/refactor-staticstore-plans-and-consuming-logic * merge from master * Merge branch 'master' into ac-1451/refactor-staticstore-plans-and-consuming-logic * format whitespace * resolve the conflict * Fix some pr comments * Fixing some of the pr comments * fixing some of the pr comments * Resolve some pr comments * Resolve pr comments * Resolves some pr comments * Resolving some or comments * Resolve a failing test * fix the failing test * Resolving some pr comments * Fix the failing test * resolve pr comment * add a using statement fir a failing test --------- Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
162 lines
6.8 KiB
C#
162 lines
6.8 KiB
C#
using Bit.Core.Entities;
|
|
using Bit.Core.Entities.Provider;
|
|
using Bit.Core.Enums;
|
|
using Bit.Core.Enums.Provider;
|
|
using Bit.Core.Exceptions;
|
|
using Bit.Core.Models.Business;
|
|
using Bit.Core.Models.StaticStore;
|
|
using Bit.Core.OrganizationFeatures.OrganizationSubscriptions;
|
|
using Bit.Core.Repositories;
|
|
using Bit.Core.Services;
|
|
using Bit.Core.Utilities;
|
|
using Bit.Test.Common.AutoFixture;
|
|
using Bit.Test.Common.AutoFixture.Attributes;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.OrganizationFeatures.OrganizationSubscriptionUpdate;
|
|
[SutProviderCustomize]
|
|
public class AddSecretsManagerSubscriptionCommandTests
|
|
{
|
|
[Theory]
|
|
[BitAutoData(PlanType.TeamsAnnually)]
|
|
[BitAutoData(PlanType.TeamsMonthly)]
|
|
[BitAutoData(PlanType.EnterpriseAnnually)]
|
|
[BitAutoData(PlanType.EnterpriseMonthly)]
|
|
public async Task SignUpAsync_ReturnsSuccessAndClientSecret_WhenOrganizationAndPlanExist(PlanType planType,
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
int additionalServiceAccounts,
|
|
int additionalSmSeats,
|
|
Organization organization,
|
|
bool useSecretsManager)
|
|
{
|
|
organization.PlanType = planType;
|
|
|
|
var plan = StaticStore.Plans.FirstOrDefault(p => p.Type == organization.PlanType);
|
|
|
|
await sutProvider.Sut.SignUpAsync(organization, additionalSmSeats, additionalServiceAccounts);
|
|
|
|
sutProvider.GetDependency<IOrganizationService>().Received(1)
|
|
.ValidateSecretsManagerPlan(plan, Arg.Is<OrganizationUpgrade>(c =>
|
|
c.UseSecretsManager == useSecretsManager &&
|
|
c.AdditionalSmSeats == additionalSmSeats &&
|
|
c.AdditionalServiceAccounts == additionalServiceAccounts &&
|
|
c.AdditionalSeats == organization.Seats.GetValueOrDefault()));
|
|
|
|
await sutProvider.GetDependency<IPaymentService>().Received()
|
|
.AddSecretsManagerToSubscription(organization, plan, additionalSmSeats, additionalServiceAccounts);
|
|
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
|
|
sutProvider.GetDependency<IOrganizationService>().Received(1).ReplaceAndUpdateCacheAsync(Arg.Is<Organization>(c =>
|
|
c.SmSeats == plan.SecretsManager.BaseSeats + additionalSmSeats &&
|
|
c.SmServiceAccounts == plan.SecretsManager.BaseServiceAccount + additionalServiceAccounts &&
|
|
c.UseSecretsManager == true));
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsNotFoundException_WhenOrganizationIsNull(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
int additionalServiceAccounts,
|
|
int additionalSmSeats)
|
|
{
|
|
await Assert.ThrowsAsync<NotFoundException>(() =>
|
|
sutProvider.Sut.SignUpAsync(null, additionalSmSeats, additionalServiceAccounts));
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsGatewayException_WhenGatewayCustomerIdIsNullOrWhitespace(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
Organization organization,
|
|
int additionalServiceAccounts,
|
|
int additionalSmSeats)
|
|
{
|
|
organization.GatewayCustomerId = null;
|
|
organization.PlanType = PlanType.EnterpriseAnnually;
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() =>
|
|
sutProvider.Sut.SignUpAsync(organization, additionalSmSeats, additionalServiceAccounts));
|
|
Assert.Contains("No payment method found.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsGatewayException_WhenGatewaySubscriptionIdIsNullOrWhitespace(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
Organization organization,
|
|
int additionalServiceAccounts,
|
|
int additionalSmSeats)
|
|
{
|
|
organization.GatewaySubscriptionId = null;
|
|
organization.PlanType = PlanType.EnterpriseAnnually;
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(() =>
|
|
sutProvider.Sut.SignUpAsync(organization, additionalSmSeats, additionalServiceAccounts));
|
|
Assert.Contains("No subscription found.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsException_WhenOrganizationEnrolledInSmBeta(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
Organization organization)
|
|
{
|
|
organization.UseSecretsManager = true;
|
|
organization.SecretsManagerBeta = true;
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.SignUpAsync(organization, 10, 10));
|
|
|
|
Assert.Contains("Organization is enrolled in Secrets Manager Beta", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsException_WhenOrganizationAlreadyHasSecretsManager(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
Organization organization)
|
|
{
|
|
organization.UseSecretsManager = true;
|
|
organization.SecretsManagerBeta = false;
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.SignUpAsync(organization, 10, 10));
|
|
|
|
Assert.Contains("Organization already uses Secrets Manager", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
[Theory]
|
|
[BitAutoData]
|
|
public async Task SignUpAsync_ThrowsException_WhenOrganizationIsManagedByMSP(
|
|
SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider,
|
|
Organization organization,
|
|
Provider provider)
|
|
{
|
|
organization.UseSecretsManager = false;
|
|
organization.SecretsManagerBeta = false;
|
|
provider.Type = ProviderType.Msp;
|
|
sutProvider.GetDependency<IProviderRepository>().GetByOrganizationIdAsync(organization.Id).Returns(provider);
|
|
|
|
var exception = await Assert.ThrowsAsync<BadRequestException>(
|
|
() => sutProvider.Sut.SignUpAsync(organization, 10, 10));
|
|
|
|
Assert.Contains("Organizations with a Managed Service Provider do not support Secrets Manager.", exception.Message);
|
|
await VerifyDependencyNotCalledAsync(sutProvider);
|
|
}
|
|
|
|
private static async Task VerifyDependencyNotCalledAsync(SutProvider<AddSecretsManagerSubscriptionCommand> sutProvider)
|
|
{
|
|
await sutProvider.GetDependency<IPaymentService>().DidNotReceive()
|
|
.AddSecretsManagerToSubscription(Arg.Any<Organization>(), Arg.Any<Plan>(), Arg.Any<int>(), Arg.Any<int>());
|
|
|
|
// TODO: call ReferenceEventService - see AC-1481
|
|
|
|
await sutProvider.GetDependency<IOrganizationService>().DidNotReceive().ReplaceAndUpdateCacheAsync(Arg.Any<Organization>());
|
|
}
|
|
}
|