Upstream/dynmap
1
0
Fork 0
mirror of https://github.com/webbukkit/dynmap.git synced 2024-11-27 12:45:59 +01:00
Code Issues Projects Releases Wiki Activity

fix: explicitly set sign lines

Browse Source 
Minecraft allows for plugins to retrieve the text of a newly created or
modified sign through the `SignChangeEvent.getLines()` method. In
vanilla, the lines returned can be mutated, however a
`SignChangeEvent.setLine(idx, text)` method exists.

PaperMC has internally switched most user-facing text to using the
Adventure Text components, to better support text styling and optimize
serializations. For backwards compatibility with most plugins, PaperMC
retains deprecated `getLines` and `setLine` methods by providing a
legacy serialization view of the Aventure components, however mutations
of the returned list are ignored.

This changeset calls `setLine` after all event listeners ran, allowing
PaperMC to preserve the sign mutations.
This commit is contained in:
Terin Stock 2021-08-26 23:15:51 -07:00
parent fc3fc5e18c
commit 2e382ae160
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spigot/src/main/java/org/dynmap/bukkit/DynmapPlugin.java
View File

@ -398,6 +398,10 @@ public class DynmapPlugin extends JavaPlugin implements DynmapAPI {
if(p != null) dp = new BukkitPlayer(p); if(p != null) dp = new BukkitPlayer(p);
core.listenerManager.processSignChangeEvent(EventType.SIGN_CHANGE, b.getType().name(), core.listenerManager.processSignChangeEvent(EventType.SIGN_CHANGE, b.getType().name(),
getWorld(l.getWorld()).getName(), l.getBlockX(), l.getBlockY(), l.getBlockZ(), lines, dp); getWorld(l.getWorld()).getName(), l.getBlockX(), l.getBlockY(), l.getBlockZ(), lines, dp);
for (int i = 0; i < 4; i++) {
evt.setLine(i, lines[i]);
}
} }
}, DynmapPlugin.this); }, DynmapPlugin.this);
break; break;