Upstream/dynmap
1
0
Fork 0
mirror of https://github.com/webbukkit/dynmap.git synced 2024-11-24 03:05:28 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #3915 from JurgenKuyper/JarInJarFix

Browse Source 
implemented catch to prevent server crash when jar in jar methods are used
This commit is contained in:
mikeprimm 2023-01-25 09:10:56 -06:00 committed by GitHub
commit 322c370bbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 68 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
forge-1.18.2/src/main/java/org/dynmap/forge_1_18_2/DynmapPlugin.java
View File

@ -1025,9 +1025,22 @@ public class DynmapPlugin
public File getModContainerFile(String name) { public File getModContainerFile(String name) {
ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup
if (mfi != null) { if (mfi != null) {
try {
File f = mfi.getFile().getFilePath().toFile(); File f = mfi.getFile().getFilePath().toFile();
return f; return f;
} }
catch (UnsupportedOperationException ex) {
//TODO Implement proper jar in jar method for fetching data
/*
Log.info("Searching for: " + name);
for (IModInfo e: ModList.get().getMods()) {
Log.info("in: " + e.getModId().toString());
Log.info("resource: "+ ModList.get().getModFileById(e.getModId()).getFile().findResource(String.valueOf(mfi.getFile().getFilePath()))); //requires forge 1.18.2-40.1.60+ (update build.gradle)
}
*/
Log.warning("jar in jar method found, skipping: " + ex.getMessage());
}
}
return null; return null;
} }
@Override @Override

13
forge-1.19.2/src/main/java/org/dynmap/forge_1_19_2/DynmapPlugin.java
View File

@ -1025,9 +1025,22 @@ public class DynmapPlugin
public File getModContainerFile(String name) { public File getModContainerFile(String name) {
ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup
if (mfi != null) { if (mfi != null) {
try {
File f = mfi.getFile().getFilePath().toFile(); File f = mfi.getFile().getFilePath().toFile();
return f; return f;
} }
catch (UnsupportedOperationException ex) {
//TODO Implement proper jar in jar method for fetching data
/*
Log.info("Searching for: " + name);
for (IModInfo e: ModList.get().getMods()) {
Log.info("in: " + e.getModId().toString());
Log.info("resource: "+ ModList.get().getModFileById(e.getModId()).getFile().findResource(String.valueOf(mfi.getFile().getFilePath())));
}
*/
Log.warning("jar in jar method found, skipping: " + ex.getMessage());
}
}
return null; return null;
} }
@Override @Override

13
forge-1.19.3/src/main/java/org/dynmap/forge_1_19_2/DynmapPlugin.java
View File

@ -1027,9 +1027,22 @@ public class DynmapPlugin
public File getModContainerFile(String name) { public File getModContainerFile(String name) {
ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup
if (mfi != null) { if (mfi != null) {
try {
File f = mfi.getFile().getFilePath().toFile(); File f = mfi.getFile().getFilePath().toFile();
return f; return f;
} }
catch (UnsupportedOperationException ex) {
//TODO Implement proper jar in jar method for fetching data
/*
Log.info("Searching for: " + name);
for (IModInfo e: ModList.get().getMods()) {
Log.info("in: " + e.getModId().toString());
Log.info("resource: "+ ModList.get().getModFileById(e.getModId()).getFile().findResource(String.valueOf(mfi.getFile().getFilePath())));
}
*/
Log.warning("jar in jar method found, skipping: " + ex.getMessage());
}
}
return null; return null;
} }
@Override @Override

13
forge-1.19/src/main/java/org/dynmap/forge_1_19/DynmapPlugin.java
View File

@ -1025,9 +1025,22 @@ public class DynmapPlugin
public File getModContainerFile(String name) { public File getModContainerFile(String name) {
ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup ModFileInfo mfi = LoadingModList.get().getModFileById(name); // Try case sensitive lookup
if (mfi != null) { if (mfi != null) {
try {
File f = mfi.getFile().getFilePath().toFile(); File f = mfi.getFile().getFilePath().toFile();
return f; return f;
} }
catch (UnsupportedOperationException ex) {
//TODO Implement proper jar in jar method for fetching data
/*
Log.info("Searching for: " + name);
for (IModInfo e: ModList.get().getMods()) {
Log.info("in: " + e.getModId().toString());
Log.info("resource: "+ ModList.get().getModFileById(e.getModId()).getFile().findResource(String.valueOf(mfi.getFile().getFilePath())));
}
*/
Log.warning("jar in jar method found, skipping: " + ex.getMessage());
}
}
return null; return null;
} }
@Override @Override