Upstream/esphome-docs
1
0
Fork 0
mirror of https://github.com/esphome/esphome-docs.git synced 2024-06-28 10:55:09 +02:00
Code Issues Projects Releases Wiki Activity

Merge branch 'current' into next

Browse Source
This commit is contained in:
Jesse Hills 2023-12-20 20:59:40 +09:00
commit 4dcc5cbe0e
No known key found for this signature in database
GPG Key ID: BEAAE804EFD8E83A
3 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
_static/custom.css
View File

@ -256,7 +256,7 @@ div.body p, div.body dd, div.body li, div.body blockquote {
background: #212121;
color: #ececec;
}
}
body, div.body {
@ -281,7 +281,7 @@ div.body p, div.body dd, div.body li, div.body blockquote {
color: #ececec;
background-color: #212121;
}
a, a.reference, a:visited {
color: #00bfff;
border-bottom: 1px dotted #00bfff;
@ -326,7 +326,7 @@ div.body p, div.body dd, div.body li, div.body blockquote {
color: #e2e2e2;
}
div.note, div.tip {
div.note, div.tip, div.important {
background-color: #2d2c2c;
border: 1px solid #808080;
}
@ -339,4 +339,4 @@ div.body p, div.body dd, div.body li, div.body blockquote {
background-color: #8e8129;
}
}
}

21
guides/contributing.rst
View File

@ -695,6 +695,27 @@ Standard for the esphome-core codebase:
docker run --rm -v "$($current_dir):/esphome" -it ghcr.io/esphome/esphome-lint script/quicklint
PRs are being drafted when changes are needed
---------------------------------------------
If there have been changes requested to your PR, our bot will automatically mark your PR as a draft.
This means that the PR is not ready to be merged or further reviewed for the moment.
Draft PRs tell other reviewers that look at the list of all PRs that this PR is currently in progress and doesn't require their attention yet.
Once you have made the requested changes, you can mark the PR as ready for review again by clicking the "Ready for review button":
.. figure:: images/pr-draft-ready.png
:align: center
:width: 100.0%
:alt: The ready for review button in the bottom of a PR in draft mode
Before you click the "Ready for review" button, ensure you have addressed all requested changes,
there are no merge conflicts, and that all our CI jobs and checks are passing successfully.
Once you've clicked the "Ready for review" button, the PR will return to a normal state again,
and our bot will automatically notify the reviewers who requested the changes that the PR is ready to go!
See Also

BIN
guides/images/pr-draft-ready.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 62 KiB