Upstream/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-29 12:55:46 +01:00
Code Issues Projects Releases Wiki Activity

Float output: Fix min_power and max_power adjusting when output is inverted (#1250)

Browse Source 
This patch fixes faulty behaviour when both, invert and min_power/max_power
are set for a float output (e.g. PWM). The current code scales the output
level to the range [min_power, max_power] and subsequently inverts the value.
This leads to values that are outside the range [min_power, max_power].

This patch fixes the problem by inverting the requested level first and then
scaling it to the interval [min_power, max_power].

Co-authored-by: Thomas Niederprüm <niederp@physik.uni-kl.de>
This commit is contained in:
dubit0 2020-10-02 00:55:42 +02:00 committed by GitHub
parent dbec3d7c50
commit 002861f13b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
esphome/components/output/float_output.cpp
View File

@ -29,10 +29,9 @@ void FloatOutput::set_level(float state) {
this->power_.unrequest(); this->power_.unrequest();
} }
#endif #endif
float adjusted_value = (state * (this->max_power_ - this->min_power_)) + this->min_power_;
if (this->is_inverted()) if (this->is_inverted())
adjusted_value = 1.0f - adjusted_value; state = 1.0f - state;
float adjusted_value = (state * (this->max_power_ - this->min_power_)) + this->min_power_;
this->write_state(adjusted_value); this->write_state(adjusted_value);
} }