Fix up component tests by adding rx_full_threshold for esp32s

Also narrow the requirement to just esp32 platforms, since that's all that's implemented right now
2025-01-30 23:02:14 +01:00 · 2025-01-20 22:16:37 -08:00 · 2025-01-20 22:16:37 -08:00 · 60d065f83b
commit 60d065f83b
parent 53e05838ae
37 changed files with 40 additions and 1 deletions
--- a/esphome/components/modbus/init.py
+++ b/esphome/components/modbus/init.py
@ -12,6 +12,7 @@ from esphome.const import (
    CONF_ADDRESS,
    CONF_DISABLE_CRC,
 )
+from esphome.core import CORE
 from esphome import pins

 DEPENDENCIES = ["uart"]
@ -53,7 +54,8 @@ CONFIG_SCHEMA = (


 def validate_rx_full_threshold_uart(config):
-    uart.final_validate_device_schema("modbus", rx_full_threshold=1)(config)
+    if CORE.is_esp32:
+        uart.final_validate_device_schema("modbus", rx_full_threshold=1)(config)


 FINAL_VALIDATE_SCHEMA = validate_rx_full_threshold_uart
--- a/tests/components/growatt_solar/test.esp32-ard.yaml
+++ b/tests/components/growatt_solar/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 13
--- a/tests/components/growatt_solar/test.esp32-c3-ard.yaml
+++ b/tests/components/growatt_solar/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/growatt_solar/test.esp32-c3-idf.yaml
+++ b/tests/components/growatt_solar/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/growatt_solar/test.esp32-idf.yaml
+++ b/tests/components/growatt_solar/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 13
--- a/tests/components/havells_solar/test.esp32-ard.yaml
+++ b/tests/components/havells_solar/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/havells_solar/test.esp32-c3-ard.yaml
+++ b/tests/components/havells_solar/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/havells_solar/test.esp32-c3-idf.yaml
+++ b/tests/components/havells_solar/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/havells_solar/test.esp32-idf.yaml
+++ b/tests/components/havells_solar/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/kuntze/test.esp32-ard.yaml
+++ b/tests/components/kuntze/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 13
--- a/tests/components/kuntze/test.esp32-c3-ard.yaml
+++ b/tests/components/kuntze/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/kuntze/test.esp32-c3-idf.yaml
+++ b/tests/components/kuntze/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 3
--- a/tests/components/kuntze/test.esp32-idf.yaml
+++ b/tests/components/kuntze/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  flow_control_pin: 13
--- a/tests/components/modbus/test.esp32-ard.yaml
+++ b/tests/components/modbus/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus/test.esp32-c3-ard.yaml
+++ b/tests/components/modbus/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus/test.esp32-c3-idf.yaml
+++ b/tests/components/modbus/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus/test.esp32-idf.yaml
+++ b/tests/components/modbus/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus_controller/test.esp32-ard.yaml
+++ b/tests/components/modbus_controller/test.esp32-ard.yaml
@ -3,10 +3,12 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1
  - id: uart_modbus_server
    tx_pin: 1
    rx_pin: 3
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  - id: mod_bus1
--- a/tests/components/modbus_controller/test.esp32-c3-ard.yaml
+++ b/tests/components/modbus_controller/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus_controller/test.esp32-c3-idf.yaml
+++ b/tests/components/modbus_controller/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/modbus_controller/test.esp32-idf.yaml
+++ b/tests/components/modbus_controller/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:
  id: mod_bus1
--- a/tests/components/pzemac/test.esp32-ard.yaml
+++ b/tests/components/pzemac/test.esp32-ard.yaml
@ -8,6 +8,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:

--- a/tests/components/pzemac/test.esp32-c3-ard.yaml
+++ b/tests/components/pzemac/test.esp32-c3-ard.yaml
@ -8,6 +8,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:

--- a/tests/components/pzemac/test.esp32-c3-idf.yaml
+++ b/tests/components/pzemac/test.esp32-c3-idf.yaml
@ -8,6 +8,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:

--- a/tests/components/pzemac/test.esp32-idf.yaml
+++ b/tests/components/pzemac/test.esp32-idf.yaml
@ -8,6 +8,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 modbus:

--- a/tests/components/pzemdc/test.esp32-ard.yaml
+++ b/tests/components/pzemdc/test.esp32-ard.yaml
@ -9,6 +9,7 @@ uart:
    rx_pin: 16
    baud_rate: 9600
    stop_bits: 2
+    rx_full_threshold: 1

 sensor:
  - platform: pzemdc
--- a/tests/components/pzemdc/test.esp32-c3-ard.yaml
+++ b/tests/components/pzemdc/test.esp32-c3-ard.yaml
@ -9,6 +9,7 @@ uart:
    rx_pin: 5
    baud_rate: 9600
    stop_bits: 2
+    rx_full_threshold: 1

 sensor:
  - platform: pzemdc
--- a/tests/components/pzemdc/test.esp32-c3-idf.yaml
+++ b/tests/components/pzemdc/test.esp32-c3-idf.yaml
@ -9,6 +9,7 @@ uart:
    rx_pin: 5
    baud_rate: 9600
    stop_bits: 2
+    rx_full_threshold: 1

 sensor:
  - platform: pzemdc
--- a/tests/components/pzemdc/test.esp32-idf.yaml
+++ b/tests/components/pzemdc/test.esp32-idf.yaml
@ -9,6 +9,7 @@ uart:
    rx_pin: 16
    baud_rate: 9600
    stop_bits: 2
+    rx_full_threshold: 1

 sensor:
  - platform: pzemdc
--- a/tests/components/sdm_meter/test.esp32-ard.yaml
+++ b/tests/components/sdm_meter/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: sdm_meter
--- a/tests/components/sdm_meter/test.esp32-c3-ard.yaml
+++ b/tests/components/sdm_meter/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: sdm_meter
--- a/tests/components/sdm_meter/test.esp32-c3-idf.yaml
+++ b/tests/components/sdm_meter/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: sdm_meter
--- a/tests/components/sdm_meter/test.esp32-idf.yaml
+++ b/tests/components/sdm_meter/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: sdm_meter
--- a/tests/components/selec_meter/test.esp32-ard.yaml
+++ b/tests/components/selec_meter/test.esp32-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: selec_meter
--- a/tests/components/selec_meter/test.esp32-c3-ard.yaml
+++ b/tests/components/selec_meter/test.esp32-c3-ard.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: selec_meter
--- a/tests/components/selec_meter/test.esp32-c3-idf.yaml
+++ b/tests/components/selec_meter/test.esp32-c3-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 4
    rx_pin: 5
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: selec_meter
--- a/tests/components/selec_meter/test.esp32-idf.yaml
+++ b/tests/components/selec_meter/test.esp32-idf.yaml
@ -3,6 +3,7 @@ uart:
    tx_pin: 17
    rx_pin: 16
    baud_rate: 9600
+    rx_full_threshold: 1

 sensor:
  - platform: selec_meter