Upstream/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-11-25 12:15:33 +01:00
Code Issues Projects Releases Wiki Activity

Make default constructor safer

Browse Source
This commit is contained in:
Rapsssito 2024-08-14 23:31:34 +02:00
parent d7ea8d6dac
commit 6a7c4b2e59
2 changed files with 11 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
esphome/core/bytebuffer.cpp
View File

@ -4,9 +4,11 @@
namespace esphome {
ByteBuffer ByteBuffer::create(size_t capacity) {
ByteBuffer ByteBuffer::create(size_t capacity, Endian endianness) {
std::vector<uint8_t> data(capacity);
return {data};
ByteBuffer buffer = {data};
buffer.endianness_ = endianness;
return buffer;
}
ByteBuffer ByteBuffer::wrap(const uint8_t *ptr, size_t len) {
@ -23,46 +25,31 @@ ByteBuffer ByteBuffer::wrap(uint8_t value) {
}
ByteBuffer ByteBuffer::wrap(uint16_t value, Endian endianness) {
ByteBuffer buffer = ByteBuffer::create(2);
if (endianness == BIG) {
buffer.big_endian();
}
ByteBuffer buffer = ByteBuffer::create(2, endianness);
buffer.put_uint16(value);
return buffer;
}
ByteBuffer ByteBuffer::wrap(uint32_t value, Endian endianness) {
ByteBuffer buffer = ByteBuffer::create(4);
if (endianness == BIG) {
buffer.big_endian();
}
ByteBuffer buffer = ByteBuffer::create(4, endianness);
buffer.put_uint32(value);
return buffer;
}
ByteBuffer ByteBuffer::wrap(uint64_t value, Endian endianness) {
ByteBuffer buffer = ByteBuffer::create(8);
if (endianness == BIG) {
buffer.big_endian();
}
ByteBuffer buffer = ByteBuffer::create(8, endianness);
buffer.put_uint64(value);
return buffer;
}
ByteBuffer ByteBuffer::wrap(float value, Endian endianness) {
ByteBuffer buffer = ByteBuffer::create(sizeof(float));
if (endianness == BIG) {
buffer.big_endian();
}
ByteBuffer buffer = ByteBuffer::create(sizeof(float), endianness);
buffer.put_float(value);
return buffer;
}
ByteBuffer ByteBuffer::wrap(double value, Endian endianness) {
ByteBuffer buffer = ByteBuffer::create(sizeof(double));
if (endianness == BIG) {
buffer.big_endian();
}
ByteBuffer buffer = ByteBuffer::create(sizeof(double), endianness);
buffer.put_double(value);
return buffer;
}

4
esphome/core/bytebuffer.h
View File

@ -31,11 +31,11 @@ enum Endian { LITTLE, BIG };
class ByteBuffer {
public:
// Default constructor (compatibility with TEMPLATABLE_VALUE)
ByteBuffer() = default;
ByteBuffer() : ByteBuffer(std::vector<uint8_t>()) {}
/**
* Create a new Bytebuffer with the given capacity
*/
static ByteBuffer create(size_t capacity);
static ByteBuffer create(size_t capacity, Endian endianness = LITTLE);
/**
* Wrap an existing vector in a ByteBufffer
*/