1
0
mirror of https://github.com/esphome/esphome.git synced 2024-12-26 17:17:46 +01:00
esphome/script/ci-suggest-changes
Otto Winter 6682c43dfa
🏗 Merge C++ into python codebase ()
## Description:

Move esphome-core codebase into esphome (and a bunch of other refactors). See https://github.com/esphome/feature-requests/issues/97

Yes this is a shit ton of work and no there's no way to automate it :( But it will be worth it 👍

Progress:
- Core support (file copy etc): 80%
- Base Abstractions (light, switch): ~50%
- Integrations: ~10%
- Working? Yes, (but only with ported components).

Other refactors:
- Moves all codegen related stuff into a single class: `esphome.codegen` (imported as `cg`)
- Rework coroutine syntax
- Move from `component/platform.py` to `domain/component.py` structure as with HA
- Move all defaults out of C++ and into config validation.
- Remove `make_...` helpers from Application class. Reason: Merge conflicts with every single new integration.
- Pointer Variables are stored globally instead of locally in setup(). Reason: stack size limit.

Future work:
- Rework const.py - Move all `CONF_...` into a conf class (usage `conf.UPDATE_INTERVAL` vs `CONF_UPDATE_INTERVAL`). Reason: Less convoluted import block
- Enable loading from `custom_components` folder.

**Related issue (if applicable):** https://github.com/esphome/feature-requests/issues/97

**Pull request in [esphome-docs](https://github.com/esphome/esphome-docs) with documentation (if applicable):** esphome/esphome-docs#<esphome-docs PR number goes here>

## Checklist:
  - [ ] The code change is tested and works locally.
  - [ ] Tests have been added to verify that the new code works (under `tests/` folder).

If user exposed functionality or configuration variables are added/changed:
  - [ ] Documentation added/updated in [esphomedocs](https://github.com/OttoWinter/esphomedocs).
2019-04-17 12:06:00 +02:00

22 lines
606 B
Bash
Executable File

#!/usr/bin/env bash
set -e
if git diff-index --quiet HEAD --; then
echo "No changes detected, formatting is correct!"
exit 0
else
echo "========================================================="
echo "Your formatting is not correct, ESPHome uses clang-format to format"
echo "all source files in a unified way. Please apply the changes listed below"
echo
echo "The following files need to be changed:"
git diff HEAD --name-only | sed 's/^/ /'
echo
echo
echo "========================================================="
echo
git diff HEAD
exit 1
fi