Remove the label from artifacts when deleting a label

Fixes #12112, remove the label from artifacts when deleting a label

Signed-off-by: Wenkai Yin <yinw@vmware.com>

src/core/api/label.go

@@ -24,6 +24,8 @@ import (
 	"github.com/goharbor/harbor/src/common/dao"
 	"github.com/goharbor/harbor/src/common/models"
 	"github.com/goharbor/harbor/src/common/rbac"
+	"github.com/goharbor/harbor/src/lib/orm"
+	"github.com/goharbor/harbor/src/pkg/label"
 )
 
 // LabelAPI handles requests for label management
@@ -293,6 +295,12 @@ func (l *LabelAPI) Delete() {
 		l.SendInternalServerError(fmt.Errorf("failed to delete resource label mappings of label %d: %v", id, err))
 		return
 	}
+
+	if err := label.Mgr.RemoveFromAllArtifacts(orm.Context(), id); err != nil {
+		l.SendInternalServerError(fmt.Errorf("failed to remove the label %d from all artifacts: %v", id, err))
+		return
+	}
+
 	if err := dao.DeleteLabel(id); err != nil {
 		l.SendInternalServerError(fmt.Errorf("failed to delete label %d: %v", id, err))
 		return

src/pkg/label/manager.go

@@ -37,6 +37,8 @@ type Manager interface {
 	RemoveFrom(ctx context.Context, labelID int64, artifactID int64) (err error)
 	// Remove all labels added to the artifact specified by the ID
 	RemoveAllFrom(ctx context.Context, artifactID int64) (err error)
+	// RemoveFromAllArtifacts removes the label specified by the ID from all artifacts
+	RemoveFromAllArtifacts(ctx context.Context, labelID int64) (err error)
 }
 
 // New creates an instance of the default label manager
@@ -92,3 +94,12 @@ func (m *manager) RemoveAllFrom(ctx context.Context, artifactID int64) error {
 	})
 	return err
 }
+
+func (m *manager) RemoveFromAllArtifacts(ctx context.Context, labelID int64) error {
+	_, err := m.dao.DeleteReferences(ctx, &q.Query{
+		Keywords: map[string]interface{}{
+			"LabelID": labelID,
+		},
+	})
+	return err
+}

src/pkg/label/manager_test.go

@@ -118,6 +118,12 @@ func (m *managerTestSuite) TestRemoveAllFrom() {
 	m.Require().Nil(err)
 }
 
+func (m *managerTestSuite) TestRemoveFromAllArtifacts() {
+	m.dao.On("DeleteReferences").Return(2, nil)
+	err := m.mgr.RemoveFromAllArtifacts(nil, 1)
+	m.Require().Nil(err)
+}
+
 func TestManager(t *testing.T) {
 	suite.Run(t, &managerTestSuite{})
 }

src/testing/pkg/label/manager.go

@@ -62,3 +62,9 @@ func (f *FakeManager) RemoveAllFrom(ctx context.Context, artifactID int64) error
 	args := f.Called()
 	return args.Error(0)
 }
+
+// RemoveFromAllArtifacts ...
+func (f *FakeManager) RemoveFromAllArtifacts(ctx context.Context, labelID int64) error {
+	args := f.Called()
+	return args.Error(0)
+}