mirror of https://github.com/goharbor/harbor.git
Delete scan_report when accessory is removed
fixes #20319 Signed-off-by: stonezdj <stone.zhang@broadcom.com>
This commit is contained in:
parent
9471f5d5a6
commit
20a0b1ee6f
|
@ -24,6 +24,7 @@ import (
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/goharbor/harbor/src/controller/artifact"
|
"github.com/goharbor/harbor/src/controller/artifact"
|
||||||
|
"github.com/goharbor/harbor/src/controller/artifact/processor/sbom"
|
||||||
"github.com/goharbor/harbor/src/controller/event"
|
"github.com/goharbor/harbor/src/controller/event"
|
||||||
"github.com/goharbor/harbor/src/controller/event/operator"
|
"github.com/goharbor/harbor/src/controller/event/operator"
|
||||||
"github.com/goharbor/harbor/src/controller/repository"
|
"github.com/goharbor/harbor/src/controller/repository"
|
||||||
|
@ -36,6 +37,7 @@ import (
|
||||||
"github.com/goharbor/harbor/src/pkg"
|
"github.com/goharbor/harbor/src/pkg"
|
||||||
pkgArt "github.com/goharbor/harbor/src/pkg/artifact"
|
pkgArt "github.com/goharbor/harbor/src/pkg/artifact"
|
||||||
"github.com/goharbor/harbor/src/pkg/scan/report"
|
"github.com/goharbor/harbor/src/pkg/scan/report"
|
||||||
|
v1 "github.com/goharbor/harbor/src/pkg/scan/rest/v1"
|
||||||
"github.com/goharbor/harbor/src/pkg/task"
|
"github.com/goharbor/harbor/src/pkg/task"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
@ -319,6 +321,11 @@ func (a *ArtifactEventHandler) onDelete(ctx context.Context, event *event.Artifa
|
||||||
log.Errorf("failed to delete scan reports of artifact %v, error: %v", unrefDigests, err)
|
log.Errorf("failed to delete scan reports of artifact %v, error: %v", unrefDigests, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if event.Artifact.Type == sbom.ArtifactTypeSBOM && len(event.Artifact.Digest) > 0 {
|
||||||
|
if err := reportMgr.DeleteByExtraAttr(ctx, v1.MimeTypeSBOMReport, "sbom_digest", event.Artifact.Digest); err != nil {
|
||||||
|
log.Errorf("failed to delete scan reports of with sbom digest %v, error: %v", event.Artifact.Digest, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -16,6 +16,7 @@ package scan
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"fmt"
|
||||||
|
|
||||||
"github.com/goharbor/harbor/src/lib/errors"
|
"github.com/goharbor/harbor/src/lib/errors"
|
||||||
"github.com/goharbor/harbor/src/lib/orm"
|
"github.com/goharbor/harbor/src/lib/orm"
|
||||||
|
@ -38,6 +39,8 @@ type DAO interface {
|
||||||
UpdateReportData(ctx context.Context, uuid string, report string) error
|
UpdateReportData(ctx context.Context, uuid string, report string) error
|
||||||
// Update update report
|
// Update update report
|
||||||
Update(ctx context.Context, r *Report, cols ...string) error
|
Update(ctx context.Context, r *Report, cols ...string) error
|
||||||
|
// DeleteByExtraAttr delete the scan_report by mimeType and extra attribute
|
||||||
|
DeleteByExtraAttr(ctx context.Context, mimeType, attrName, attrValue string) error
|
||||||
}
|
}
|
||||||
|
|
||||||
// New returns an instance of the default DAO
|
// New returns an instance of the default DAO
|
||||||
|
@ -110,3 +113,14 @@ func (d *dao) Update(ctx context.Context, r *Report, cols ...string) error {
|
||||||
}
|
}
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (d *dao) DeleteByExtraAttr(ctx context.Context, mimeType, attrName, attrValue string) error {
|
||||||
|
o, err := orm.FromContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
delReportSQL := "delete from scan_report where mime_type = ? and report::jsonb @> ?"
|
||||||
|
dgstJSONStr := fmt.Sprintf(`{"%s":"%s"}`, attrName, attrValue)
|
||||||
|
_, err = o.Raw(delReportSQL, mimeType, dgstJSONStr).Exec()
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
|
@ -53,14 +53,23 @@ func (suite *ReportTestSuite) SetupTest() {
|
||||||
RegistrationUUID: "ruuid",
|
RegistrationUUID: "ruuid",
|
||||||
MimeType: v1.MimeTypeNativeReport,
|
MimeType: v1.MimeTypeNativeReport,
|
||||||
}
|
}
|
||||||
|
|
||||||
suite.create(r)
|
suite.create(r)
|
||||||
|
sbomReport := &Report{
|
||||||
|
UUID: "uuid3",
|
||||||
|
Digest: "digest1003",
|
||||||
|
RegistrationUUID: "ruuid",
|
||||||
|
MimeType: v1.MimeTypeSBOMReport,
|
||||||
|
Report: `{"sbom_digest": "sha256:abc"}`,
|
||||||
|
}
|
||||||
|
suite.create(sbomReport)
|
||||||
}
|
}
|
||||||
|
|
||||||
// TearDownTest clears enf for test case.
|
// TearDownTest clears enf for test case.
|
||||||
func (suite *ReportTestSuite) TearDownTest() {
|
func (suite *ReportTestSuite) TearDownTest() {
|
||||||
_, err := suite.dao.DeleteMany(orm.Context(), q.Query{Keywords: q.KeyWords{"uuid": "uuid"}})
|
_, err := suite.dao.DeleteMany(orm.Context(), q.Query{Keywords: q.KeyWords{"uuid": "uuid"}})
|
||||||
require.NoError(suite.T(), err)
|
require.NoError(suite.T(), err)
|
||||||
|
_, err = suite.dao.DeleteMany(orm.Context(), q.Query{Keywords: q.KeyWords{"uuid": "uuid3"}})
|
||||||
|
require.NoError(suite.T(), err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestReportList tests list reports with query parameters.
|
// TestReportList tests list reports with query parameters.
|
||||||
|
@ -95,7 +104,7 @@ func (suite *ReportTestSuite) TestReportUpdateReportData() {
|
||||||
err := suite.dao.UpdateReportData(orm.Context(), "uuid", "{}")
|
err := suite.dao.UpdateReportData(orm.Context(), "uuid", "{}")
|
||||||
suite.Require().NoError(err)
|
suite.Require().NoError(err)
|
||||||
|
|
||||||
l, err := suite.dao.List(orm.Context(), nil)
|
l, err := suite.dao.List(orm.Context(), q.New(q.KeyWords{"uuid": "uuid"}))
|
||||||
suite.Require().NoError(err)
|
suite.Require().NoError(err)
|
||||||
suite.Require().Equal(1, len(l))
|
suite.Require().Equal(1, len(l))
|
||||||
suite.Equal("{}", l[0].Report)
|
suite.Equal("{}", l[0].Report)
|
||||||
|
@ -104,6 +113,17 @@ func (suite *ReportTestSuite) TestReportUpdateReportData() {
|
||||||
suite.Require().NoError(err)
|
suite.Require().NoError(err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (suite *ReportTestSuite) TestDeleteReportBySBOMDigest() {
|
||||||
|
l, err := suite.dao.List(orm.Context(), nil)
|
||||||
|
suite.Require().NoError(err)
|
||||||
|
suite.Equal(2, len(l))
|
||||||
|
err = suite.dao.DeleteByExtraAttr(orm.Context(), v1.MimeTypeSBOMReport, "sbom_digest", "sha256:abc")
|
||||||
|
suite.Require().NoError(err)
|
||||||
|
l2, err := suite.dao.List(orm.Context(), nil)
|
||||||
|
suite.Require().NoError(err)
|
||||||
|
suite.Equal(1, len(l2))
|
||||||
|
}
|
||||||
|
|
||||||
func (suite *ReportTestSuite) create(r *Report) {
|
func (suite *ReportTestSuite) create(r *Report) {
|
||||||
id, err := suite.dao.Create(orm.Context(), r)
|
id, err := suite.dao.Create(orm.Context(), r)
|
||||||
suite.Require().NoError(err)
|
suite.Require().NoError(err)
|
||||||
|
|
|
@ -104,6 +104,8 @@ type Manager interface {
|
||||||
|
|
||||||
// Update update report information
|
// Update update report information
|
||||||
Update(ctx context.Context, r *scan.Report, cols ...string) error
|
Update(ctx context.Context, r *scan.Report, cols ...string) error
|
||||||
|
// DeleteByExtraAttr delete scan_report by sbom_digest
|
||||||
|
DeleteByExtraAttr(ctx context.Context, mimeType, attrName, attrValue string) error
|
||||||
}
|
}
|
||||||
|
|
||||||
// basicManager is a default implementation of report manager.
|
// basicManager is a default implementation of report manager.
|
||||||
|
@ -226,3 +228,7 @@ func (bm *basicManager) List(ctx context.Context, query *q.Query) ([]*scan.Repor
|
||||||
func (bm *basicManager) Update(ctx context.Context, r *scan.Report, cols ...string) error {
|
func (bm *basicManager) Update(ctx context.Context, r *scan.Report, cols ...string) error {
|
||||||
return bm.dao.Update(ctx, r, cols...)
|
return bm.dao.Update(ctx, r, cols...)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (bm *basicManager) DeleteByExtraAttr(ctx context.Context, mimeType, attrName, attrValue string) error {
|
||||||
|
return bm.dao.DeleteByExtraAttr(ctx, mimeType, attrName, attrValue)
|
||||||
|
}
|
||||||
|
|
|
@ -87,6 +87,24 @@ func (_m *Manager) DeleteByDigests(ctx context.Context, digests ...string) error
|
||||||
return r0
|
return r0
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// DeleteByExtraAttr provides a mock function with given fields: ctx, mimeType, attrName, attrValue
|
||||||
|
func (_m *Manager) DeleteByExtraAttr(ctx context.Context, mimeType string, attrName string, attrValue string) error {
|
||||||
|
ret := _m.Called(ctx, mimeType, attrName, attrValue)
|
||||||
|
|
||||||
|
if len(ret) == 0 {
|
||||||
|
panic("no return value specified for DeleteByExtraAttr")
|
||||||
|
}
|
||||||
|
|
||||||
|
var r0 error
|
||||||
|
if rf, ok := ret.Get(0).(func(context.Context, string, string, string) error); ok {
|
||||||
|
r0 = rf(ctx, mimeType, attrName, attrValue)
|
||||||
|
} else {
|
||||||
|
r0 = ret.Error(0)
|
||||||
|
}
|
||||||
|
|
||||||
|
return r0
|
||||||
|
}
|
||||||
|
|
||||||
// GetBy provides a mock function with given fields: ctx, digest, registrationUUID, mimeTypes
|
// GetBy provides a mock function with given fields: ctx, digest, registrationUUID, mimeTypes
|
||||||
func (_m *Manager) GetBy(ctx context.Context, digest string, registrationUUID string, mimeTypes []string) ([]*scan.Report, error) {
|
func (_m *Manager) GetBy(ctx context.Context, digest string, registrationUUID string, mimeTypes []string) ([]*scan.Report, error) {
|
||||||
ret := _m.Called(ctx, digest, registrationUUID, mimeTypes)
|
ret := _m.Called(ctx, digest, registrationUUID, mimeTypes)
|
||||||
|
|
Loading…
Reference in New Issue