Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2025-01-03 06:28:06 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #4395 from reasonerjt/fix-project-length-limit

Browse Source 
Extend the length of project name in request validation
This commit is contained in:
Daniel Jiang 2018-03-12 19:20:21 +08:00 committed by GitHub
commit 230bb89d1e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ui/api/project.go
View File

@ -42,7 +42,7 @@ type ProjectAPI struct {
project *models.Project project *models.Project
} }
const projectNameMaxLen int = 30 const projectNameMaxLen int = 255
const projectNameMinLen int = 2 const projectNameMinLen int = 2
const restrictedNameChars = `[a-z0-9]+(?:[._-][a-z0-9]+)*` const restrictedNameChars = `[a-z0-9]+(?:[._-][a-z0-9]+)*`
@ -491,7 +491,7 @@ func (p *ProjectAPI) Logs() {
func validateProjectReq(req *models.ProjectRequest) error { func validateProjectReq(req *models.ProjectRequest) error {
pn := req.Name pn := req.Name
if isIllegalLength(req.Name, projectNameMinLen, projectNameMaxLen) { if isIllegalLength(req.Name, projectNameMinLen, projectNameMaxLen) {
return fmt.Errorf("Project name is illegal in length. (greater than 2 or less than 30)") return fmt.Errorf("Project name is illegal in length. (greater than %d or less than %d)", projectNameMaxLen, projectNameMinLen)
} }
validProjectName := regexp.MustCompile(`^` + restrictedNameChars + `$`) validProjectName := regexp.MustCompile(`^` + restrictedNameChars + `$`)
legal := validProjectName.MatchString(pn) legal := validProjectName.MatchString(pn)