From 34d5591b1b9d84fdeb0f08b7cfd56155ad8f2aec Mon Sep 17 00:00:00 2001 From: Max Rosin Date: Tue, 16 Jun 2020 12:18:55 +0200 Subject: [PATCH] Fix DOCKERIMASES and SWAAGER_IMAGE_BUILD_CMD typos in Makefiles Fix #12259 Signed-off-by: Max Rosin --- Makefile | 8 ++++---- make/photon/Makefile | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index e7f398e4b..2bdb5b32e 100644 --- a/Makefile +++ b/Makefile @@ -137,7 +137,7 @@ DOCKERCMD=$(shell which docker) DOCKERBUILD=$(DOCKERCMD) build DOCKERRMIMAGE=$(DOCKERCMD) rmi DOCKERPULL=$(DOCKERCMD) pull -DOCKERIMASES=$(DOCKERCMD) images +DOCKERIMAGES=$(DOCKERCMD) images DOCKERSAVE=$(DOCKERCMD) save DOCKERCOMPOSECMD=$(shell which docker-compose) DOCKERTAG=$(DOCKERCMD) tag @@ -304,11 +304,11 @@ SWAGGER_IMAGENAME=goharbor/swagger SWAGGER_VERSION=v0.21.0 SWAGGER=$(DOCKERCMD) run --rm -u $(shell id -u):$(shell id -g) -v $(BUILDPATH):$(BUILDPATH) -w $(BUILDPATH) ${SWAGGER_IMAGENAME}:${SWAGGER_VERSION} SWAGGER_GENERATE_SERVER=${SWAGGER} generate server --template-dir=$(TOOLSPATH)/swagger/templates --exclude-main -SWAAGER_IMAGE_BUILD_CMD=${DOCKERBUILD} -f ${TOOLSPATH}/swagger/Dockerfile --build-arg SWAGGER_VERSION=${SWAGGER_VERSION} -t ${SWAGGER_IMAGENAME}:$(SWAGGER_VERSION) . +SWAGGER_IMAGE_BUILD_CMD=${DOCKERBUILD} -f ${TOOLSPATH}/swagger/Dockerfile --build-arg SWAGGER_VERSION=${SWAGGER_VERSION} -t ${SWAGGER_IMAGENAME}:$(SWAGGER_VERSION) . SWAGGER_IMAGENAME: - @if [ "$(shell ${DOCKERIMASES} -q ${SWAGGER_IMAGENAME}:$(SWAGGER_VERSION) 2> /dev/null)" == "" ]; then \ - ${SWAAGER_IMAGE_BUILD_CMD} && echo "build swagger image successfully" || (echo "build swagger image failed" && exit 1) ; \ + @if [ "$(shell ${DOCKERIMAGES} -q ${SWAGGER_IMAGENAME}:$(SWAGGER_VERSION) 2> /dev/null)" == "" ]; then \ + ${SWAGGER_IMAGE_BUILD_CMD} && echo "build swagger image successfully" || (echo "build swagger image failed" && exit 1) ; \ fi # $1 the path of swagger spec diff --git a/make/photon/Makefile b/make/photon/Makefile index 13f1bd082..a54012b20 100644 --- a/make/photon/Makefile +++ b/make/photon/Makefile @@ -19,7 +19,7 @@ CURL=$(shell which curl) DOCKERCMD=$(shell which docker) DOCKERBUILD=$(DOCKERCMD) build DOCKERRMIMAGE=$(DOCKERCMD) rmi -DOCKERIMASES=$(DOCKERCMD) images +DOCKERIMAGES=$(DOCKERCMD) images BASEIMAGENAMESPACE=goharbor # binary