Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-11-23 18:55:18 +01:00
Code Issues Projects Releases Wiki Activity

fix issue7793: ping ldap server is always success (#7795)

Browse Source 
Signed-off-by: stonezdj <stonezdj@gmail.com>
This commit is contained in:
Wang Yan 2019-05-15 11:35:57 +08:00 committed by GitHub
commit 3be14b7997
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/api/ldap.go
View File

@ -79,10 +79,10 @@ func (l *LdapAPI) Prepare() {
// Ping ... // Ping ...
func (l *LdapAPI) Ping() { func (l *LdapAPI) Ping() {
var err error
var ldapConfs = models.LdapConf{ var ldapConfs = models.LdapConf{
LdapConnectionTimeout: 5, LdapConnectionTimeout: 5,
} }
var err error
l.Ctx.Input.CopyBody(1 << 32) l.Ctx.Input.CopyBody(1 << 32)
@ -90,7 +90,8 @@ func (l *LdapAPI) Ping() {
ldapSession := *l.ldapConfig ldapSession := *l.ldapConfig
err = ldapSession.ConnectionTest() err = ldapSession.ConnectionTest()
} else { } else {
isValid, err := l.DecodeJSONReqAndValidate(&ldapConfs) var isValid bool
isValid, err = l.DecodeJSONReqAndValidate(&ldapConfs)
if !isValid { if !isValid {
l.SendBadRequestError(err) l.SendBadRequestError(err)
return return