Stastics API should handle group members

statistic API use security Context to list project rather than calling
projectmanager directly, such that the group membership will be taken
into account.
fixes #10230

It should be cherry picked to 1.9.x and 1.10.x branches

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
This commit is contained in:
Daniel Jiang 2019-12-11 18:04:18 +08:00
parent c614c165fa
commit 3cc9b42b68

View File

@ -67,7 +67,7 @@ func (s *StatisticAPI) Get() {
if len(pubProjs) == 0 { if len(pubProjs) == 0 {
statistic[PubRC] = 0 statistic[PubRC] = 0
} else { } else {
ids := []int64{} ids := make([]int64, 0)
for _, p := range pubProjs { for _, p := range pubProjs {
ids = append(ids, p.ProjectID) ids = append(ids, p.ProjectID)
} }
@ -101,30 +101,26 @@ func (s *StatisticAPI) Get() {
statistic[TRC] = n statistic[TRC] = n
statistic[PriRC] = n - statistic[PubRC] statistic[PriRC] = n - statistic[PubRC]
} else { } else {
value := false // including the public ones
result, err := s.ProjectMgr.List(&models.ProjectQueryParam{ myProjects, err := s.SecurityCtx.GetMyProjects()
Public: &value, privProjectIDs := make([]int64, 0)
Member: &models.MemberQuery{
Name: s.username,
},
})
if err != nil { if err != nil {
s.ParseAndHandleError(fmt.Sprintf( s.ParseAndHandleError(fmt.Sprintf(
"failed to get projects of user %s", s.username), err) "failed to get projects of user %s", s.username), err)
return return
} }
for _, p := range myProjects {
if !p.IsPublic() {
privProjectIDs = append(privProjectIDs, p.ProjectID)
}
}
statistic[PriPC] = result.Total statistic[PriPC] = int64(len(privProjectIDs))
if result.Total == 0 { if statistic[PriPC] == 0 {
statistic[PriRC] = 0 statistic[PriRC] = 0
} else { } else {
ids := []int64{}
for _, p := range result.Projects {
ids = append(ids, p.ProjectID)
}
n, err := dao.GetTotalOfRepositories(&models.RepositoryQuery{ n, err := dao.GetTotalOfRepositories(&models.RepositoryQuery{
ProjectIDs: ids, ProjectIDs: privProjectIDs,
}) })
if err != nil { if err != nil {
s.SendInternalServerError(fmt.Errorf( s.SendInternalServerError(fmt.Errorf(