Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2025-02-26 16:51:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix access level can not sort

Browse Source 
Issue description:
In project list page. User click sort according access level, it does not work.

Fix:

Remodify the compare method.
This commit is contained in:
System Administrator 2018-08-01 16:57:27 +08:00 committed by zhoumeina
parent 3c0bd20d7e
commit 54f9b60ea4
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ui_ng/src/app/project/list-project/list-project.component.ts
View File

@ -58,7 +58,7 @@ export class ListProjectComponent implements OnDestroy {
roleInfo = RoleInfo; roleInfo = RoleInfo;
repoCountComparator: Comparator<Project> = new CustomComparator<Project>("repo_count", "number"); repoCountComparator: Comparator<Project> = new CustomComparator<Project>("repo_count", "number");
timeComparator: Comparator<Project> = new CustomComparator<Project>("creation_time", "date"); timeComparator: Comparator<Project> = new CustomComparator<Project>("creation_time", "date");
accessLevelComparator: Comparator<Project> = new CustomComparator<Project>("public", "number"); accessLevelComparator: Comparator<Project> = new CustomComparator<Project>("public", "string");
roleComparator: Comparator<Project> = new CustomComparator<Project>("current_user_role_id", "number"); roleComparator: Comparator<Project> = new CustomComparator<Project>("current_user_role_id", "number");
currentPage = 1; currentPage = 1;
totalCount = 0; totalCount = 0;

22
src/ui_ng/src/app/shared/shared.utils.ts
View File

@ -143,8 +143,23 @@ export class CustomComparator<T> implements Comparator<T> {
compare(a: { [key: string]: any | any[] }, b: { [key: string]: any | any[] }) { compare(a: { [key: string]: any | any[] }, b: { [key: string]: any | any[] }) {
let comp = 0; let comp = 0;
if (a && b) { if (a && b) {
let fieldA = a[this.fieldName]; let fieldA, fieldB;
let fieldB = b[this.fieldName]; for (let key of Object.keys(a)) {
if (key === this.fieldName) {
fieldA = a[key];
fieldB = b[key];
break;
} else if (typeof a[key] === 'object') {
let insideObject = a[key];
for (let insideKey in insideObject) {
if (insideKey === this.fieldName) {
fieldA = insideObject[insideKey];
fieldB = b[key][insideKey];
break;
}
}
}
}
switch (this.type) { switch (this.type) {
case "number": case "number":
comp = fieldB - fieldA; comp = fieldB - fieldA;
@ -152,6 +167,9 @@ export class CustomComparator<T> implements Comparator<T> {
case "date": case "date":
comp = new Date(fieldB).getTime() - new Date(fieldA).getTime(); comp = new Date(fieldB).getTime() - new Date(fieldA).getTime();
break; break;
case "string":
comp = fieldB.localeCompare(fieldA);
break;
} }
} }
return comp; return comp;