Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-12-25 10:07:43 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #6176 from steven-zou/support_health_check_js

Browse Source 
Support health check free call in job service
This commit is contained in:
Wenkai Yin 2018-10-31 09:42:42 +08:00 committed by GitHub
commit 5d585c7c65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/jobservice/api/router.go
View File

@ -63,7 +63,9 @@ func NewBaseRouter(handler Handler, authenticator Authenticator) Router {
// ServeHTTP is the implementation of Router interface. // ServeHTTP is the implementation of Router interface.
func (br *BaseRouter) ServeHTTP(w http.ResponseWriter, req *http.Request) { func (br *BaseRouter) ServeHTTP(w http.ResponseWriter, req *http.Request) {
// Do auth // No auth required for /stats as it is a health check endpoint
// Do auth for other services
if req.URL.String() != fmt.Sprintf("%s/%s/stats", baseRoute, apiVersion) {
if err := br.authenticator.DoAuth(req); err != nil { if err := br.authenticator.DoAuth(req); err != nil {
authErr := errs.UnauthorizedError(err) authErr := errs.UnauthorizedError(err)
logger.Errorf("Serve http request '%s %s' failed with error: %s", req.Method, req.URL.String(), authErr.Error()) logger.Errorf("Serve http request '%s %s' failed with error: %s", req.Method, req.URL.String(), authErr.Error())
@ -71,6 +73,7 @@ func (br *BaseRouter) ServeHTTP(w http.ResponseWriter, req *http.Request) {
w.Write([]byte(authErr.Error())) w.Write([]byte(authErr.Error()))
return return
} }
}
// Directly pass requests to the server mux. // Directly pass requests to the server mux.
br.router.ServeHTTP(w, req) br.router.ServeHTTP(w, req)