Merge pull request #6176 from steven-zou/support_health_check_js

Support health check free call in job service
This commit is contained in:
Wenkai Yin 2018-10-31 09:42:42 +08:00 committed by GitHub
commit 5d585c7c65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -63,13 +63,16 @@ func NewBaseRouter(handler Handler, authenticator Authenticator) Router {
// ServeHTTP is the implementation of Router interface. // ServeHTTP is the implementation of Router interface.
func (br *BaseRouter) ServeHTTP(w http.ResponseWriter, req *http.Request) { func (br *BaseRouter) ServeHTTP(w http.ResponseWriter, req *http.Request) {
// Do auth // No auth required for /stats as it is a health check endpoint
if err := br.authenticator.DoAuth(req); err != nil { // Do auth for other services
authErr := errs.UnauthorizedError(err) if req.URL.String() != fmt.Sprintf("%s/%s/stats", baseRoute, apiVersion) {
logger.Errorf("Serve http request '%s %s' failed with error: %s", req.Method, req.URL.String(), authErr.Error()) if err := br.authenticator.DoAuth(req); err != nil {
w.WriteHeader(http.StatusUnauthorized) authErr := errs.UnauthorizedError(err)
w.Write([]byte(authErr.Error())) logger.Errorf("Serve http request '%s %s' failed with error: %s", req.Method, req.URL.String(), authErr.Error())
return w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte(authErr.Error()))
return
}
} }
// Directly pass requests to the server mux. // Directly pass requests to the server mux.