update golangci-lint for golang1.19 (#17817)

update golaci-lint for golang1.19

Signed-off-by: yminer <yminer@vmware.com>

update ci version to v1.50.1

src/.golangci.yaml

@@ -34,7 +34,7 @@ linters:
     - revive
     - whitespace
     - bodyclose
-    - deadcode
+    # - deadcode //deprecated since golangci-lint v1.49.0
     - errcheck
     # - gosec
     - gosimple
@@ -43,12 +43,12 @@ linters:
     # - noctx
     # - rowserrcheck
     - staticcheck
-    - structcheck
+    # - structcheck //deprecated since golangci-lint v1.49.0
     - stylecheck
     # - unconvert
     # - unparam
-    - unused
-    - varcheck
+    # - unused  // disabled due to too many false positive check and limited support golang 1.19 https://github.com/dominikh/go-tools/issues/1282
+    # - varcheck //deprecated since golangci-lint v1.49.0
  
 run:
   skip-files:

src/chartserver/cache.go

@@ -85,6 +85,7 @@ func NewChartCache(config *ChartCacheConfig) *ChartCache {
 
 // IsEnabled to indicate if the chart cache is successfully enabled
 // The cache may be disabled if
+//
 //	user does not set
 //	wrong configurations
 func (chc *ChartCache) IsEnabled() bool {

src/common/api/base.go

@@ -248,6 +248,7 @@ func (b *BaseAPI) SendStatusServiceUnavailableError(err error) {
 }
 
 // SendError return the error defined in OCI spec: https://github.com/opencontainers/distribution-spec/blob/master/spec.md#errors
+//
 //	{
 //		"errors:" [{
 //				"code": <error identifier>,

src/controller/artifact/processor/default.go

@@ -65,6 +65,7 @@ func (d *defaultProcessor) ListAdditionTypes(ctx context.Context, artifact *arti
 // AbstractMetadata will abstract data in a specific way.
 // Annotation keys in artifact annotation will decide which content will be processed in artifact.
 // Here is a manifest example:
+//
 //	{
 //	  "schemaVersion": 2,
 //	  "config": {

src/controller/p2p/preheat/controller.go

@@ -124,7 +124,6 @@ type Controller interface {
 var _ Controller = (*controller)(nil)
 
 // controller is the default implementation of Controller interface.
-//
 type controller struct {
 	// For instance
 	iManager instance.Manager

src/jobservice/job/impl/purge/purge.go

@@ -52,7 +52,7 @@ func (j *Job) Validate(params job.Parameters) error {
 }
 
 func (j *Job) parseParams(params job.Parameters) {
-	if params == nil || len(params) == 0 {
+	if len(params) == 0 {
 		return
 	}
 	retHr, exist := params[common.PurgeAuditRetentionHour]

src/jobservice/job/impl/sample/job.go

@@ -44,7 +44,7 @@ func (j *Job) ShouldRetry() bool {
 
 // Validate is implementation of same method in Interface.
 func (j *Job) Validate(params job.Parameters) error {
-	if params == nil || len(params) == 0 {
+	if len(params) == 0 {
 		return errors.New("parameters required for replication job")
 	}
 	name, ok := params["image"]

src/jobservice/job/impl/scandataexport/scan_data_export.go

@@ -47,6 +47,7 @@ func (sde *ScanDataExport) MaxCurrency() uint {
 // still less that the number declared by the method 'MaxFails'.
 //
 // Returns:
+//
 //	true for retry and false for none-retry
 func (sde *ScanDataExport) ShouldRetry() bool {
 	return true
@@ -66,8 +67,8 @@ func (sde *ScanDataExport) Validate(params job.Parameters) error {
 // params map[string]interface{} : parameters with key-pair style for the job execution.
 //
 // Returns:
-//  error if failed to run. NOTES: If job is stopped or cancelled, a specified error should be returned
 //
+//	error if failed to run. NOTES: If job is stopped or cancelled, a specified error should be returned
 func (sde *ScanDataExport) Run(ctx job.Context, params job.Parameters) error {
 	if _, ok := params[export.JobModeKey]; !ok {
 		return errors.Errorf("no mode specified for scan data export execution")

src/jobservice/logger/base.go

@@ -128,8 +128,10 @@ func GetSweeper(context context.Context, sweeperOptions ...Option) (sweeper.Inte
 //	loggerOptions ...Option : logger options
 //
 // If failed,
+//
 //	configured but initialize failed: a nil log data getter and a non-nil error will be returned.
 //	no getter configured: a nil log data getter with a nil error are returned
+//
 // Otherwise, a non nil log data getter is returned with nil error.
 func GetLogDataGetter(loggerOptions ...Option) (getter.Interface, error) {
 	if len(loggerOptions) == 0 {

src/lib/orm/metadata.go

@@ -148,6 +148,7 @@ func parseModel(model interface{}) *metadata {
 
 // parseFilterable parses whether the field is filterable according to the field annotation
 // For the following struct definition, "Field1" isn't filterable and "Field2" is filterable
+//
 //	type Model struct {
 //		 Field1 string `filter:"false"`
 //		 Field2 string
@@ -159,6 +160,7 @@ func parseFilterable(field reflect.StructField) bool {
 // parseSortable parses whether the field is sortable according to the field annotation
 // If the field is sortable and is also specified as the default sort, return a q.Sort model as well
 // For the following struct definition, "Field1" isn't sortable and "Field2", "Field2", "Field4", "Field5" are all sortable
+//
 //	type Model struct {
 //		 Field1 string `sort:"false"`
 //		 Field2 string `sort:"true;default"`
@@ -188,10 +190,12 @@ func parseSortable(field reflect.StructField) (*q.Sort, bool) {
 }
 
 // parseColumn parses the column name according to the field annotation
+//
 //	type Model struct {
 //		 Field1 string `orm:"column(customized_field1)"`
 //		 Field2 string
 //	}
+//
 // It returns "customized_field1" for "Field1" and returns "field2" for "Field2"
 func parseColumn(field reflect.StructField) string {
 	column := ""

src/lib/orm/query.go

@@ -27,6 +27,7 @@ import (
 
 // QuerySetter generates the query setter according to the provided model and query.
 // e.g.
+//
 //	type Foo struct{
 //	  Field1 string `orm:"-"`                         // can not filter/sort
 //	  Field2 string `orm:"column(customized_field2)"` // support filter by "Field2", "customized_field2"
@@ -34,18 +35,23 @@ import (
 //	  Field4 string `sort:"default:desc"`             // the default field/order(asc/desc) to sort if no sorting specified in query.
 //	  Field5 string `filter:"false"`                  // cannot be filtered
 //	}
+//
 // // support filter by "Field6", "field6"
+//
 //	func (f *Foo) FilterByField6(ctx context.Context, qs orm.QuerySetter, key string, value interface{}) orm.QuerySetter {
 //	  ...
 //		 return qs
 //	}
 //
 // Defining the method "GetDefaultSorts() []*q.Sort" for the model whose default sorting contains more than one fields
+//
 //	type Bar struct{
 //	  Field1 string
 //	  Field2 string
 //	}
+//
 // // Sort by "Field1" desc, "Field2"
+//
 //	func (b *Bar) GetDefaultSorts() []*q.Sort {
 //		return []*q.Sort{
 //			{

src/pkg/accessory/model/accessory.go

@@ -44,10 +44,12 @@ Soft reference: The accessory is not tied to the subject manifest.
 Hard reference: The accessory is tied to the subject manifest.
 
 	Deletion
+
 1. Soft Reference:  If the linkage is Soft Reference, when the subject artifact is removed, the linkage will be removed as well, the accessory artifact becomes an individual artifact.
 2. Hard Reference:  If the linkage is Hard Reference, the accessory artifact will be removed together with the subject artifact.
 
 	Garbage Collection
+
 1. Soft Reference:  If the linkage is Soft Reference, Harbor treats the accessory as normal artifact and will not set it as the GC candidate.
 2. Hard Reference:  If the linkage is Hard Reference, Harbor treats the accessory as an extra stuff of the subject artifact. It means, it being tied to the subject artifact and will be GCed whenever the subject artifact is marked and deleted.
 */

src/pkg/p2p/preheat/provider/driver.go

@@ -18,6 +18,7 @@ const (
 
 // Driver defines the capabilities one distribution provider should have.
 // Includes:
+//
 //	Self descriptor
 //	Health checking
 //	Preheat related : Preheat means transfer the preheating image to the network of distribution provider in advance.

src/server/v2.0/handler/auditlog.go

@@ -16,7 +16,6 @@ import (
 	"github.com/goharbor/harbor/src/pkg/audit"
 	"github.com/goharbor/harbor/src/server/v2.0/models"
 	"github.com/goharbor/harbor/src/server/v2.0/restapi/operations/auditlog"
-	operation "github.com/goharbor/harbor/src/server/v2.0/restapi/operations/auditlog"
 )
 
 func newAuditLogAPI() *auditlogAPI {
@@ -92,7 +91,7 @@ func (a *auditlogAPI) ListAuditLogs(ctx context.Context, params auditlog.ListAud
 			OpTime:       strfmt.DateTime(log.OpTime),
 		})
 	}
-	return operation.NewListAuditLogsOK().
+	return auditlog.NewListAuditLogsOK().
 		WithXTotalCount(total).
 		WithLink(a.Links(ctx, params.HTTPRequest.URL, total, query.PageNumber, query.PageSize).String()).
 		WithPayload(auditLogs)

src/server/v2.0/handler/model/gc.go

@@ -6,6 +6,8 @@ import (
 	"time"
 
 	"github.com/go-openapi/strfmt"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 
 	"github.com/goharbor/harbor/src/common/utils"
 	"github.com/goharbor/harbor/src/lib/log"
@@ -47,7 +49,7 @@ func (h *GCHistory) ToSwagger() *models.GCHistory {
 		Schedule: &models.ScheduleObj{
 			// covert MANUAL to Manual because the type of the ScheduleObj
 			// must be 'Hourly', 'Daily', 'Weekly', 'Custom', 'Manual' and 'None'
-			Type:              strings.Title(strings.ToLower(h.Schedule.Type)),
+			Type:              cases.Title(language.English).String(strings.ToLower(h.Schedule.Type)),
 			Cron:              h.Schedule.Cron,
 			NextScheduledTime: strfmt.DateTime(utils.NextSchedule(h.Schedule.Cron, time.Now())),
 		},

src/server/v2.0/handler/notification_job.go

@@ -15,7 +15,6 @@ import (
 	"github.com/goharbor/harbor/src/server/v2.0/handler/model"
 	"github.com/goharbor/harbor/src/server/v2.0/models"
 	"github.com/goharbor/harbor/src/server/v2.0/restapi/operations/webhookjob"
-	operation "github.com/goharbor/harbor/src/server/v2.0/restapi/operations/webhookjob"
 )
 
 func newNotificationJobAPI() *notificationJobAPI {
@@ -72,7 +71,7 @@ func (n *notificationJobAPI) ListWebhookJobs(ctx context.Context, params webhook
 		results = append(results, model.NewNotificationJob(j).ToSwagger())
 	}
 
-	return operation.NewListWebhookJobsOK().
+	return webhookjob.NewListWebhookJobsOK().
 		WithXTotalCount(total).
 		WithLink(n.Links(ctx, params.HTTPRequest.URL, total, query.PageNumber, query.PageSize).String()).
 		WithPayload(results)

src/server/v2.0/handler/notification_policy.go

@@ -36,7 +36,6 @@ import (
 	"github.com/goharbor/harbor/src/server/v2.0/handler/model"
 	"github.com/goharbor/harbor/src/server/v2.0/models"
 	"github.com/goharbor/harbor/src/server/v2.0/restapi/operations/webhook"
-	operation "github.com/goharbor/harbor/src/server/v2.0/restapi/operations/webhook"
 )
 
 func newNotificationPolicyAPI() *notificationPolicyAPI {
@@ -102,7 +101,7 @@ func (n *notificationPolicyAPI) ListWebhookPoliciesOfProject(ctx context.Context
 		results = append(results, model.NewNotifiactionPolicy(p).ToSwagger())
 	}
 
-	return operation.NewListWebhookPoliciesOfProjectOK().
+	return webhook.NewListWebhookPoliciesOfProjectOK().
 		WithXTotalCount(total).
 		WithLink(n.Links(ctx, params.HTTPRequest.URL, total, query.PageNumber, query.PageSize).String()).
 		WithPayload(results)
@@ -137,7 +136,7 @@ func (n *notificationPolicyAPI) CreateWebhookPolicyOfProject(ctx context.Context
 	}
 
 	location := fmt.Sprintf("%s/%d", strings.TrimSuffix(params.HTTPRequest.URL.Path, "/"), id)
-	return operation.NewCreateWebhookPolicyOfProjectCreated().WithLocation(location)
+	return webhook.NewCreateWebhookPolicyOfProjectCreated().WithLocation(location)
 }
 
 func (n *notificationPolicyAPI) UpdateWebhookPolicyOfProject(ctx context.Context, params webhook.UpdateWebhookPolicyOfProjectParams) middleware.Responder {
@@ -171,7 +170,7 @@ func (n *notificationPolicyAPI) UpdateWebhookPolicyOfProject(ctx context.Context
 		return n.SendError(ctx, err)
 	}
 
-	return operation.NewUpdateWebhookPolicyOfProjectOK()
+	return webhook.NewUpdateWebhookPolicyOfProjectOK()
 }
 
 func (n *notificationPolicyAPI) DeleteWebhookPolicyOfProject(ctx context.Context, params webhook.DeleteWebhookPolicyOfProjectParams) middleware.Responder {
@@ -185,7 +184,7 @@ func (n *notificationPolicyAPI) DeleteWebhookPolicyOfProject(ctx context.Context
 	if err := n.webhookPolicyMgr.Delete(ctx, params.WebhookPolicyID); err != nil {
 		return n.SendError(ctx, err)
 	}
-	return operation.NewDeleteWebhookPolicyOfProjectOK()
+	return webhook.NewDeleteWebhookPolicyOfProjectOK()
 }
 
 func (n *notificationPolicyAPI) GetWebhookPolicyOfProject(ctx context.Context, params webhook.GetWebhookPolicyOfProjectParams) middleware.Responder {
@@ -206,7 +205,7 @@ func (n *notificationPolicyAPI) GetWebhookPolicyOfProject(ctx context.Context, p
 		return n.SendError(ctx, err)
 	}
 
-	return operation.NewGetWebhookPolicyOfProjectOK().WithPayload(model.NewNotifiactionPolicy(policy).ToSwagger())
+	return webhook.NewGetWebhookPolicyOfProjectOK().WithPayload(model.NewNotifiactionPolicy(policy).ToSwagger())
 }
 
 func (n *notificationPolicyAPI) LastTrigger(ctx context.Context, params webhook.LastTriggerParams) middleware.Responder {
@@ -234,7 +233,7 @@ func (n *notificationPolicyAPI) LastTrigger(ctx context.Context, params webhook.
 		return n.SendError(ctx, err)
 	}
 
-	return operation.NewLastTriggerOK().WithPayload(triggers)
+	return webhook.NewLastTriggerOK().WithPayload(triggers)
 }
 
 func (n *notificationPolicyAPI) GetSupportedEventTypes(ctx context.Context, params webhook.GetSupportedEventTypesParams) middleware.Responder {
@@ -252,7 +251,7 @@ func (n *notificationPolicyAPI) GetSupportedEventTypes(ctx context.Context, para
 		notificationTypes.EventType = append(notificationTypes.EventType, models.EventType(key))
 	}
 
-	return operation.NewGetSupportedEventTypesOK().WithPayload(notificationTypes)
+	return webhook.NewGetSupportedEventTypesOK().WithPayload(notificationTypes)
 }
 
 func (n *notificationPolicyAPI) getLastTriggerTimeGroupByEventType(ctx context.Context, eventType string, policyID int64) (time.Time, error) {

src/server/v2.0/handler/preheat.go

@@ -31,7 +31,6 @@ import (
 	taskCtl "github.com/goharbor/harbor/src/controller/task"
 	"github.com/goharbor/harbor/src/jobservice/job"
 	"github.com/goharbor/harbor/src/lib/errors"
-	liberrors "github.com/goharbor/harbor/src/lib/errors"
 	"github.com/goharbor/harbor/src/lib/q"
 	"github.com/goharbor/harbor/src/pkg/p2p/preheat/models/policy"
 	instanceModel "github.com/goharbor/harbor/src/pkg/p2p/preheat/models/provider"
@@ -343,7 +342,7 @@ func (api *preheatAPI) DeletePolicy(ctx context.Context, params operation.Delete
 
 	// Detecting running tasks under the policy
 	if err = detectRunningExecutions(executions); err != nil {
-		return api.SendError(ctx, liberrors.New(err).WithCode(liberrors.PreconditionCode))
+		return api.SendError(ctx, errors.New(err).WithCode(errors.PreconditionCode))
 	}
 
 	err = api.preheatCtl.DeletePolicy(ctx, policy.ID)
@@ -442,7 +441,7 @@ func (api *preheatAPI) PingInstances(ctx context.Context, params operation.PingI
 	if params.Instance.ID > 0 {
 		// by ID
 		instance, err = api.preheatCtl.GetInstance(ctx, params.Instance.ID)
-		if liberrors.IsNotFoundErr(err) {
+		if errors.IsNotFoundErr(err) {
 			return operation.NewPingInstancesNotFound()
 		}
 		if err != nil {

src/server/v2.0/handler/purge.go

@@ -36,7 +36,6 @@ import (
 	"github.com/goharbor/harbor/src/server/v2.0/handler/model"
 	"github.com/goharbor/harbor/src/server/v2.0/models"
 	"github.com/goharbor/harbor/src/server/v2.0/restapi/operations/purge"
-	operation "github.com/goharbor/harbor/src/server/v2.0/restapi/operations/purge"
 )
 
 type purgeAPI struct {
@@ -189,7 +188,7 @@ func (p *purgeAPI) GetPurgeHistory(ctx context.Context, params purge.GetPurgeHis
 		results = append(results, h.ToSwagger())
 	}
 
-	return operation.NewGetPurgeHistoryOK().
+	return purge.NewGetPurgeHistoryOK().
 		WithXTotalCount(total).
 		WithLink(p.Links(ctx, params.HTTPRequest.URL, total, query.PageNumber, query.PageSize).String()).
 		WithPayload(results)
@@ -226,7 +225,7 @@ func (p *purgeAPI) GetPurgeJob(ctx context.Context, params purge.GetPurgeJobPara
 		UpdateTime:   exec.UpdateTime,
 	}
 
-	return operation.NewGetPurgeJobOK().WithPayload(res.ToSwagger())
+	return purge.NewGetPurgeJobOK().WithPayload(res.ToSwagger())
 }
 
 func (p *purgeAPI) GetPurgeJobLog(ctx context.Context, params purge.GetPurgeJobLogParams) middleware.Responder {
@@ -249,7 +248,7 @@ func (p *purgeAPI) GetPurgeJobLog(ctx context.Context, params purge.GetPurgeJobL
 	if err != nil {
 		return p.SendError(ctx, err)
 	}
-	return operation.NewGetPurgeJobLogOK().WithPayload(string(taskLog))
+	return purge.NewGetPurgeJobLogOK().WithPayload(string(taskLog))
 }
 
 func (p *purgeAPI) GetPurgeSchedule(ctx context.Context, params purge.GetPurgeScheduleParams) middleware.Responder {
@@ -258,7 +257,7 @@ func (p *purgeAPI) GetPurgeSchedule(ctx context.Context, params purge.GetPurgeSc
 	}
 	sch, err := p.schedulerCtl.Get(ctx, pg.VendorType)
 	if errors.IsNotFoundErr(err) {
-		return operation.NewGetPurgeScheduleOK()
+		return purge.NewGetPurgeScheduleOK()
 	}
 	if err != nil {
 		return p.SendError(ctx, err)
@@ -278,7 +277,7 @@ func (p *purgeAPI) GetPurgeSchedule(ctx context.Context, params purge.GetPurgeSc
 		CreationTime: strfmt.DateTime(sch.CreationTime),
 		UpdateTime:   strfmt.DateTime(sch.UpdateTime),
 	}
-	return operation.NewGetPurgeScheduleOK().WithPayload(execHistory)
+	return purge.NewGetPurgeScheduleOK().WithPayload(execHistory)
 }
 
 func (p *purgeAPI) UpdatePurgeSchedule(ctx context.Context, params purge.UpdatePurgeScheduleParams) middleware.Responder {
@@ -292,10 +291,10 @@ func (p *purgeAPI) UpdatePurgeSchedule(ctx context.Context, params purge.UpdateP
 	if err != nil {
 		return p.SendError(ctx, err)
 	}
-	return operation.NewUpdatePurgeScheduleOK()
+	return purge.NewUpdatePurgeScheduleOK()
 }
 
-func verifyUpdateRequest(params operation.UpdatePurgeScheduleParams) error {
+func verifyUpdateRequest(params purge.UpdatePurgeScheduleParams) error {
 	if params.Schedule == nil || params.Schedule.Schedule == nil {
 		return errors.BadRequestError(fmt.Errorf("schedule cann't be empty"))
 	}
@@ -326,12 +325,12 @@ func (p *purgeAPI) createSchedule(ctx context.Context, vendorType string, cronTy
 	return nil
 }
 
-func (p *purgeAPI) StopPurge(ctx context.Context, params operation.StopPurgeParams) middleware.Responder {
+func (p *purgeAPI) StopPurge(ctx context.Context, params purge.StopPurgeParams) middleware.Responder {
 	if err := p.RequireSystemAccess(ctx, rbac.ActionStop, rbac.ResourcePurgeAuditLog); err != nil {
 		return p.SendError(ctx, err)
 	}
 	if err := p.purgeCtr.Stop(ctx, params.PurgeID); err != nil {
 		return p.SendError(ctx, err)
 	}
-	return operation.NewStopPurgeOK()
+	return purge.NewStopPurgeOK()
 }

src/server/v2.0/handler/scan_all.go

@@ -20,6 +20,8 @@ import (
 	"strings"
 
 	"github.com/go-openapi/runtime/middleware"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 
 	"github.com/goharbor/harbor/src/common/rbac"
 	"github.com/goharbor/harbor/src/controller/scan"
@@ -256,7 +258,7 @@ func (s *scanAllAPI) getMetrics(ctx context.Context, trigger ...string) (*models
 		}
 
 		sts.Ongoing = !job.Status(execution.Status).Final() || sts.Total != sts.Completed
-		sts.Trigger = strings.Title(strings.ToLower(execution.Trigger))
+		sts.Trigger = cases.Title(language.English).String(strings.ToLower(execution.Trigger))
 	}
 
 	return sts, nil

tests/ci/ut_install.sh

@@ -16,7 +16,7 @@ go get github.com/mattn/goveralls
 go get -u github.com/client9/misspell/cmd/misspell
 # binary will be $(go env GOPATH)/bin/golangci-lint
 # go install/go get installation aren't guaranteed to work. We recommend using binary installation.
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.45.2
+curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.50.1
 sudo service postgresql stop || echo no postgresql need to be stopped
 sleep 2