From 64e61c0d110f31064970a5035b67e43d719d2774 Mon Sep 17 00:00:00 2001 From: Wang Yan Date: Mon, 11 Jan 2021 11:26:05 +0800 Subject: [PATCH] fix robot cannot update expirsat (#13944) Signed-off-by: Wang Yan --- src/controller/robot/controller.go | 2 +- src/controller/robot/controller_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/controller/robot/controller.go b/src/controller/robot/controller.go index b5f9fafe3..b449112f3 100644 --- a/src/controller/robot/controller.go +++ b/src/controller/robot/controller.go @@ -136,7 +136,7 @@ func (d *controller) Update(ctx context.Context, r *Robot, option *Option) error if r == nil { return errors.New("cannot update a nil robot").WithCode(errors.BadRequestCode) } - if err := d.robotMgr.Update(ctx, &r.Robot, "secret", "description", "disabled", "duration"); err != nil { + if err := d.robotMgr.Update(ctx, &r.Robot, "secret", "description", "disabled", "duration", "expiresat"); err != nil { return err } // update the permission diff --git a/src/controller/robot/controller_test.go b/src/controller/robot/controller_test.go index e49205736..f7912dbaf 100644 --- a/src/controller/robot/controller_test.go +++ b/src/controller/robot/controller_test.go @@ -162,7 +162,7 @@ func (suite *ControllerTestSuite) TestUpdate() { } config.InitWithSettings(conf) - robotMgr.On("Update", mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil) + robotMgr.On("Update", mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil) projectMgr.On("Get", mock.Anything, mock.Anything).Return(&models.Project{ProjectID: 1, Name: "library"}, nil) rbacMgr.On("DeletePermissionsByRole", mock.Anything, mock.Anything, mock.Anything).Return(nil)