Upstream
/
harbor
mirror of https://github.com/goharbor/harbor.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: 404 for artifacts requested for repository which does not exist 

Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
This commit is contained in:
Maksym Trofimenko 2022-09-12 12:23:19 +02:00 committed by Maksym Trofimenko
parent 522f96b5cf
commit 6ae90996b9
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/server/v2.0/handler/artifact.go
View File

@ -85,13 +85,22 @@ func (a *artifactAPI) ListArtifacts(ctx context.Context, params operation.ListAr
if err := a.RequireProjectAccess(ctx, params.ProjectName, rbac.ActionList, rbac.ResourceArtifact); err != nil {
return a.SendError(ctx, err)
}
repositoryName := fmt.Sprintf("%s/%s", params.ProjectName, params.RepositoryName)
_, err := a.repoCtl.GetByName(ctx, repositoryName)
if err != nil {
switch {
case errors.IsErr(err, errors.NotFoundCode):
return operation.NewListArtifactsNotFound().WithPayload(&models.Errors{Errors: []*models.Error{{Message: "Repository not found"}}})
}
return a.SendError(ctx, err)
}
// set query
query, err := a.BuildQuery(ctx, params.Q, params.Sort, params.Page, params.PageSize)
if err != nil {
return a.SendError(ctx, err)
}
query.Keywords["RepositoryName"] = fmt.Sprintf("%s/%s", params.ProjectName, params.RepositoryName)
query.Keywords["RepositoryName"] = repositoryName
// set option
option := option(params.WithTag, params.WithImmutableStatus,