Update the registry client to support pulling public images from docker hub without login

Only add the authentication info when the username is provided to support pulling public images from docker hub without login

Signed-off-by: Wenkai Yin <yinw@vmware.com>
This commit is contained in:
Wenkai Yin 2019-04-01 19:15:07 +08:00
parent df2ae63308
commit 74efee569e

View File

@ -38,7 +38,12 @@ func NewBasicAuthCredential(username, password string) Credential {
} }
func (b *basicAuthCredential) AddAuthorization(req *http.Request) { func (b *basicAuthCredential) AddAuthorization(req *http.Request) {
req.SetBasicAuth(b.username, b.password) // only add the authentication info when the username isn't empty
// the logic is needed for requesting resources from docker hub's
// public repositories
if len(b.username) > 0 {
req.SetBasicAuth(b.username, b.password)
}
} }
// implement github.com/goharbor/harbor/src/common/http/modifier.Modifier // implement github.com/goharbor/harbor/src/common/http/modifier.Modifier