Merge pull request #396 from ywk253100/bug_fix_for_access_log

create a new registry client when refreshing cache

service/cache/cache.go

@@ -16,7 +16,6 @@
 package cache
 
 import (
-	"errors"
 	"os"
 	"time"
 
@@ -29,11 +28,9 @@ import (
 
 var (
 	// Cache is the global cache in system.
-	Cache          cache.Cache
-	endpoint       string
-	insecure       bool
-	username       string
-	registryClient *registry.Registry
+	Cache    cache.Cache
+	endpoint string
+	username string
 )
 
 const catalogKey string = "catalog"
@@ -46,26 +43,19 @@ func init() {
 	}
 
 	endpoint = os.Getenv("REGISTRY_URL")
-	// TODO read variable from config file
-	insecure = true
 	username = "admin"
-	registryClient, err = NewRegistryClient(endpoint, insecure, username,
-		"registry", "catalog", "*")
-	if err != nil {
-		log.Errorf("failed to create registry client: %v", err)
-		return
-	}
 }
 
 // RefreshCatalogCache calls registry's API to get repository list and write it to cache.
 func RefreshCatalogCache() error {
 	log.Debug("refreshing catalog cache...")
 
-	if registryClient == nil {
-		return errors.New("registry client is nil")
+	registryClient, err := NewRegistryClient(endpoint, true, username,
+		"registry", "catalog", "*")
+	if err != nil {
+		return err
 	}
 
-	var err error
 	rs, err := registryClient.Catalog()
 	if err != nil {
 		return err
@@ -74,7 +64,7 @@ func RefreshCatalogCache() error {
 	repos := []string{}
 
 	for _, repo := range rs {
-		rc, err := NewRepositoryClient(endpoint, insecure, username,
+		rc, err := NewRepositoryClient(endpoint, true, username,
 			repo, "repository", repo, "pull", "push", "*")
 		if err != nil {
 			log.Errorf("error occurred while initializing repository client used by cache: %s %v", repo, err)