diff --git a/src/replication/adapter/helmhub/adapter_test.go b/src/replication/adapter/helmhub/adapter_test.go index ee22fc6dd..75aa1bbff 100644 --- a/src/replication/adapter/helmhub/adapter_test.go +++ b/src/replication/adapter/helmhub/adapter_test.go @@ -37,7 +37,12 @@ func TestPrepareForPush(t *testing.T) { } func TestHealthCheck(t *testing.T) { - adapter, _ := newAdapter(nil) + registry := &model.Registry{ + Type: model.RegistryTypeHelmHub, + URL: baseURL, + Insecure: true, + } + adapter, _ := newAdapter(registry) status, err := adapter.HealthCheck() require.Equal(t, model.Healthy, string(status)) require.Nil(t, err) diff --git a/src/replication/adapter/helmhub/chart_registry_test.go b/src/replication/adapter/helmhub/chart_registry_test.go index cabd9fd9c..14d6326df 100644 --- a/src/replication/adapter/helmhub/chart_registry_test.go +++ b/src/replication/adapter/helmhub/chart_registry_test.go @@ -23,7 +23,12 @@ import ( ) func TestFetchCharts(t *testing.T) { - adapter, err := newAdapter(nil) + registry := &model.Registry{ + Type: model.RegistryTypeHelmHub, + URL: baseURL, + Insecure: false, + } + adapter, err := newAdapter(registry) require.Nil(t, err) // filter 1 filters := []*model.Filter{ @@ -55,7 +60,12 @@ func TestFetchCharts(t *testing.T) { } func TestChartExist(t *testing.T) { - adapter, err := newAdapter(nil) + registry := &model.Registry{ + Type: model.RegistryTypeHelmHub, + URL: baseURL, + Insecure: false, + } + adapter, err := newAdapter(registry) require.Nil(t, err) exist, err := adapter.ChartExist("harbor/harbor", "1.0.0") require.Nil(t, err) @@ -63,7 +73,12 @@ func TestChartExist(t *testing.T) { } func TestChartExist2(t *testing.T) { - adapter, err := newAdapter(nil) + registry := &model.Registry{ + Type: model.RegistryTypeHelmHub, + URL: baseURL, + Insecure: false, + } + adapter, err := newAdapter(registry) require.Nil(t, err) exist, err := adapter.ChartExist("goharbor/harbor", "1.0.0") require.Nil(t, err) @@ -75,7 +90,12 @@ func TestChartExist2(t *testing.T) { } func TestDownloadChart(t *testing.T) { - adapter, err := newAdapter(nil) + registry := &model.Registry{ + Type: model.RegistryTypeHelmHub, + URL: baseURL, + Insecure: false, + } + adapter, err := newAdapter(registry) require.Nil(t, err) _, err = adapter.DownloadChart("harbor/harbor", "1.0.0") require.Nil(t, err) diff --git a/src/replication/adapter/helmhub/client.go b/src/replication/adapter/helmhub/client.go index 6981b2187..52af39e34 100644 --- a/src/replication/adapter/helmhub/client.go +++ b/src/replication/adapter/helmhub/client.go @@ -22,7 +22,7 @@ type Client struct { func NewClient(registry *model.Registry) *Client { return &Client{ client: &http.Client{ - Transport: util.GetHTTPTransport(false), + Transport: util.GetHTTPTransport(registry.Insecure), }, } }