From 7dc452ccabf1e798343da4cc04c5ba4d6c4c668c Mon Sep 17 00:00:00 2001 From: Iceber Gu Date: Tue, 6 Dec 2022 15:59:37 +0800 Subject: [PATCH] controller/robot: use global regexp vars (#17915) Signed-off-by: Iceber Gu Signed-off-by: Iceber Gu --- src/controller/robot/controller.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/controller/robot/controller.go b/src/controller/robot/controller.go index c3a80a613..865bed5d0 100644 --- a/src/controller/robot/controller.go +++ b/src/controller/robot/controller.go @@ -395,12 +395,12 @@ func CreateSec(salt ...string) (string, string, string, error) { return secret, pwd, saltTmp, nil } +var ( + hasLower = regexp.MustCompile(`[a-z]`) + hasUpper = regexp.MustCompile(`[A-Z]`) + hasNumber = regexp.MustCompile(`\d`) +) + func IsValidSec(secret string) bool { - hasLower := regexp.MustCompile(`[a-z]`) - hasUpper := regexp.MustCompile(`[A-Z]`) - hasNumber := regexp.MustCompile(`\d`) - if len(secret) >= 8 && hasLower.MatchString(secret) && hasUpper.MatchString(secret) && hasNumber.MatchString(secret) { - return true - } - return false + return len(secret) >= 8 && hasLower.MatchString(secret) && hasUpper.MatchString(secret) && hasNumber.MatchString(secret) }