From 86d446ce8159f87bf91f022ab59ace905ee4e321 Mon Sep 17 00:00:00 2001
From: He Weiwei <hweiwei@vmware.com>
Date: Tue, 31 Mar 2020 10:33:18 +0800
Subject: [PATCH] fix(log): change log level from warning to debug when
 unescape path params (#11359)

Closes #11186

Signed-off-by: He Weiwei <hweiwei@vmware.com>
---
 src/server/v2.0/handler/util.go      | 6 +++---
 src/server/v2.0/handler/util_test.go | 3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/server/v2.0/handler/util.go b/src/server/v2.0/handler/util.go
index 27e4dc979..954af7866 100644
--- a/src/server/v2.0/handler/util.go
+++ b/src/server/v2.0/handler/util.go
@@ -80,12 +80,12 @@ func unescapePathParams(params interface{}, fieldNames ...string) error {
 	for _, name := range fieldNames {
 		field := val.FieldByName(name)
 		if !field.IsValid() {
-			log.Warningf("field %s not found in params %v", name, params)
+			log.Debugf("field %s not found in %s", name, val.Type().Name())
 			continue
 		}
 
 		if !field.CanSet() {
-			log.Warningf("field %s can not be changed in params %v", name, params)
+			log.Debugf("field %s can not be changed in %s", name, val.Type().Name())
 			continue
 		}
 
@@ -97,7 +97,7 @@ func unescapePathParams(params interface{}, fieldNames ...string) error {
 			}
 			field.SetString(v)
 		default:
-			log.Warningf("field %s can not be unescaped in params %v", name, params)
+			log.Debugf("field %s can not be unescaped in %s", name, val.Type().Name())
 		}
 	}
 
diff --git a/src/server/v2.0/handler/util_test.go b/src/server/v2.0/handler/util_test.go
index f737a87ed..16c508586 100644
--- a/src/server/v2.0/handler/util_test.go
+++ b/src/server/v2.0/handler/util_test.go
@@ -20,6 +20,7 @@ import (
 
 func Test_unescapePathParams(t *testing.T) {
 	type Params struct {
+		ProjectID      int64
 		ProjectName    string
 		RepositoryName string
 	}
@@ -38,6 +39,8 @@ func Test_unescapePathParams(t *testing.T) {
 		{"non ptr", args{str, []string{"RepositoryName"}}, true},
 		{"non struct", args{&str, []string{"RepositoryName"}}, true},
 		{"ptr of struct", args{&Params{}, []string{"RepositoryName"}}, false},
+		{"non string filed", args{&Params{}, []string{"ProjectID"}}, false},
+		{"filed not found", args{&Params{}, []string{"Name"}}, false},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {