Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-11-26 12:15:20 +01:00
Code Issues Projects Releases Wiki Activity

Pass internal core URL as source in replication

Browse Source 
Currently, we pass the external URL as the source registry and set insecure as true in replication, this causes security issue. This commit replaces the URL with the internal one and set insecure to false. Fixes #6109.

Signed-off-by: Wenkai Yin <yinw@vmware.com>
This commit is contained in:
Wenkai Yin 2018-11-01 17:13:38 +08:00
parent 4894d1f46f
commit 88aa413fe6
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/replication/replicator/replicator.go
View File

@ -89,17 +89,13 @@ func (d *DefaultReplicator) Replicate(replication *Replication) error {
}
if operation == common_models.RepOpTransfer {
url, err := config.ExtEndpoint()
if err != nil {
return err
}
job.Name = common_job.ImageTransfer
job.Parameters = map[string]interface{}{
"repository": repository,
"tags": tags,
"src_registry_url": url,
"src_registry_insecure": true,
// "src_token_service_url":"",
"src_registry_url": config.InternalCoreURL(),
"src_registry_insecure": false,
"src_token_service_url": config.InternalTokenServiceEndpoint(),
"dst_registry_url": target.URL,
"dst_registry_insecure": target.Insecure,
"dst_registry_username": target.Username,