From 92aa8ac15b17bbd2c64f39d652cd75d456d6a3a0 Mon Sep 17 00:00:00 2001 From: Wenkai Yin Date: Wed, 3 May 2017 18:48:19 +0800 Subject: [PATCH] implement PMS based on database --- src/ui/pms/db/service.go | 95 ++++++++++++++++++++++++++++++ src/ui/pms/db/service_test.go | 106 ++++++++++++++++++++++++++++++++++ 2 files changed, 201 insertions(+) create mode 100644 src/ui/pms/db/service_test.go diff --git a/src/ui/pms/db/service.go b/src/ui/pms/db/service.go index 0086c5d315..8d1055a06f 100644 --- a/src/ui/pms/db/service.go +++ b/src/ui/pms/db/service.go @@ -13,3 +13,98 @@ // limitations under the License. package db + +import ( + "github.com/vmware/harbor/src/common" + "github.com/vmware/harbor/src/common/dao" + "github.com/vmware/harbor/src/common/models" + "github.com/vmware/harbor/src/common/utils/log" +) + +// PMS implements pms.PMS interface based on database +type PMS struct{} + +// IsPublic returns whether the project is public or not +func (p *PMS) IsPublic(projectIDOrName interface{}) bool { + var project *models.Project + var err error + switch projectIDOrName.(type) { + case string: + name := projectIDOrName.(string) + project, err = dao.GetProjectByName(name) + if err != nil { + log.Errorf("failed to get project %s: %v", name, err) + } + case int64: + id := projectIDOrName.(int64) + project, err = dao.GetProjectByID(id) + if err != nil { + log.Errorf("failed to get project %d: %v", id, err) + } + default: + log.Errorf("unsupported type of %v, must be string or int64", projectIDOrName) + } + + if project == nil { + return false + } + + return project.Public == 1 +} + +// GetRoles return a role list which contains the user's roles to the project +func (p *PMS) GetRoles(username string, projectIDOrName interface{}) []int { + roles := []int{} + + user, err := dao.GetUser(models.User{ + Username: username, + }) + if err != nil { + log.Errorf("failed to get user %s: %v", username, err) + return roles + } + if user == nil { + return roles + } + + var projectID int64 + switch projectIDOrName.(type) { + case string: + name := projectIDOrName.(string) + project, err := dao.GetProjectByName(name) + if err != nil { + log.Errorf("failed to get project %s: %v", name, err) + return roles + } + + if project == nil { + return roles + } + projectID = project.ProjectID + case int64: + projectID = projectIDOrName.(int64) + default: + log.Errorf("unsupported type of %v, must be string or int64", projectIDOrName) + return roles + } + + roleList, err := dao.GetUserProjectRoles(user.UserID, projectID) + if err != nil { + log.Errorf("failed to get roles for user %d to project %d: %v", + user.UserID, projectID, err) + return roles + } + + for _, role := range roleList { + switch role.RoleCode { + case "MDRWS": + roles = append(roles, common.RoleProjectAdmin) + case "RWS": + roles = append(roles, common.RoleDeveloper) + case "RS": + roles = append(roles, common.RoleGuest) + } + } + + return roles +} diff --git a/src/ui/pms/db/service_test.go b/src/ui/pms/db/service_test.go new file mode 100644 index 0000000000..37ce2d9f86 --- /dev/null +++ b/src/ui/pms/db/service_test.go @@ -0,0 +1,106 @@ +// Copyright (c) 2017 VMware, Inc. All Rights Reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package db + +import ( + "os" + "strconv" + "testing" + + "github.com/stretchr/testify/assert" + "github.com/vmware/harbor/src/common" + "github.com/vmware/harbor/src/common/dao" + "github.com/vmware/harbor/src/common/models" + "github.com/vmware/harbor/src/common/utils/log" +) + +func TestMain(m *testing.M) { + dbHost := os.Getenv("MYSQL_HOST") + if len(dbHost) == 0 { + log.Fatalf("environment variable MYSQL_HOST is not set") + } + dbPortStr := os.Getenv("MYSQL_PORT") + if len(dbPortStr) == 0 { + log.Fatalf("environment variable MYSQL_PORT is not set") + } + dbPort, err := strconv.Atoi(dbPortStr) + if err != nil { + log.Fatalf("invalid MYSQL_PORT: %v", err) + } + dbUser := os.Getenv("MYSQL_USR") + if len(dbUser) == 0 { + log.Fatalf("environment variable MYSQL_USR is not set") + } + + dbPassword := os.Getenv("MYSQL_PWD") + dbDatabase := os.Getenv("MYSQL_DATABASE") + if len(dbDatabase) == 0 { + log.Fatalf("environment variable MYSQL_DATABASE is not set") + } + + database := &models.Database{ + Type: "mysql", + MySQL: &models.MySQL{ + Host: dbHost, + Port: dbPort, + Username: dbUser, + Password: dbPassword, + Database: dbDatabase, + }, + } + + log.Infof("MYSQL_HOST: %s, MYSQL_USR: %s, MYSQL_PORT: %d, MYSQL_PWD: %s\n", dbHost, dbUser, dbPort, dbPassword) + + if err := dao.InitDatabase(database); err != nil { + log.Fatalf("failed to initialize database: %v", err) + } + + os.Exit(m.Run()) +} + +func TestIsPublic(t *testing.T) { + pms := &PMS{} + // project name + assert.True(t, pms.IsPublic("library")) + // project ID + assert.True(t, pms.IsPublic(int64(1))) + // non exist project + assert.False(t, pms.IsPublic("non_exist_project")) + // invalid type + assert.False(t, pms.IsPublic(1)) +} + +func TestGetRoles(t *testing.T) { + pms := &PMS{} + + // non exist user + assert.Equal(t, []int{}, + pms.GetRoles("non_exist_user", int64(1))) + + // project ID + assert.Equal(t, []int{common.RoleProjectAdmin}, + pms.GetRoles("admin", int64(1))) + + // project name + assert.Equal(t, []int{common.RoleProjectAdmin}, + pms.GetRoles("admin", "library")) + + // non exist project + assert.Equal(t, []int{}, + pms.GetRoles("admin", "non_exist_project")) + + // invalid type + assert.Equal(t, []int{}, pms.GetRoles("admin", 1)) +}