From 8e779fc9bc4ff38251f728f8a95c4d478eb4a024 Mon Sep 17 00:00:00 2001
From: sshijun <sshijun@vmware.com>
Date: Tue, 3 Dec 2019 15:55:47 +0800
Subject: [PATCH] Add more UI UT

Signed-off-by: sshijun <sshijun@vmware.com>
---
 .../replication-config.component.spec.ts      | 32 +++++++
 .../system/system-settings.component.html     |  2 +-
 .../system/system-settings.component.spec.ts  | 86 +++++++++++++++++++
 3 files changed, 119 insertions(+), 1 deletion(-)
 create mode 100644 src/portal/src/lib/components/config/replication/replication-config.component.spec.ts
 create mode 100644 src/portal/src/lib/components/config/system/system-settings.component.spec.ts

diff --git a/src/portal/src/lib/components/config/replication/replication-config.component.spec.ts b/src/portal/src/lib/components/config/replication/replication-config.component.spec.ts
new file mode 100644
index 000000000..01dff3f73
--- /dev/null
+++ b/src/portal/src/lib/components/config/replication/replication-config.component.spec.ts
@@ -0,0 +1,32 @@
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ReplicationConfigComponent } from "./replication-config.component";
+import { HarborLibraryModule } from "../../../harbor-library.module";
+import { IServiceConfig, SERVICE_CONFIG } from "../../../entities/service.config";
+import { Configuration } from "../config";
+describe('ReplicationConfigComponent', () => {
+  let component: ReplicationConfigComponent;
+  let fixture: ComponentFixture<ReplicationConfigComponent>;
+  const config: IServiceConfig = {
+    baseEndpoint: "/api/testing"
+  };
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [
+          HarborLibraryModule
+      ],
+       providers: [
+           { provide: SERVICE_CONFIG, useValue: config }
+       ]
+    });
+  });
+  beforeEach(() => {
+    fixture = TestBed.createComponent(ReplicationConfigComponent);
+    component = fixture.componentInstance;
+    component.config = new Configuration();
+    fixture.detectChanges();
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+});
diff --git a/src/portal/src/lib/components/config/system/system-settings.component.html b/src/portal/src/lib/components/config/system/system-settings.component.html
index 23ef9a0a5..773a1a2a6 100644
--- a/src/portal/src/lib/components/config/system/system-settings.component.html
+++ b/src/portal/src/lib/components/config/system/system-settings.component.html
@@ -168,7 +168,7 @@
     <button type="button" id="config_system_save" class="btn btn-primary" (click)="save()"
         [disabled]="(!isValid() || !hasChanges()) && (!hasWhitelistChanged) || inProgress">{{'BUTTON.SAVE'
         | translate}}</button>
-    <button type="button" class="btn btn-outline" (click)="cancel()"
+    <button type="button" id="config_system_cancel" class="btn btn-outline" (click)="cancel()"
         [disabled]="(!isValid() || !hasChanges()) && (!hasWhitelistChanged) || inProgress">{{'BUTTON.CANCEL'
         | translate}}</button>
 </div>
diff --git a/src/portal/src/lib/components/config/system/system-settings.component.spec.ts b/src/portal/src/lib/components/config/system/system-settings.component.spec.ts
new file mode 100644
index 000000000..35f413be1
--- /dev/null
+++ b/src/portal/src/lib/components/config/system/system-settings.component.spec.ts
@@ -0,0 +1,86 @@
+import { ComponentFixture, ComponentFixtureAutoDetect, TestBed } from '@angular/core/testing';
+import { HarborLibraryModule } from "../../../harbor-library.module";
+import { IServiceConfig, SERVICE_CONFIG } from "../../../entities/service.config";
+import { SystemSettingsComponent } from "./system-settings.component";
+import { ConfigurationService, SystemInfoService } from "../../../services";
+import { ErrorHandler } from "../../../utils/error-handler";
+import { of } from "rxjs";
+import { StringValueItem } from "../config";
+import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
+describe('SystemSettingsComponent', () => {
+  let component: SystemSettingsComponent;
+  let fixture: ComponentFixture<SystemSettingsComponent>;
+  const config: IServiceConfig = {
+    baseEndpoint: "/api/testing"
+  };
+  const mockedWhitelist = {
+    id: 1,
+    project_id: 1,
+    expires_at: null,
+    items: [
+      {cve_id: 'CVE-2019-1234'}
+    ]
+  };
+  const fakedSystemInfoService = {
+    getSystemWhitelist() {
+       return of(mockedWhitelist);
+    },
+    getSystemInfo() {
+       return of({});
+    },
+    updateSystemWhitelist() {
+      return of(true);
+    }
+  };
+  const fakedErrorHandler = {
+    info() {
+      return null;
+    }
+  };
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [
+          HarborLibraryModule,
+          BrowserAnimationsModule
+      ],
+       providers: [
+           ConfigurationService,
+           { provide: ErrorHandler, useValue: fakedErrorHandler },
+           { provide: SystemInfoService, useValue: fakedSystemInfoService },
+           { provide: SERVICE_CONFIG, useValue: config },
+             // open auto detect
+           { provide: ComponentFixtureAutoDetect, useValue: true }
+       ]
+    });
+  });
+  beforeEach(() => {
+    fixture = TestBed.createComponent(SystemSettingsComponent);
+    component = fixture.componentInstance;
+    component.config.auth_mode = new StringValueItem("db_auth",  false );
+    fixture.detectChanges();
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+  it('cancel button should works', () => {
+    component.systemWhitelist.items.push({cve_id: 'CVE-2019-456'});
+    const readOnly: HTMLElement = fixture.nativeElement.querySelector('#repoReadOnly');
+    readOnly.click();
+    fixture.detectChanges();
+    const cancel: HTMLButtonElement = fixture.nativeElement.querySelector('#config_system_cancel');
+    cancel.click();
+    fixture.detectChanges();
+    expect(component.confirmationDlg.opened).toBeTruthy();
+  });
+  it('save button should works', () => {
+    component.systemWhitelist.items[0].cve_id = 'CVE-2019-789';
+    const readOnly: HTMLElement = fixture.nativeElement.querySelector('#repoReadOnly');
+    readOnly.click();
+    fixture.detectChanges();
+    const save: HTMLButtonElement = fixture.nativeElement.querySelector('#config_system_save');
+    save.click();
+    fixture.detectChanges();
+    expect(component.systemWhitelistOrigin.items[0].cve_id).toEqual('CVE-2019-789');
+  });
+});