Upstream
/
harbor
mirror of https://github.com/goharbor/harbor.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix typos in common.sh (#18151) 

* Fix typos in common.sh

Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>

* Add a new line at the end of make/common.sh

Co-authored-by: Orlix <OrlinVasilev@users.noreply.github.com>
Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>

---------

Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Co-authored-by: Orlix <OrlinVasilev@users.noreply.github.com>
This commit is contained in:
Maxi_Mega 2023-04-17 10:56:19 +02:00 committed by GitHub
parent eec5342490
commit 96bc43f7ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
make/common.sh
View File

@ -50,11 +50,11 @@ set -e
function check_golang {
if ! go version &> /dev/null
then
warn "No golang package in your enviroment. You should use golang docker image build binary."
warn "No golang package in your environment. You should use golang docker image build binary."
return
fi
# docker has been installed and check its version
# golang has been installed and check its version
if [[ $(go version) =~ (([0-9]+)\.([0-9]+)([\.0-9]*)) ]]
then
golang_version=${BASH_REMATCH[1]}
@ -133,4 +133,6 @@ function check_dockercompose {
error "Failed to parse docker-compose version."
exit 1
fi
}
}