Upstream
/
harbor
mirror of https://github.com/goharbor/harbor.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add id column to data_migration table 

Add id column to data_migration table and add logic to make sure there is only one data version record

Signed-off-by: Wenkai Yin <yinw@vmware.com>
This commit is contained in:
Wenkai Yin 2020-08-20 17:43:15 +08:00
parent 08a4d8efd2
commit 975ef193dd
2 changed files with 28 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
make/migrations/postgresql/0040_2.1.0_schema.up.sql
View File

@ -117,7 +117,10 @@ ALTER TABLE schedule DROP COLUMN IF EXISTS status;
UPDATE registry SET type = 'quay' WHERE type = 'quay-io';
CREATE TABLE IF NOT EXISTS data_migrations (
version int
id SERIAL PRIMARY KEY NOT NULL,
version int,
creation_time timestamp default CURRENT_TIMESTAMP,
update_time timestamp default CURRENT_TIMESTAMP
);
INSERT INTO data_migrations (version) VALUES (
CASE

29
src/migration/migration.go
View File

@ -23,6 +23,7 @@ import (
"github.com/goharbor/harbor/src/lib/log"
"github.com/goharbor/harbor/src/lib/orm"
"github.com/golang-migrate/migrate/v4"
"time"
)
const (
@ -66,7 +67,11 @@ func AbstractArtifactData() error {
log.Info("No need to abstract artifact data. Skip")
return nil
}
return abstractArtData(ctx)
if err = abstractArtData(ctx); err != nil {
return err
}
log.Info("Abstract artifact data to DB done")
return nil
}
// Migrate the database schema and abstract artifact data
@ -80,16 +85,30 @@ func Migrate(database *models.Database) error {
return nil
}
type dataVersion struct {
ID int64
Version int
CreationTime time.Time
UpdateTime time.Time
}
func getDataVersion(ctx context.Context) (int, error) {
ormer, err := orm.FromContext(ctx)
if err != nil {
return 0, err
}
var version int
if err = ormer.Raw("select version from data_migrations").QueryRow(&version); err != nil {
versions := []*dataVersion{}
if _, err = ormer.Raw("select * from data_migrations order by id").QueryRows(&versions); err != nil {
return 0, err
}
return version, nil
n := len(versions)
if n == 0 {
return 0, nil
}
if n > 1 {
return 0, fmt.Errorf("there should be only one record in the table data_migrations, but found %d records", n)
}
return versions[0].Version, nil
}
func setDataVersion(ctx context.Context, version int) error {
@ -97,6 +116,6 @@ func setDataVersion(ctx context.Context, version int) error {
if err != nil {
return err
}
_, err = ormer.Raw("update data_migrations set version=?", version).Exec()
_, err = ormer.Raw("update data_migrations set version=?, update_time=?", version, time.Now()).Exec()
return err
}