From 9c6e49c5ddcb593f5c8440fb0715b50a333577fb Mon Sep 17 00:00:00 2001
From: kunw <kunw@vmware.com>
Date: Tue, 11 Apr 2017 11:42:56 +0800
Subject: [PATCH] Update endpoint interaction of UI.

---
 .../create-edit-destination.component.html    |  2 +-
 .../create-edit-destination.component.ts      | 46 ++++++++++++-------
 .../app/replication/replication.service.ts    | 15 +++---
 3 files changed, 37 insertions(+), 26 deletions(-)

diff --git a/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.html b/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.html
index e8a5bbe72..1d9572c7d 100644
--- a/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.html
+++ b/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.html
@@ -14,7 +14,7 @@
         <div class="form-group">
           <label for="destination_name" class="col-md-4 form-group-label-override">{{ 'DESTINATION.NAME' | translate }}<span style="color: red">*</span></label>
           <label class="col-md-8" for="destination_name" aria-haspopup="true" role="tooltip" [class.invalid]="targetName.errors && (targetName.dirty || targetName.touched)" [class.valid]="targetName.valid" class="tooltip tooltip-validation tooltip-sm tooltip-bottom-left">
-            <input type="text" id="destination_name" [disabled]="testOngoing" [readonly]="!editable" [(ngModel)]="target.name" name="targetName" size="20" #targetName="ngModel" required  (keyup)="clearPassword($event)"> 
+            <input type="text" id="destination_name" [disabled]="testOngoing" [readonly]="!editable" [(ngModel)]="target.name" name="targetName" size="20" #targetName="ngModel" required  (keyup)="changedTargetName($event)"> 
             <span class="tooltip-content" *ngIf="targetName.errors && targetName.errors.required && (targetName.dirty || targetName.touched)">
               {{ 'DESTINATION.NAME_IS_REQUIRED' | translate }}
             </span>
diff --git a/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.ts b/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.ts
index b6941c0ad..acf72aad1 100644
--- a/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.ts
+++ b/src/ui_ng/src/app/replication/create-edit-destination/create-edit-destination.component.ts
@@ -44,7 +44,8 @@ export class CreateEditDestinationComponent implements AfterViewChecked {
 
   hasChanged: boolean;
 
-  endpointUrlHasChanged: boolean;
+  endpointHasChanged: boolean;
+  targetNameHasChanged: boolean;
 
   @ViewChild(InlineAlertComponent)
   inlineAlert: InlineAlertComponent;
@@ -63,7 +64,8 @@ export class CreateEditDestinationComponent implements AfterViewChecked {
     this.editable = editable;
 
     this.hasChanged = false;
-    this.endpointUrlHasChanged = false;
+    this.endpointHasChanged = false;
+    this.targetNameHasChanged = false;
 
     this.pingTestMessage = '';
     this.pingStatus = true;
@@ -96,22 +98,17 @@ export class CreateEditDestinationComponent implements AfterViewChecked {
     this.pingStatus = true;
     this.testOngoing = !this.testOngoing;
 
-    let postedTarget: any = {};
-
-    if(!this.endpointUrlHasChanged) {
-       postedTarget = {
-         id: this.target.id
-       };
+    let payload: Target = new Target();
+    if(this.endpointHasChanged) {
+      payload.endpoint = this.target.endpoint;
+      payload.username = this.target.username;
+      payload.password = this.target.password;
     } else {
-      postedTarget = {
-        endpoint: this.target.endpoint,
-        username: this.target.username,
-        password: this.target.password
-      };
+      payload.id = this.target.id;
     }
 
     this.replicationService
-        .pingTarget(postedTarget)
+        .pingTarget(payload)
         .subscribe(
           response=>{
             this.pingStatus = true;
@@ -126,10 +123,16 @@ export class CreateEditDestinationComponent implements AfterViewChecked {
         )
   }
 
+  changedTargetName($event: any) {
+    if(this.editable) {
+      this.targetNameHasChanged = true;
+    }
+  }
+
   clearPassword($event: any) {
     if(this.editable) {
       this.target.password = '';
-      this.endpointUrlHasChanged = true;
+      this.endpointHasChanged = true;
     }
   }
 
@@ -172,12 +175,21 @@ export class CreateEditDestinationComponent implements AfterViewChecked {
           );
         break;
     case ActionType.EDIT:
-      if(!this.endpointUrlHasChanged) {
+      if(!(this.targetNameHasChanged || this.endpointHasChanged)) {
         this.createEditDestinationOpened = false;
         return;
       } 
+      let payload: Target = new Target();
+      if(this.targetNameHasChanged) {
+        payload.name = this.target.name;
+      }
+      if (this.endpointHasChanged) {
+        payload.endpoint = this.target.endpoint;
+        payload.username = this.target.username;
+        payload.password = this.target.password;
+      } 
       this.replicationService
-          .updateTarget(this.target)
+          .updateTarget(payload, this.target.id)
           .subscribe(
             response=>{ 
               this.messageHandlerService.showSuccess('DESTINATION.UPDATED_SUCCESS');
diff --git a/src/ui_ng/src/app/replication/replication.service.ts b/src/ui_ng/src/app/replication/replication.service.ts
index 7190c2d38..910254a0d 100644
--- a/src/ui_ng/src/app/replication/replication.service.ts
+++ b/src/ui_ng/src/app/replication/replication.service.ts
@@ -139,22 +139,21 @@ export class ReplicationService {
   }
 
   pingTarget(target: Target): Observable<any> {
-    let body = new URLSearchParams();
     if(target.id) {
-      body.set('id', target.id + '');
+      return this.http
+               .post(`/api/targets/${target.id}/ping`, {})
+               .map(response=>response.status)
+               .catch(error=>Observable.throw(error));
     }
-    body.set('endpoint', target.endpoint);
-    body.set('username', target.username);
-    body.set('password', target.password);
     return this.http
-               .post(`/api/targets/ping`, body)
+               .post(`/api/targets/ping`, target)
                .map(response=>response.status)
                .catch(error=>Observable.throw(error));
   }
 
-  updateTarget(target: Target): Observable<any> {
+  updateTarget(target: Target, targetId: number): Observable<any> {
     return this.http
-               .put(`/api/targets/${target.id}`, JSON.stringify(target))
+               .put(`/api/targets/${targetId}`, JSON.stringify(target))
                .map(response=>response.status)
                .catch(error=>Observable.throw(error));
   }