diff --git a/Makefile b/Makefile index c89dcec6c..d5e165092 100644 --- a/Makefile +++ b/Makefile @@ -79,7 +79,8 @@ REGISTRYPROJECTNAME=goharbor DEVFLAG=true TRIVYFLAG=false HTTPPROXY= -BUILDBIN=true +BUILDREG=true +BUILDTRIVYADP=true NPM_REGISTRY=https://registry.npmjs.org BUILDTARGET=build GEN_TLS= @@ -392,7 +393,7 @@ build: -e REGISTRYVERSION=$(REGISTRYVERSION) -e REGISTRY_SRC_TAG=$(REGISTRY_SRC_TAG) -e DISTRIBUTION_SRC=$(DISTRIBUTION_SRC)\ -e TRIVYVERSION=$(TRIVYVERSION) -e TRIVYADAPTERVERSION=$(TRIVYADAPTERVERSION) \ -e VERSIONTAG=$(VERSIONTAG) \ - -e BUILDBIN=$(BUILDBIN) \ + -e BUILDREG=$(BUILDREG) -e BUILDTRIVYADP=$(BUILDTRIVYADP) \ -e NPM_REGISTRY=$(NPM_REGISTRY) -e BASEIMAGETAG=$(BASEIMAGETAG) -e IMAGENAMESPACE=$(IMAGENAMESPACE) -e BASEIMAGENAMESPACE=$(BASEIMAGENAMESPACE) \ -e REGISTRYURL=$(REGISTRYURL) \ -e TRIVY_DOWNLOAD_URL=$(TRIVY_DOWNLOAD_URL) -e TRIVY_ADAPTER_DOWNLOAD_URL=$(TRIVY_ADAPTER_DOWNLOAD_URL) \ diff --git a/make/photon/Makefile b/make/photon/Makefile index 44a75255c..e032b554a 100644 --- a/make/photon/Makefile +++ b/make/photon/Makefile @@ -149,7 +149,7 @@ _build_trivy_adapter: rm -rf $(DOCKERFILEPATH_TRIVY_ADAPTER)/binary && mkdir -p $(DOCKERFILEPATH_TRIVY_ADAPTER)/binary ; \ echo "Downloading Trivy scanner $(TRIVYVERSION)..." ; \ $(call _extract_archive, $(TRIVY_DOWNLOAD_URL), $(DOCKERFILEPATH_TRIVY_ADAPTER)/binary/) ; \ - if [ "$(BUILDBIN)" != "true" ] ; then \ + if [ "$(BUILDTRIVYADP)" != "true" ] ; then \ echo "Downloading Trivy adapter $(TRIVYADAPTERVERSION)..." ; \ $(call _extract_archive, $(TRIVY_ADAPTER_DOWNLOAD_URL), $(DOCKERFILEPATH_TRIVY_ADAPTER)/binary/) ; \ else \ @@ -174,7 +174,7 @@ _build_nginx: _build_registry: @$(call _build_base,$(REGISTRY),$(DOCKERFILEPATH_REG)) - @if [ "$(BUILDBIN)" != "true" ] ; then \ + @if [ "$(BUILDREG)" != "true" ] ; then \ rm -rf $(DOCKERFILEPATH_REG)/binary && mkdir -p $(DOCKERFILEPATH_REG)/binary && \ $(call _get_binary, $(REGISTRYURL), $(DOCKERFILEPATH_REG)/binary/registry); \ else \ diff --git a/tests/ci/ut_install.sh b/tests/ci/ut_install.sh index 0d05ecef3..09431586e 100755 --- a/tests/ci/ut_install.sh +++ b/tests/ci/ut_install.sh @@ -26,7 +26,7 @@ sudo rm -rf /data/* sudo -E env "PATH=$PATH" make go_check sudo ./tests/hostcfg.sh sudo ./tests/generateCerts.sh -sudo make build -e BUILDTARGET="_build_db _build_registry _build_prepare" -e PULL_BASE_FROM_DOCKERHUB=false -e BUILDBIN=true +sudo make build -e BUILDTARGET="_build_db _build_registry _build_prepare" -e PULL_BASE_FROM_DOCKERHUB=false -e BUILDREG=true -e BUILDTRIVYADP=true docker run --rm -v /:/hostfs:z goharbor/prepare:dev gencert -p /etc/harbor/tls/internal sudo MAKEPATH=$(pwd)/make ./make/prepare sudo mkdir -p "/data/redis"