Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2025-02-27 17:21:58 +01:00
Code Issues Projects Releases Wiki Activity

fix: delete robots by project id using raw sql (#14951)

Browse Source 
QuerySeter.Delete will call two queies in the orm of beego. First it
will query all primary keys of the model by the QuerySeter, and then the
orm will delete the models using the IN statement of these primary keys.
This will be failed in the postgres when the records more than 65535.
This commit changes to use the raw query to delete the robots of the
project.

Closes #14678

Signed-off-by: He Weiwei <hweiwei@vmware.com>
This commit is contained in:
He Weiwei 2021-05-24 10:31:48 +08:00 committed by GitHub
parent bea27a7da1
commit a1ac9b98df
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/pkg/robot/dao/dao.go
View File

@ -2,11 +2,12 @@ package dao
import (
"context"
"time"
"github.com/goharbor/harbor/src/lib/errors"
"github.com/goharbor/harbor/src/lib/orm"
"github.com/goharbor/harbor/src/lib/q"
"github.com/goharbor/harbor/src/pkg/robot/model"
"time"
)
// DAO defines the interface to access the robot data model
@ -121,14 +122,12 @@ func (d *dao) List(ctx context.Context, query *q.Query) ([]*model.Robot, error)
}
func (d *dao) DeleteByProjectID(ctx context.Context, projectID int64) error {
qs, err := orm.QuerySetter(ctx, &model.Robot{}, &q.Query{
Keywords: map[string]interface{}{
"project_id": projectID,
},
})
ormer, err := orm.FromContext(ctx)
if err != nil {
return err
}
_, err = qs.Delete()
_, err = ormer.Raw("DELETE FROM robot WHERE project_id = ?", projectID).Exec()
return err
}