From 9d47c49c9e4d15b5720e8fd4cedce325f0a4f971 Mon Sep 17 00:00:00 2001 From: Abigail McCarthy Date: Fri, 19 Feb 2021 14:38:56 -0500 Subject: [PATCH 1/2] add PR template to repo Signed-off-by: Abigail McCarthy --- .github/PR_TEMPLATE.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/PR_TEMPLATE.md diff --git a/.github/PR_TEMPLATE.md b/.github/PR_TEMPLATE.md new file mode 100644 index 0000000000..fbcc1328ea --- /dev/null +++ b/.github/PR_TEMPLATE.md @@ -0,0 +1,13 @@ +Thank you for contributing to Harbor! + +### Summary of your change + + +### Issue being fixed + +Fixes #(issue) + +### Please indicate you've done the following: + +- [ ] [Accepted the DCO](https://github.com/goharbor/harbor/blob/master/CONTRIBUTING.md#commit). Commits without the DCO will delay acceptance. +- [ ] Updated the corresponding documentation in this repo or https://github.com/goharbor/website. From 93bdf8be8770841820d2539e3fd6494a2ee8bb9f Mon Sep 17 00:00:00 2001 From: Abigail McCarthy Date: Wed, 7 Apr 2021 12:38:20 -0400 Subject: [PATCH 2/2] update to include testing Signed-off-by: Abigail McCarthy --- .github/PR_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PR_TEMPLATE.md b/.github/PR_TEMPLATE.md index fbcc1328ea..52e4808a76 100644 --- a/.github/PR_TEMPLATE.md +++ b/.github/PR_TEMPLATE.md @@ -10,4 +10,5 @@ Fixes #(issue) ### Please indicate you've done the following: - [ ] [Accepted the DCO](https://github.com/goharbor/harbor/blob/master/CONTRIBUTING.md#commit). Commits without the DCO will delay acceptance. -- [ ] Updated the corresponding documentation in this repo or https://github.com/goharbor/website. +- [ ] Made sure tests are passing and test coverage is added if needed. +- [ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.