Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-12-20 07:37:38 +01:00
Code Issues Projects Releases Wiki Activity

Fix: preheat install update transaction.

Browse Source 
Signed-off-by: fanjiankong <fanjiankong@tencent.com>
This commit is contained in:
fanjiankong 2020-07-22 08:15:18 +08:00
parent 112e38a080
commit adbdaaffe6
1 changed files with 17 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/pkg/p2p/preheat/dao/instance/dao.go
View File

@ -4,7 +4,6 @@ import (
"context" "context"
beego_orm "github.com/astaxie/beego/orm" beego_orm "github.com/astaxie/beego/orm"
"github.com/goharbor/harbor/src/lib/errors"
"github.com/goharbor/harbor/src/lib/orm" "github.com/goharbor/harbor/src/lib/orm"
"github.com/goharbor/harbor/src/lib/q" "github.com/goharbor/harbor/src/lib/q"
"github.com/goharbor/harbor/src/pkg/p2p/preheat/models/provider" "github.com/goharbor/harbor/src/pkg/p2p/preheat/models/provider"
@ -89,40 +88,30 @@ func (d *dao) GetByName(ctx context.Context, name string) (instance *provider.In
// Update updates distribution instance. // Update updates distribution instance.
func (d *dao) Update(ctx context.Context, instance *provider.Instance, props ...string) error { func (d *dao) Update(ctx context.Context, instance *provider.Instance, props ...string) error {
var o, err = orm.FromContext(ctx) var trans = func(ctx context.Context) (err error) {
if err != nil { o, err := orm.FromContext(ctx)
return err if err != nil {
} return
err = o.Begin() }
if err != nil {
return err
}
// check default instances first // check default instances first
for _, prop := range props { for _, prop := range props {
if prop == "default" && instance.Default { if prop == "default" && instance.Default {
_, err = o.Raw("UPDATE ? SET default = false WHERE id != ?", instance.TableName(), instance.ID).Exec() _, err = o.Raw("UPDATE ? SET default = false WHERE id != ?", instance.TableName(), instance.ID).Exec()
if err != nil { if err != nil {
if e := o.Rollback(); e != nil { return
err = errors.Wrap(e, err.Error())
} }
return err
break
} }
break
} }
}
_, err = o.Update(instance, props...) _, err = o.Update(instance, props...)
if err != nil { return
if e := o.Rollback(); e != nil {
err = errors.Wrap(e, err.Error())
}
} else {
err = o.Commit()
} }
return err return orm.WithTransaction(trans)(ctx)
} }
// Delete deletes one distribution instance by id. // Delete deletes one distribution instance by id.