Merge pull request #11693 from reasonerjt/admin-check-userExistence

Allow sys admin to call /c/UserExists
This commit is contained in:
Daniel Jiang 2020-04-24 00:55:26 +08:00 committed by GitHub
commit b140a58a9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -30,6 +30,7 @@ import (
"github.com/goharbor/harbor/src/common"
"github.com/goharbor/harbor/src/common/dao"
"github.com/goharbor/harbor/src/common/models"
"github.com/goharbor/harbor/src/common/security"
"github.com/goharbor/harbor/src/common/utils"
email_util "github.com/goharbor/harbor/src/common/utils/email"
"github.com/goharbor/harbor/src/core/api"
@ -126,8 +127,10 @@ func (cc *CommonController) UserExists() {
if err != nil {
log.Errorf("Failed to get the status of self registration flag, error: %v, disabling user existence check", err)
}
if !flag {
cc.CustomAbort(http.StatusPreconditionFailed, "self registration disabled.")
securityCtx, ok := security.FromContext(cc.Ctx.Request.Context())
isAdmin := ok && securityCtx.IsSysAdmin()
if !flag && !isAdmin {
cc.CustomAbort(http.StatusPreconditionFailed, "self registration disabled, only sysadmin can check user existence")
}
target := cc.GetString("target")