Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-07-11 22:35:14 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7781 from reasonerjt/respond-403-in-oidc-login

Browse Source 
Update login controller to return 403 for redirection
This commit is contained in:
Daniel Jiang 2019-05-14 11:20:03 +08:00 committed by GitHub
commit cbcc28ed16
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/controllers/base.go
View File

@ -91,7 +91,11 @@ func (cc *CommonController) Login() {
}
url := strings.TrimSuffix(ep, "/") + common.OIDCLoginPath
log.Debugf("Redirect user %s to login page of OIDC provider", principal)
cc.Redirect(url, http.StatusFound)
// Return a json to UI with status code 403, as it cannot handle status 302
cc.Ctx.Output.Status = http.StatusForbidden
cc.Ctx.Output.JSON(struct {
Location string `json:"redirect_location"`
}{url}, false, false)
return
}