Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-09-29 13:57:33 +02:00
Code Issues Projects Releases Wiki Activity

fix issue in golint

Browse Source
This commit is contained in:
Tan Jiang 2017-07-21 00:07:42 +08:00
parent ea25c3cfe5
commit cd24c0f171
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/ui/api/scan_job.go
View File

@ -32,37 +32,37 @@ type ScanJobAPI struct {
}
// Prepare validates that whether user has read permission to the project of the repo the scan job scanned.
func (this *ScanJobAPI) Prepare() {
this.BaseController.Prepare()
if !this.SecurityCtx.IsAuthenticated() {
this.HandleUnauthorized()
func (sj *ScanJobAPI) Prepare() {
sj.BaseController.Prepare()
if !sj.SecurityCtx.IsAuthenticated() {
sj.HandleUnauthorized()
return
}
id, err := this.GetInt64FromPath(":id")
id, err := sj.GetInt64FromPath(":id")
if err != nil {
this.CustomAbort(http.StatusBadRequest, "ID is invalid")
sj.CustomAbort(http.StatusBadRequest, "ID is invalid")
}
this.jobID = id
sj.jobID = id
data, err := dao.GetScanJob(id)
if err != nil {
log.Errorf("Failed to load job data for job: %d, error: %v", id, err)
this.CustomAbort(http.StatusInternalServerError, "Failed to get Job data")
sj.CustomAbort(http.StatusInternalServerError, "Failed to get Job data")
}
projectName := strings.SplitN(data.Repository, "/", 2)[0]
if !this.SecurityCtx.HasReadPerm(projectName) {
if !sj.SecurityCtx.HasReadPerm(projectName) {
log.Errorf("User does not have read permission for project: %s", projectName)
this.HandleForbidden(this.SecurityCtx.GetUsername())
sj.HandleForbidden(sj.SecurityCtx.GetUsername())
}
this.projectName = projectName
sj.projectName = projectName
}
//GetLog ...
func (this *ScanJobAPI) GetLog() {
url := buildJobLogURL(strconv.FormatInt(this.jobID, 10), ScanJobType)
err := utils.RequestAsUI(http.MethodGet, url, nil, utils.NewJobLogRespHandler(&this.BaseAPI))
func (sj *ScanJobAPI) GetLog() {
url := buildJobLogURL(strconv.FormatInt(sj.jobID, 10), ScanJobType)
err := utils.RequestAsUI(http.MethodGet, url, nil, utils.NewJobLogRespHandler(&sj.BaseAPI))
if err != nil {
this.RenderError(http.StatusInternalServerError, err.Error())
sj.RenderError(http.StatusInternalServerError, err.Error())
return
}
}