Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2025-01-01 05:28:26 +01:00
Code Issues Projects Releases Wiki Activity

fixes robot account list permission issue (#13792)

Browse Source 
fixes #13786, do not add the removed project into the permission list of a system level robot account.

Signed-off-by: Wang Yan <wangyan@vmware.com>
This commit is contained in:
Wang Yan 2020-12-17 17:50:14 +08:00 committed by GitHub
parent 792dcc4ac3
commit dfe678457f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/controller/robot/controller.go
View File

@ -259,12 +259,16 @@ func (d *controller) populatePermissions(ctx context.Context, r *Robot) error {
var permissions []*Permission var permissions []*Permission
for scope, accesses := range accessMap { for scope, accesses := range accessMap {
p := &Permission{}
kind, namespace, err := d.convertScope(ctx, scope) kind, namespace, err := d.convertScope(ctx, scope)
if err != nil { if err != nil {
// if the project is removed, do not list it in the robot account permission.
if errors.IsNotFoundErr(err) {
continue
}
log.Errorf("failed to decode scope of robot %d: %v", r.ID, err) log.Errorf("failed to decode scope of robot %d: %v", r.ID, err)
return err return err
} }
p := &Permission{}
p.Scope = scope p.Scope = scope
p.Kind = kind p.Kind = kind
p.Namespace = namespace p.Namespace = namespace