Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-12-02 15:14:09 +01:00
Code Issues Projects Releases Wiki Activity

Fix nil job returned bug

Browse Source
This commit is contained in:
Steven Zou 2018-03-23 13:50:23 +08:00
parent 49bb9bfceb
commit e160804be2
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/jobservice_v2/pool/redis_pool.go
View File

@ -256,6 +256,11 @@ func (gcwp *GoCraftWorkPool) Enqueue(jobName string, params models.Parameters, i
return models.JobStats{}, err return models.JobStats{}, err
} }
//avoid backend pool bug
if j == nil {
return models.JobStats{}, fmt.Errorf("job '%s' can not be enqueued, please check the job metatdata", jobName)
}
res := generateResult(j, job.JobKindGeneric, isUnique) res := generateResult(j, job.JobKindGeneric, isUnique)
//Save data with async way. Once it fails to do, let it escape //Save data with async way. Once it fails to do, let it escape
//The client method may help if the job is still in progress when get stats of this job //The client method may help if the job is still in progress when get stats of this job
@ -282,6 +287,11 @@ func (gcwp *GoCraftWorkPool) Schedule(jobName string, params models.Parameters,
return models.JobStats{}, err return models.JobStats{}, err
} }
//avoid backend pool bug
if j == nil {
return models.JobStats{}, fmt.Errorf("job '%s' can not be enqueued, please check the job metatdata", jobName)
}
res := generateResult(j.Job, job.JobKindScheduled, isUnique) res := generateResult(j.Job, job.JobKindScheduled, isUnique)
res.Stats.RunAt = j.RunAt res.Stats.RunAt = j.RunAt