Upstream/harbor
1
0
Fork 0
mirror of https://github.com/goharbor/harbor.git synced 2024-12-28 11:37:42 +01:00
Code Issues Projects Releases Wiki Activity

Check user in security context before getting the ID

Browse Source 
This commit fix a potential nil pointer issue when trying to read User
ID from security context

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
This commit is contained in:
Daniel Jiang 2021-05-18 14:54:58 +08:00
parent 0a8ff4c1f9
commit ebe5733f27
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/controller/user/controller.go
View File

@ -113,7 +113,7 @@ func (c *controller) Get(ctx context.Context, id int, opt *Option) (*models.User
return nil, fmt.Errorf("can't find security context") return nil, fmt.Errorf("can't find security context")
} }
lsc, ok := sctx.(*local.SecurityContext) lsc, ok := sctx.(*local.SecurityContext)
if ok && lsc.User().UserID == id { if ok && lsc.User() != nil && lsc.User().UserID == id {
u.AdminRoleInAuth = lsc.User().AdminRoleInAuth u.AdminRoleInAuth = lsc.User().AdminRoleInAuth
} }
if opt != nil && opt.WithOIDCInfo { if opt != nil && opt.WithOIDCInfo {